* [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child
@ 2019-02-08 11:41 Chris Wilson
2019-02-08 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-02-08 11:41 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Still the blighted
Starting subtest: pi-ringfull-bsd
child 0 died with signal 14, Alarm clock
Subtest pi-ringfull-bsd: FAIL (0.133s)
So let's make sure our timer cannot fire later on during exit.
References https://bugs.freedesktop.org/show_bug.cgi?id=109584
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
tests/i915/gem_exec_schedule.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index d11e57363..00f9528a3 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -1153,7 +1153,9 @@ static void test_pi_ringfull(int fd, unsigned int engine)
bind_to_cpu(0);
igt_fork(child, 1) {
- result[0] = true;
+ int err;
+
+ result[0] = vip != execbuf.rsvd1;
igt_debug("Waking parent\n");
kill(getppid(), SIGALRM);
@@ -1170,12 +1172,18 @@ static void test_pi_ringfull(int fd, unsigned int engine)
*/
igt_debug("HP child executing\n");
execbuf.rsvd1 = vip;
- result[2] = __execbuf(fd, &execbuf) == 0;
+ err = __execbuf(fd, &execbuf);
+ igt_debug("HP execbuf returned %d\n", err);
+
+ memset(&itv, 0, sizeof(itv));
+ setitimer(ITIMER_REAL, &itv, NULL);
+
+ result[2] = err == 0;
}
/* Relinquish CPU just to allow child to create a context */
sleep(1);
- igt_assert_f(result[0], "HP context (child) not created");
+ igt_assert_f(result[0], "HP context (child) not created\n");
igt_assert_f(!result[1], "Child released too early!\n");
/* Parent sleeps waiting for ringspace, releasing child */
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_scheduler: Disable alarm before exiting child
2019-02-08 11:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child Chris Wilson
@ 2019-02-08 12:13 ` Patchwork
2019-02-08 12:30 ` [igt-dev] [PATCH i-g-t] " Joonas Lahtinen
2019-02-08 13:42 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-02-08 12:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_scheduler: Disable alarm before exiting child
URL : https://patchwork.freedesktop.org/series/56390/
State : success
== Summary ==
CI Bug Log - changes from IGT_4814 -> IGTPW_2361
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56390/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2361 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109567]: https://bugs.freedesktop.org/show_bug.cgi?id=109567
Participating hosts (45 -> 45)
------------------------------
Additional (4): fi-hsw-4770r fi-byt-j1900 fi-gdg-551 fi-pnv-d510
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4814 -> IGTPW_2361
CI_DRM_5566: dc8d2739325432dd969028550e9e9b3070b76db1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2361: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2361/
IGT_4814: cec046d72944a2d559ce5bd83358f08f20454005 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2361/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child
2019-02-08 11:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child Chris Wilson
2019-02-08 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-02-08 12:30 ` Joonas Lahtinen
2019-02-08 13:42 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2019-02-08 12:30 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Quoting Chris Wilson (2019-02-08 13:41:09)
> Still the blighted
>
> Starting subtest: pi-ringfull-bsd
> child 0 died with signal 14, Alarm clock
> Subtest pi-ringfull-bsd: FAIL (0.133s)
>
> So let's make sure our timer cannot fire later on during exit.
This starts to reek like broken libc.
The patch below is just next level of paranoia, so:
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
>
> References https://bugs.freedesktop.org/show_bug.cgi?id=109584
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> tests/i915/gem_exec_schedule.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index d11e57363..00f9528a3 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -1153,7 +1153,9 @@ static void test_pi_ringfull(int fd, unsigned int engine)
> bind_to_cpu(0);
>
> igt_fork(child, 1) {
> - result[0] = true;
> + int err;
> +
> + result[0] = vip != execbuf.rsvd1;
>
> igt_debug("Waking parent\n");
> kill(getppid(), SIGALRM);
> @@ -1170,12 +1172,18 @@ static void test_pi_ringfull(int fd, unsigned int engine)
> */
> igt_debug("HP child executing\n");
> execbuf.rsvd1 = vip;
> - result[2] = __execbuf(fd, &execbuf) == 0;
> + err = __execbuf(fd, &execbuf);
> + igt_debug("HP execbuf returned %d\n", err);
> +
> + memset(&itv, 0, sizeof(itv));
> + setitimer(ITIMER_REAL, &itv, NULL);
> +
> + result[2] = err == 0;
> }
>
> /* Relinquish CPU just to allow child to create a context */
> sleep(1);
> - igt_assert_f(result[0], "HP context (child) not created");
> + igt_assert_f(result[0], "HP context (child) not created\n");
> igt_assert_f(!result[1], "Child released too early!\n");
>
> /* Parent sleeps waiting for ringspace, releasing child */
> --
> 2.20.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_scheduler: Disable alarm before exiting child
2019-02-08 11:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child Chris Wilson
2019-02-08 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-08 12:30 ` [igt-dev] [PATCH i-g-t] " Joonas Lahtinen
@ 2019-02-08 13:42 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-02-08 13:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_scheduler: Disable alarm before exiting child
URL : https://patchwork.freedesktop.org/series/56390/
State : success
== Summary ==
CI Bug Log - changes from IGT_4814_full -> IGTPW_2361_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56390/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2361_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@hang:
- shard-snb: NOTRUN -> FAIL [fdo#109469]
* igt@gem_partial_pwrite_pread@write-uncached:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +2
- shard-glk: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +9
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +1
- shard-apl: PASS -> FAIL [fdo#103166] +5
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- shard-glk: NOTRUN -> FAIL [fdo#103166]
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@perf_pmu@rc6-runtime-pm:
- shard-glk: PASS -> FAIL [fdo#105010]
- shard-apl: PASS -> FAIL [fdo#105010]
- shard-kbl: PASS -> FAIL [fdo#105010]
#### Possible fixes ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: FAIL [fdo#107725] / [fdo#108145] -> PASS
* igt@kms_color@pipe-c-ctm-max:
- shard-kbl: FAIL [fdo#108147] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109469]: https://bugs.freedesktop.org/show_bug.cgi?id=109469
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4814 -> IGTPW_2361
CI_DRM_5566: dc8d2739325432dd969028550e9e9b3070b76db1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2361: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2361/
IGT_4814: cec046d72944a2d559ce5bd83358f08f20454005 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2361/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-08 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-08 11:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child Chris Wilson
2019-02-08 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-08 12:30 ` [igt-dev] [PATCH i-g-t] " Joonas Lahtinen
2019-02-08 13:42 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox