From: Stuart Summers <stuart.summers@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] i915/query: Enable QUERY_TOPOLOGY_INFO for all gens
Date: Fri, 8 Feb 2019 16:11:46 -0800 [thread overview]
Message-ID: <20190209001146.14527-1-stuart.summers@intel.com> (raw)
Currently the QUERY_TOPOLOGY_INFO IOCTL is only being tested on haswell,
broadwell, skylake, kabylake, and coffeelake. The i915 driver doesn't
prevent other platforms from accessing this ioctl, so modify IGT to at
least test the interface, even if the platform/gen doesn't contain multiple
GTs.
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
tests/i915/query.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tests/i915/query.c b/tests/i915/query.c
index 3e7fd140..e4757661 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -428,9 +428,6 @@ test_query_topology_known_pci_ids(int fd, int devid)
int n_slices = 0, n_subslices = 0;
int s, ss;
- /* The GT size on some Broadwell skus is not defined, skip those. */
- igt_skip_on(dev_info->gt == 0);
-
memset(&item, 0, sizeof(item));
item.query_id = DRM_I915_QUERY_TOPOLOGY_INFO;
i915_query_items(fd, &item, 1);
@@ -477,7 +474,8 @@ test_query_topology_known_pci_ids(int fd, int devid)
igt_assert_eq(n_subslices, 3 * 3);
break;
default:
- igt_assert(false);
+ /* nothing to check */
+ break;
}
free(topo_info);
@@ -524,9 +522,6 @@ igt_main
igt_subtest("query-topology-known-pci-ids") {
igt_require(query_topology_supported(fd));
- igt_require(IS_HASWELL(devid) || IS_BROADWELL(devid) ||
- IS_SKYLAKE(devid) || IS_KABYLAKE(devid) ||
- IS_COFFEELAKE(devid));
test_query_topology_known_pci_ids(fd, devid);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-02-09 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 0:11 Stuart Summers [this message]
2019-02-09 0:21 ` [igt-dev] [PATCH i-g-t] i915/query: Enable QUERY_TOPOLOGY_INFO for all gens Chris Wilson
2019-02-09 0:32 ` Summers, Stuart
2019-02-09 0:38 ` Chris Wilson
2019-02-09 0:42 ` Summers, Stuart
2019-02-09 0:44 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-09 7:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209001146.14527-1-stuart.summers@intel.com \
--to=stuart.summers@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox