Re: [igt-dev] [PATCH i-g-t] i915/query: Enable QUERY_TOPOLOGY_INFO for all gens

["Summers, Stuart" <stuart.summers@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1297 bytes --]

On Sat, 2019-02-09 at 00:21 +0000, Chris Wilson wrote:
> Quoting Stuart Summers (2019-02-09 00:11:46)
> > Currently the QUERY_TOPOLOGY_INFO IOCTL is only being tested on
> > haswell,
> > broadwell, skylake, kabylake, and coffeelake.
> 
> No, it's tested everywhere it's supported across the other tests.
> Only
> this particular test is skipped if there is no hardcoded truth value
> as 
> only a small number of known pci-ids are supplied.
> 
> Skip is the more accurate result (since the test is not doing
> anything it
> sets out to do, and tests should be reasonably succinct), but you
> could
> move the skip down into the switch() so that we don't repeat
> ourselves.
> -Chris

My reasoning for removing this was to exercise the asserts we are
calling within i915_query_items() for those platforms which do not
implement dev_info->gt. So we are checking something here, even if it
doesn't specifically analyze the slices/subslices for each platform.

I don't think the way it is currently implemented is wrong, but feel
the test could be used to potentially catch a bug if the driver were to
miss something in its dev_info structure for some platform, for
instance.

If you feel strongly we should keep this the way it is, I can drop
this.

Thanks,
Stuart

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev