public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests"
@ 2019-02-15 10:41 Chris Wilson
  2019-02-15 10:47 ` Petri Latvala via igt-dev
  2019-02-15 15:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2019-02-15 10:41 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx, petri.latvala

We don't need to waste time running perf-only test cases when we are not
manually checking results. ezbench is that away!

References: https://bugs.freedesktop.org/show_bug.cgi?id=109640
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/blacklist.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 0e6beeae4..2bdc0b25b 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -50,6 +50,7 @@ igt@gem_mmap@.*(swap|huge).*
 igt@gem_mocs_settings@.*(suspend|hibernate).*
 igt@gem_pin(@.*)?
 igt@gem_pread_after_blit(@.*)?
+igt@gem_pwrite_pread@.*performance.*
 igt@gem_read_read_speed(@.*)?
 igt@gem_reloc_overflow(@.*)?
 igt@gem_reloc_vs_gpu(@.*)?
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests"
  2019-02-15 10:41 [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests" Chris Wilson
@ 2019-02-15 10:47 ` Petri Latvala via igt-dev
  2019-02-15 10:52   ` Chris Wilson
  2019-02-15 15:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  1 sibling, 1 reply; 4+ messages in thread
From: Petri Latvala via igt-dev @ 2019-02-15 10:47 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx

On Fri, Feb 15, 2019 at 10:41:58AM +0000, Chris Wilson wrote:
> We don't need to waste time running perf-only test cases when we are not
> manually checking results. ezbench is that away!
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109640
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---

Remove those subtests, put them in benchmarks/ along with an ezbench
integration script?

Acked-by: Petri Latvala <petri.latvala@intel.com>


>  tests/intel-ci/blacklist.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 0e6beeae4..2bdc0b25b 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -50,6 +50,7 @@ igt@gem_mmap@.*(swap|huge).*
>  igt@gem_mocs_settings@.*(suspend|hibernate).*
>  igt@gem_pin(@.*)?
>  igt@gem_pread_after_blit(@.*)?
> +igt@gem_pwrite_pread@.*performance.*
>  igt@gem_read_read_speed(@.*)?
>  igt@gem_reloc_overflow(@.*)?
>  igt@gem_reloc_vs_gpu(@.*)?
> -- 
> 2.20.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests"
  2019-02-15 10:47 ` Petri Latvala via igt-dev
@ 2019-02-15 10:52   ` Chris Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2019-02-15 10:52 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, intel-gfx

Quoting Petri Latvala (2019-02-15 10:47:09)
> On Fri, Feb 15, 2019 at 10:41:58AM +0000, Chris Wilson wrote:
> > We don't need to waste time running perf-only test cases when we are not
> > manually checking results. ezbench is that away!
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=109640
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> 
> Remove those subtests, put them in benchmarks/ along with an ezbench
> integration script?

It's almost as if they are already there. Except the ezbench integration
scripts predate v1.0, and there's no semi-CI feedback yet so no
motivation...

Though I do like having them around in the test binary as well;
something interesting to read. But I'm weird.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for intel-ci: Ignore performance-only pread/pwrite "tests"
  2019-02-15 10:41 [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests" Chris Wilson
  2019-02-15 10:47 ` Petri Latvala via igt-dev
@ 2019-02-15 15:47 ` Patchwork
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-02-15 15:47 UTC (permalink / raw)
  To: igt-dev

== Series Details ==

Series: intel-ci: Ignore performance-only pread/pwrite "tests"
URL   : https://patchwork.freedesktop.org/series/56718/
State : failure

== Summary ==

Series 56718 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-15 15:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15 10:41 [igt-dev] [PATCH i-g-t] intel-ci: Ignore performance-only pread/pwrite "tests" Chris Wilson
2019-02-15 10:47 ` Petri Latvala via igt-dev
2019-02-15 10:52   ` Chris Wilson
2019-02-15 15:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox