From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures
Date: Thu, 21 Feb 2019 00:43:44 +0100 [thread overview]
Message-ID: <20190220234345.18692-1-daniel.vetter@ffwll.ch> (raw)
Not allowed in igt_simple_main, also really doesn't make any sense,
it's all just one big testcase.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_pwrite_crc.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tests/kms_pwrite_crc.c b/tests/kms_pwrite_crc.c
index ffd72e4abcc5..9bb5a5dabbf9 100644
--- a/tests/kms_pwrite_crc.c
+++ b/tests/kms_pwrite_crc.c
@@ -176,21 +176,17 @@ igt_simple_main
{
igt_skip_on_simulation();
- igt_fixture {
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
- data.devid = intel_get_drm_devid(data.drm_fd);
+ data.devid = intel_get_drm_devid(data.drm_fd);
- kmstest_set_vt_graphics_mode();
+ kmstest_set_vt_graphics_mode();
- igt_require_pipe_crc(data.drm_fd);
+ igt_require_pipe_crc(data.drm_fd);
- igt_display_require(&data.display, data.drm_fd);
- }
+ igt_display_require(&data.display, data.drm_fd);
run_test(&data);
- igt_fixture {
- igt_display_fini(&data.display);
- }
+ igt_display_fini(&data.display);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-02-20 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 23:43 Daniel Vetter [this message]
2019-02-20 23:43 ` [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
2019-02-21 0:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures Patchwork
2019-02-21 10:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 12:39 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220234345.18692-1-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox