From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests
Date: Thu, 21 Feb 2019 00:43:45 +0100 [thread overview]
Message-ID: <20190220234345.18692-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190220234345.18692-1-daniel.vetter@ffwll.ch>
They don't work, see igt_can_fail(). We already check for
test_with_subtests in igt_subtest.
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 71b05d3bbd3b..6eb4798e24ef 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -463,6 +463,7 @@ uint64_t igt_nsec_elapsed(struct timespec *start)
bool __igt_fixture(void)
{
assert(!in_fixture);
+ assert(test_with_subtests);
if (igt_only_list_subtests())
return false;
@@ -975,6 +976,8 @@ bool igt_only_list_subtests(void)
void __igt_subtest_group_save(int *save)
{
+ assert(test_with_subtests);
+
*save = skip_subtests_henceforth;
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-20 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
2019-02-20 23:43 ` Daniel Vetter [this message]
2019-02-21 0:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-02-21 10:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 12:39 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220234345.18692-2-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox