* [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures
@ 2019-02-20 23:43 Daniel Vetter
2019-02-20 23:43 ` [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-02-20 23:43 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
Not allowed in igt_simple_main, also really doesn't make any sense,
it's all just one big testcase.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_pwrite_crc.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tests/kms_pwrite_crc.c b/tests/kms_pwrite_crc.c
index ffd72e4abcc5..9bb5a5dabbf9 100644
--- a/tests/kms_pwrite_crc.c
+++ b/tests/kms_pwrite_crc.c
@@ -176,21 +176,17 @@ igt_simple_main
{
igt_skip_on_simulation();
- igt_fixture {
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
- data.devid = intel_get_drm_devid(data.drm_fd);
+ data.devid = intel_get_drm_devid(data.drm_fd);
- kmstest_set_vt_graphics_mode();
+ kmstest_set_vt_graphics_mode();
- igt_require_pipe_crc(data.drm_fd);
+ igt_require_pipe_crc(data.drm_fd);
- igt_display_require(&data.display, data.drm_fd);
- }
+ igt_display_require(&data.display, data.drm_fd);
run_test(&data);
- igt_fixture {
- igt_display_fini(&data.display);
- }
+ igt_display_fini(&data.display);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
@ 2019-02-20 23:43 ` Daniel Vetter
2019-02-21 0:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-02-20 23:43 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
They don't work, see igt_can_fail(). We already check for
test_with_subtests in igt_subtest.
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 71b05d3bbd3b..6eb4798e24ef 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -463,6 +463,7 @@ uint64_t igt_nsec_elapsed(struct timespec *start)
bool __igt_fixture(void)
{
assert(!in_fixture);
+ assert(test_with_subtests);
if (igt_only_list_subtests())
return false;
@@ -975,6 +976,8 @@ bool igt_only_list_subtests(void)
void __igt_subtest_group_save(int *save)
{
+ assert(test_with_subtests);
+
*save = skip_subtests_henceforth;
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
2019-02-20 23:43 ` [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
@ 2019-02-21 0:37 ` Patchwork
2019-02-21 10:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 12:39 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-02-21 0:37 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures
URL : https://patchwork.freedesktop.org/series/56986/
State : success
== Summary ==
CI Bug Log - changes from IGT_4845 -> IGTPW_2464
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56986/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2464 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-x1275: NOTRUN -> SKIP [fdo#109271] +44
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> SKIP [fdo#109271] +41
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +43
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u2: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (43 -> 41)
------------------------------
Additional (4): fi-icl-y fi-kbl-x1275 fi-hsw-peppy fi-skl-6600u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4845 -> IGTPW_2464
CI_DRM_5643: ae8caafa83ccc6345a91a880a61bed5b70c33373 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2464: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2464/
IGT_4845: da2aa265bb266d427806cd04c748271a3e19f457 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2464/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
2019-02-20 23:43 ` [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
2019-02-21 0:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures Patchwork
@ 2019-02-21 10:00 ` Patchwork
2019-02-21 12:39 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-02-21 10:00 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures
URL : https://patchwork.freedesktop.org/series/56986/
State : success
== Summary ==
CI Bug Log - changes from IGT_4845_full -> IGTPW_2464_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56986/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2464_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_param@invalid-param-get:
- shard-snb: NOTRUN -> FAIL [fdo#109559]
* igt@gem_exec_schedule@fifo-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +154
* igt@gem_pwrite@stolen-normal:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +9
* igt@kms_busy@basic-flip-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +25
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-e:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-pageflip-hang-newfb-render-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_flip@2x-flip-vs-suspend:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +6
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: PASS -> FAIL [fdo#103167]
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +9
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-glk: PASS -> FAIL [fdo#103166] +6
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894]
- shard-apl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: FAIL [fdo#109660] -> PASS
- shard-kbl: FAIL [fdo#109660] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
- shard-apl: FAIL [fdo#108145] -> PASS
- shard-kbl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-hsw: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4845 -> IGTPW_2464
CI_DRM_5643: ae8caafa83ccc6345a91a880a61bed5b70c33373 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2464: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2464/
IGT_4845: da2aa265bb266d427806cd04c748271a3e19f457 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2464/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
` (2 preceding siblings ...)
2019-02-21 10:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-02-21 12:39 ` Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-02-21 12:39 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
On Thu, Feb 21, 2019 at 12:43:44AM +0100, Daniel Vetter wrote:
> Not allowed in igt_simple_main, also really doesn't make any sense,
> it's all just one big testcase.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
This and next one merged with Arek's irc r-b.
-Daniel
> ---
> tests/kms_pwrite_crc.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/tests/kms_pwrite_crc.c b/tests/kms_pwrite_crc.c
> index ffd72e4abcc5..9bb5a5dabbf9 100644
> --- a/tests/kms_pwrite_crc.c
> +++ b/tests/kms_pwrite_crc.c
> @@ -176,21 +176,17 @@ igt_simple_main
> {
> igt_skip_on_simulation();
>
> - igt_fixture {
> - data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> + data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
>
> - data.devid = intel_get_drm_devid(data.drm_fd);
> + data.devid = intel_get_drm_devid(data.drm_fd);
>
> - kmstest_set_vt_graphics_mode();
> + kmstest_set_vt_graphics_mode();
>
> - igt_require_pipe_crc(data.drm_fd);
> + igt_require_pipe_crc(data.drm_fd);
>
> - igt_display_require(&data.display, data.drm_fd);
> - }
> + igt_display_require(&data.display, data.drm_fd);
>
> run_test(&data);
>
> - igt_fixture {
> - igt_display_fini(&data.display);
> - }
> + igt_display_fini(&data.display);
> }
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-21 12:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 23:43 [igt-dev] [PATCH i-g-t 1/2] tests/kms_pwrite_crtc: Drop fixtures Daniel Vetter
2019-02-20 23:43 ` [igt-dev] [PATCH i-g-t 2/2] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
2019-02-21 0:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pwrite_crtc: Drop fixtures Patchwork
2019-02-21 10:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 12:39 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox