[igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all

[igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all

[Ashutosh Dixit]

igt@gem-exec-nop@signal-all runs a single uninterrupted loop for 150
sec. This results in the test being one of the longest execution times
in CI runs. For example:

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5654/runtimes-iclb.txt

Add a lighter version of the same test and include that in CI instead
to cut down the overall CI execution time.

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/gem_exec_nop.c    | 3 +++
 tests/intel-ci/blacklist.txt | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
index 59a08ad0..87ecd6c7 100644
--- a/tests/i915/gem_exec_nop.c
+++ b/tests/i915/gem_exec_nop.c
@@ -769,6 +769,9 @@ igt_main
 	igt_subtest("signal-all")
 		fence_signal(device, handle, ALL_ENGINES, "all", 150);
 
+	igt_subtest("signal-all-light")
+		fence_signal(device, handle, ALL_ENGINES, "all", 10);
+
 	igt_subtest("series")
 		series(device, handle, 150);
 
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index f3440f31..166f158d 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -34,7 +34,7 @@ igt@gem_exec_flush@(?!.*basic).*
 igt@gem_exec_gttfill@(?!.*basic).*
 igt@gem_exec_latency(@.*)?
 igt@gem_exec_lut_handle(@.*)?
-igt@gem_exec_nop@(?!.*(basic|signal-all)).*
+igt@gem_exec_nop@(?!.*(basic|signal-all-light)).*
 igt@gem_exec_reloc@(?!.*basic).*
 igt@gem_exec_suspend@(?!.*basic).*
 igt@gem_exec_whisper@(?!normal$).*
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all

[Chris Wilson]

Quoting Ashutosh Dixit (2019-02-25 18:08:32)
> igt@gem-exec-nop@signal-all runs a single uninterrupted loop for 150
> sec. This results in the test being one of the longest execution times
> in CI runs. For example:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5654/runtimes-iclb.txt
> 
> Add a lighter version of the same test and include that in CI instead
> to cut down the overall CI execution time.
> 
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  tests/i915/gem_exec_nop.c    | 3 +++
>  tests/intel-ci/blacklist.txt | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
> index 59a08ad0..87ecd6c7 100644
> --- a/tests/i915/gem_exec_nop.c
> +++ b/tests/i915/gem_exec_nop.c
> @@ -769,6 +769,9 @@ igt_main
>         igt_subtest("signal-all")
>                 fence_signal(device, handle, ALL_ENGINES, "all", 150);
>  
> +       igt_subtest("signal-all-light")
> +               fence_signal(device, handle, ALL_ENGINES, "all", 10);
> +
>         igt_subtest("series")
>                 series(device, handle, 150);
>  
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index f3440f31..166f158d 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -34,7 +34,7 @@ igt@gem_exec_flush@(?!.*basic).*
>  igt@gem_exec_gttfill@(?!.*basic).*
>  igt@gem_exec_latency(@.*)?
>  igt@gem_exec_lut_handle(@.*)?
> -igt@gem_exec_nop@(?!.*(basic|signal-all)).*
> +igt@gem_exec_nop@(?!.*(basic|signal-all-light)).*

The real question is why is CI running it at all.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all

[Antonio Argenziano]

On 25/02/19 10:18, Chris Wilson wrote:
> Quoting Ashutosh Dixit (2019-02-25 18:08:32)
>> igt@gem-exec-nop@signal-all runs a single uninterrupted loop for 150
>> sec. This results in the test being one of the longest execution times
>> in CI runs. For example:
>>
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5654/runtimes-iclb.txt
>>
>> Add a lighter version of the same test and include that in CI instead
>> to cut down the overall CI execution time.
>>
>> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>> ---
>>   tests/i915/gem_exec_nop.c    | 3 +++
>>   tests/intel-ci/blacklist.txt | 2 +-
>>   2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
>> index 59a08ad0..87ecd6c7 100644
>> --- a/tests/i915/gem_exec_nop.c
>> +++ b/tests/i915/gem_exec_nop.c
>> @@ -769,6 +769,9 @@ igt_main
>>          igt_subtest("signal-all")
>>                  fence_signal(device, handle, ALL_ENGINES, "all", 150);
>>   
>> +       igt_subtest("signal-all-light")
>> +               fence_signal(device, handle, ALL_ENGINES, "all", 10);
>> +
>>          igt_subtest("series")
>>                  series(device, handle, 150);
>>   
>> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
>> index f3440f31..166f158d 100644
>> --- a/tests/intel-ci/blacklist.txt
>> +++ b/tests/intel-ci/blacklist.txt
>> @@ -34,7 +34,7 @@ igt@gem_exec_flush@(?!.*basic).*
>>   igt@gem_exec_gttfill@(?!.*basic).*
>>   igt@gem_exec_latency(@.*)?
>>   igt@gem_exec_lut_handle(@.*)?
>> -igt@gem_exec_nop@(?!.*(basic|signal-all)).*
>> +igt@gem_exec_nop@(?!.*(basic|signal-all-light)).*
> 
> The real question is why is CI running it at all.
Is there any value in running anything from gem_exec_nop?

Antonio

> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_nop: Add a light version of signal-all

[Patchwork]

== Series Details ==

Series: i915/gem_exec_nop: Add a light version of signal-all
URL   : https://patchwork.freedesktop.org/series/57207/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5659 -> IGTPW_2516
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57207/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2516:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live_hangcheck:
    - {fi-icl-y}:         PASS -> DMESG-FAIL

  
Known issues
------------

  Here are the changes found in IGTPW_2516 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          PASS -> FAIL [fdo#103167]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718


Participating hosts (44 -> 40)
------------------------------

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan 


Build changes
-------------

    * IGT: IGT_4854 -> IGTPW_2516

  CI_DRM_5659: bffea990c63087245e8501df82fd45f24ce6ad1f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2516: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2516/
  IGT_4854: 06b0830fb948b9b632342cd26100342aa01cbc79 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_exec_nop@signal-all-light

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2516/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all

[Chris Wilson]

Quoting Antonio Argenziano (2019-02-25 18:38:02)
> 
> 
> On 25/02/19 10:18, Chris Wilson wrote:
> > Quoting Ashutosh Dixit (2019-02-25 18:08:32)
> >> igt@gem-exec-nop@signal-all runs a single uninterrupted loop for 150
> >> sec. This results in the test being one of the longest execution times
> >> in CI runs. For example:
> >>
> >> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5654/runtimes-iclb.txt
> >>
> >> Add a lighter version of the same test and include that in CI instead
> >> to cut down the overall CI execution time.
> >>
> >> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> >> ---
> >>   tests/i915/gem_exec_nop.c    | 3 +++
> >>   tests/intel-ci/blacklist.txt | 2 +-
> >>   2 files changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
> >> index 59a08ad0..87ecd6c7 100644
> >> --- a/tests/i915/gem_exec_nop.c
> >> +++ b/tests/i915/gem_exec_nop.c
> >> @@ -769,6 +769,9 @@ igt_main
> >>          igt_subtest("signal-all")
> >>                  fence_signal(device, handle, ALL_ENGINES, "all", 150);
> >>   
> >> +       igt_subtest("signal-all-light")
> >> +               fence_signal(device, handle, ALL_ENGINES, "all", 10);
> >> +
> >>          igt_subtest("series")
> >>                  series(device, handle, 150);
> >>   
> >> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> >> index f3440f31..166f158d 100644
> >> --- a/tests/intel-ci/blacklist.txt
> >> +++ b/tests/intel-ci/blacklist.txt
> >> @@ -34,7 +34,7 @@ igt@gem_exec_flush@(?!.*basic).*
> >>   igt@gem_exec_gttfill@(?!.*basic).*
> >>   igt@gem_exec_latency(@.*)?
> >>   igt@gem_exec_lut_handle(@.*)?
> >> -igt@gem_exec_nop@(?!.*(basic|signal-all)).*
> >> +igt@gem_exec_nop@(?!.*(basic|signal-all-light)).*
> > 
> > The real question is why is CI running it at all.
> Is there any value in running anything from gem_exec_nop?

Not a great deal. It's the minimal stress test. The signal subtest only
exists so that I could profile the cost of sending a dma_fence signal,
there's nothing along that path that makes me think there's concurrency
issues that need to beaten out.

As for the reset of gem_exec_nop, live_requests is meant to provide for
the trivial stress of hw, and this the uabi equivalent. The basic tests
here do have some interesting properties wrt to interengine
serialisation and is my glxgears of igt -- "does it even work?" And give
me a quick sanity check on whether anything is throwing off the cost of
request submission -- which is their real purpose.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_nop: Add a light version of signal-all

[Patchwork]

== Series Details ==

Series: i915/gem_exec_nop: Add a light version of signal-all
URL   : https://patchwork.freedesktop.org/series/57207/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5659_full -> IGTPW_2516_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57207/revisions/1/mbox/

New tests
---------

  New tests have been introduced between CI_DRM_5659_full and IGTPW_2516_full:

### New IGT tests (1) ###

  * igt@gem_exec_nop@signal-all-light:
    - Statuses : 5 pass(s)
    - Exec time: [10.10, 10.44] s

  

Known issues
------------

  Here are the changes found in IGTPW_2516_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mocs_settings@mocs-reset-bsd2:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +103

  * igt@i915_suspend@fence-restore-untiled:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10

  * igt@kms_atomic_transition@5x-modeset-transitions-nonblocking:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-snb:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
    - shard-glk:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_cursor_crc@cursor-128x42-random:
    - shard-apl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
    - shard-hsw:          PASS -> FAIL [fdo#103355]

  * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
    - shard-snb:          PASS -> SKIP [fdo#109271] +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
    - shard-apl:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-glk:          PASS -> FAIL [fdo#103167] +2

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +31

  * igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
    - shard-apl:          NOTRUN -> FAIL [fdo#108145]
    - shard-kbl:          NOTRUN -> FAIL [fdo#108145]

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
    - shard-apl:          PASS -> FAIL [fdo#103166] +2

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
    - shard-glk:          PASS -> FAIL [fdo#103166] +2

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-kbl:          PASS -> FAIL [fdo#103166] +1

  * igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          PASS -> FAIL [fdo#104894] +3

  * igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  * igt@perf_pmu@busy-accuracy-2-vcs1:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +11

  * igt@prime_vgem@fence-write-hang:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +32

  
#### Possible fixes ####

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
    - shard-glk:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-apl:          FAIL [fdo#106510] / [fdo#108145] -> PASS

  * igt@kms_color@pipe-a-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS
    - shard-kbl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x42-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-64x21-sliding:
    - shard-apl:          FAIL [fdo#103232] -> PASS +4

  * igt@kms_cursor_crc@cursor-size-change:
    - shard-glk:          FAIL [fdo#103232] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          FAIL [fdo#103167] -> PASS +4

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - shard-apl:          FAIL [fdo#103167] / [fdo#105682] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          FAIL [fdo#103167] -> PASS +4

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-apl:          FAIL [fdo#108948] -> PASS +1

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-glk:          INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

  * igt@kms_plane@plane-position-hole-dpms-pipe-b-planes:
    - shard-snb:          SKIP [fdo#109271] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
    - shard-apl:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - shard-glk:          FAIL [fdo#103166] -> PASS +5

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  * igt@prime_busy@hang-vebox:
    - shard-hsw:          FAIL [fdo#108807] -> PASS

  
#### Warnings ####

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> DMESG-FAIL [fdo#105763]

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4854 -> IGTPW_2516
    * Piglit: piglit_4509 -> None

  CI_DRM_5659: bffea990c63087245e8501df82fd45f24ce6ad1f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2516: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2516/
  IGT_4854: 06b0830fb948b9b632342cd26100342aa01cbc79 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2516/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev