* [igt-dev] [RFT i-g-t] lib/i915: Assert mmap size alignment @ 2019-03-01 9:37 Tvrtko Ursulin 2019-03-01 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-03-01 15:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Tvrtko Ursulin @ 2019-03-01 9:37 UTC (permalink / raw) To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Fishing for fails... /* mmap(2) mandates size is page aligned so check this in our wrappers. */ Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- lib/i915/gem_mman.c | 4 ++++ tests/kms_psr.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c index 3cf9a6bbdb31..084dbb3b3678 100644 --- a/lib/i915/gem_mman.c +++ b/lib/i915/gem_mman.c @@ -57,6 +57,8 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot) struct drm_i915_gem_mmap_gtt mmap_arg; void *ptr; + igt_assert(!(size & 4095)); + memset(&mmap_arg, 0, sizeof(mmap_arg)); mmap_arg.handle = handle; if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg)) @@ -162,6 +164,8 @@ static void { struct drm_i915_gem_mmap arg; + igt_assert(!(size & 4095)); + memset(&arg, 0, sizeof(arg)); arg.handle = handle; arg.offset = offset; diff --git a/tests/kms_psr.c b/tests/kms_psr.c index 3e16a6bf4f37..5d3f0ed87eec 100644 --- a/tests/kms_psr.c +++ b/tests/kms_psr.c @@ -270,8 +270,8 @@ static void run_test(data_t *data) expected = "GREEN"; break; case MMAP_GTT: - ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size, - PROT_WRITE); + ptr = gem_mmap__gtt(data->drm_fd, handle, + ALIGN(data->mod_size, 4096), PROT_WRITE); gem_set_domain(data->drm_fd, handle, I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT); memset(ptr, 0xcc, data->mod_size); @@ -279,8 +279,8 @@ static void run_test(data_t *data) expected = "BLACK or TRANSPARENT mark on top of plane in test"; break; case MMAP_CPU: - ptr = gem_mmap__cpu(data->drm_fd, handle, 0, data->mod_size, - PROT_WRITE); + ptr = gem_mmap__cpu(data->drm_fd, handle, 0, + ALIGN(data->mod_size, 4096), PROT_WRITE); gem_set_domain(data->drm_fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU); memset(ptr, 0, data->mod_size); -- 2.19.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/i915: Assert mmap size alignment 2019-03-01 9:37 [igt-dev] [RFT i-g-t] lib/i915: Assert mmap size alignment Tvrtko Ursulin @ 2019-03-01 12:30 ` Patchwork 2019-03-01 15:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-03-01 12:30 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev == Series Details == Series: lib/i915: Assert mmap size alignment URL : https://patchwork.freedesktop.org/series/57396/ State : success == Summary == CI Bug Log - changes from CI_DRM_5676 -> IGTPW_2541 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/57396/revisions/1/mbox/ Known issues ------------ Here are the changes found in IGTPW_2541 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@fork-gfx0: - fi-icl-u2: NOTRUN -> SKIP [fdo#109315] +17 * igt@gem_exec_basic@readonly-bsd1: - fi-icl-u2: NOTRUN -> SKIP [fdo#109276] +7 * igt@gem_exec_basic@readonly-bsd2: - fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76 * igt@gem_exec_parse@basic-allowed: - fi-icl-u2: NOTRUN -> SKIP [fdo#109289] +1 * igt@i915_selftest@live_contexts: - fi-icl-u2: NOTRUN -> DMESG-FAIL [fdo#108569] * igt@i915_selftest@live_hangcheck: - fi-icl-u2: NOTRUN -> INCOMPLETE [fdo#108569] - fi-kbl-7560u: PASS -> INCOMPLETE [fdo#108044] / [fdo#108744] * igt@kms_busy@basic-flip-a: - fi-gdg-551: PASS -> FAIL [fdo#103182] * igt@kms_busy@basic-flip-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_chamelium@dp-edid-read: - fi-icl-u2: NOTRUN -> SKIP [fdo#109316] +2 * igt@kms_chamelium@vga-hpd-fast: - fi-icl-u2: NOTRUN -> SKIP [fdo#109309] +1 * igt@kms_flip@basic-flip-vs-wf_vblank: - fi-bsw-n3050: PASS -> FAIL [fdo#100368] * igt@kms_force_connector_basic@prune-stale-modes: - fi-icl-u2: NOTRUN -> SKIP [fdo#109285] +3 * igt@kms_frontbuffer_tracking@basic: - fi-icl-u2: NOTRUN -> FAIL [fdo#103167] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48 #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: SKIP [fdo#109271] -> PASS * igt@i915_pm_rpm@basic-rte: - fi-bsw-kefka: FAIL [fdo#108800] -> PASS * igt@i915_selftest@live_evict: - fi-bsw-kefka: DMESG-WARN [fdo#107709] -> PASS * igt@kms_busy@basic-flip-b: - fi-gdg-551: FAIL [fdo#103182] -> PASS [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182 [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744 [fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316 Participating hosts (44 -> 40) ------------------------------ Additional (2): fi-icl-u2 fi-pnv-d510 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper Build changes ------------- * IGT: IGT_4866 -> IGTPW_2541 CI_DRM_5676: 3911a5d7d3de6d8e491868bb0cd506346131d71b @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2541: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2541/ IGT_4866: 189956af183c245eb237b3be4fa22953ec93bbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2541/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/i915: Assert mmap size alignment 2019-03-01 9:37 [igt-dev] [RFT i-g-t] lib/i915: Assert mmap size alignment Tvrtko Ursulin 2019-03-01 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2019-03-01 15:39 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-03-01 15:39 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev == Series Details == Series: lib/i915: Assert mmap size alignment URL : https://patchwork.freedesktop.org/series/57396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5676_full -> IGTPW_2541_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_2541_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_2541_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/57396/revisions/1/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_2541_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping: - shard-snb: PASS -> FAIL +1 * igt@kms_plane@pixel-format-pipe-b-planes: - shard-hsw: PASS -> FAIL +5 * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping: - shard-glk: PASS -> FAIL +24 * igt@kms_rotation_crc@sprite-rotation-270: - shard-kbl: PASS -> FAIL +23 * igt@kms_rotation_crc@sprite-rotation-90-pos-100-0: - shard-apl: PASS -> FAIL +16 Known issues ------------ Here are the changes found in IGTPW_2541_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> SKIP [fdo#109271] +50 * igt@gem_exec_store@pages-bsd1: - shard-apl: NOTRUN -> SKIP [fdo#109271] +15 * igt@kms_atomic_transition@4x-modeset-transitions: - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_busy@extended-modeset-hang-newfb-render-c: - shard-hsw: PASS -> DMESG-WARN [fdo#107956] - shard-kbl: PASS -> DMESG-WARN [fdo#107956] * igt@kms_busy@extended-modeset-hang-newfb-render-f: - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3 * igt@kms_busy@extended-pageflip-hang-oldfb-render-f: - shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: - shard-hsw: NOTRUN -> DMESG-WARN [fdo#107956] * igt@kms_cursor_crc@cursor-256x85-random: - shard-apl: PASS -> FAIL [fdo#103232] +1 * igt@kms_cursor_crc@cursor-64x64-random: - shard-kbl: PASS -> FAIL [fdo#103232] +1 * igt@kms_cursor_crc@cursor-alpha-opaque: - shard-glk: PASS -> FAIL [fdo#109350] * igt@kms_cursor_crc@cursor-size-change: - shard-glk: PASS -> FAIL [fdo#103232] * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363] * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-apl: PASS -> INCOMPLETE [fdo#103927] +1 * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-apl: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-1p-rte: - shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682] * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: - shard-glk: PASS -> FAIL [fdo#103167] +11 * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: PASS -> INCOMPLETE [fdo#103665] * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt: - shard-kbl: NOTRUN -> SKIP [fdo#109271] +7 * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt: - shard-hsw: NOTRUN -> SKIP [fdo#109271] +18 * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-onoff: - shard-glk: NOTRUN -> SKIP [fdo#109271] * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc: - shard-apl: PASS -> FAIL [fdo#108145] * igt@kms_plane_multiple@atomic-pipe-a-tiling-y: - shard-glk: PASS -> FAIL [fdo#103166] +5 * igt@kms_universal_plane@universal-plane-pipe-a-functional: - shard-apl: NOTRUN -> FAIL [fdo#103166] * igt@kms_vblank@pipe-a-ts-continuation-modeset-hang: - shard-kbl: PASS -> FAIL [fdo#104894] +2 * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm: - shard-apl: PASS -> FAIL [fdo#104894] +2 * igt@perf_pmu@rc6: - shard-kbl: PASS -> SKIP [fdo#109271] #### Possible fixes #### * igt@gem_eio@in-flight-suspend: - shard-apl: INCOMPLETE [fdo#103927] -> PASS * igt@gem_exec_suspend@basic-s3: - shard-hsw: INCOMPLETE [fdo#103540] -> PASS * igt@kms_busy@extended-modeset-hang-newfb-render-a: - shard-hsw: DMESG-WARN [fdo#107956] -> PASS * igt@kms_cursor_crc@cursor-128x128-suspend: - shard-kbl: DMESG-WARN [fdo#108566] -> PASS * igt@kms_cursor_crc@cursor-256x85-sliding: - shard-kbl: FAIL [fdo#103232] -> PASS +1 * igt@kms_cursor_crc@cursor-64x21-random: - shard-apl: FAIL [fdo#103232] -> PASS +4 * igt@kms_cursor_crc@cursor-64x64-suspend: - shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS * igt@kms_flip@modeset-vs-vblank-race-interruptible: - shard-kbl: FAIL [fdo#103060] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - shard-apl: FAIL [fdo#103167] -> PASS +2 * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: - shard-glk: FAIL [fdo#103167] -> PASS +2 * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-glk: FAIL [fdo#108145] -> PASS - shard-apl: FAIL [fdo#108145] -> PASS - shard-kbl: FAIL [fdo#108145] -> PASS * igt@kms_plane_multiple@atomic-pipe-b-tiling-none: - shard-glk: FAIL [fdo#103166] -> PASS - shard-apl: FAIL [fdo#103166] -> PASS - shard-kbl: FAIL [fdo#103166] -> PASS * igt@kms_setmode@basic: - shard-kbl: FAIL [fdo#99912] -> PASS * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-snb: INCOMPLETE [fdo#105411] -> PASS - shard-kbl: INCOMPLETE [fdo#103665] -> PASS * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend: - shard-apl: FAIL [fdo#104894] -> PASS - shard-kbl: FAIL [fdo#104894] -> PASS {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 5) ------------------------------ Missing (2): shard-skl shard-iclb Build changes ------------- * IGT: IGT_4866 -> IGTPW_2541 * Piglit: piglit_4509 -> None CI_DRM_5676: 3911a5d7d3de6d8e491868bb0cd506346131d71b @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2541: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2541/ IGT_4866: 189956af183c245eb237b3be4fa22953ec93bbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2541/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-01 15:39 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-01 9:37 [igt-dev] [RFT i-g-t] lib/i915: Assert mmap size alignment Tvrtko Ursulin 2019-03-01 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-03-01 15:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox