* [igt-dev] [PATCH] Add a light version of gem_exec_create@forked
@ 2019-03-05 1:16 Swathi Dhanavanthri
2019-03-05 2:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Swathi Dhanavanthri @ 2019-03-05 1:16 UTC (permalink / raw)
To: igt-dev
igt@gem-exec-create@forked runs a single uniterrupted loop for as long
as the timeout specified ie 150s. Reducing this to 15s.
Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
---
tests/i915/gem_exec_create.c | 3 ++-
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index 54a2429e..209b0295 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -146,7 +146,8 @@ igt_main
all(device, 0, 5, 1);
igt_subtest("forked")
all(device, 0, 150, ncpus);
-
+ igt_subtest("forked-light")
+ all(device, 0, 15, ncpus);
igt_subtest("madvise")
all(device, LEAK, 20, 1);
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index f3440f31..27f3b1ef 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -29,6 +29,7 @@ igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
+igt@gem_exec_create@.*forked$
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
igt@gem_exec_gttfill@(?!.*basic).*
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Add a light version of gem_exec_create@forked
2019-03-05 1:16 [igt-dev] [PATCH] Add a light version of gem_exec_create@forked Swathi Dhanavanthri
@ 2019-03-05 2:25 ` Patchwork
2019-03-05 8:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-05 2:25 UTC (permalink / raw)
To: Swathi Dhanavanthri; +Cc: igt-dev
== Series Details ==
Series: Add a light version of gem_exec_create@forked
URL : https://patchwork.freedesktop.org/series/57552/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5702 -> IGTPW_2553
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57552/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2553 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: FAIL [fdo#108511] -> PASS
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP [fdo#109271] / [fdo#109278] -> PASS +2
- fi-gdg-551: FAIL [fdo#103182] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (44 -> 40)
------------------------------
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4870 -> IGTPW_2553
CI_DRM_5702: 6e90cfc547f7145e1c3c057a8d5f117888e23d91 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2553: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2553/
IGT_4870: ed944b45563c694dc6373bc48dc83b8ba7edb19f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_exec_create@forked-light
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2553/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Add a light version of gem_exec_create@forked
2019-03-05 1:16 [igt-dev] [PATCH] Add a light version of gem_exec_create@forked Swathi Dhanavanthri
2019-03-05 2:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-05 8:03 ` Patchwork
2019-03-05 8:42 ` [igt-dev] [PATCH] " Chris Wilson
2019-03-05 8:45 ` Chris Wilson
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-05 8:03 UTC (permalink / raw)
To: Swathi Dhanavanthri; +Cc: igt-dev
== Series Details ==
Series: Add a light version of gem_exec_create@forked
URL : https://patchwork.freedesktop.org/series/57552/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5702_full -> IGTPW_2553_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57552/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5702_full and IGTPW_2553_full:
### New IGT tests (1) ###
* igt@gem_exec_create@forked-light:
- Statuses : 5 pass(s)
- Exec time: [15.25, 15.53] s
Known issues
------------
Here are the changes found in IGTPW_2553_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@promotion-bsd2:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +4
* igt@gem_softpin@noreloc-s3:
- shard-snb: PASS -> DMESG-WARN [fdo#102365]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-kbl: PASS -> FAIL [fdo#109660]
* igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_busy@extended-modeset-hang-newfb-render-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
- shard-snb: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-hang-newfb-render-b:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-degamma:
- shard-kbl: NOTRUN -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_concurrent@pipe-e:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#104873]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: PASS -> FAIL [fdo#103167]
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +31
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-pwrite:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +19
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +23
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: PASS -> FAIL [fdo#103166] +1
* igt@perf_pmu@semaphore-wait-idle-vcs0:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +22
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_color@pipe-a-degamma:
- shard-apl: FAIL [fdo#104782] / [fdo#108145] -> PASS
* igt@kms_color@pipe-c-ctm-max:
- shard-kbl: FAIL [fdo#108147] -> PASS
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x21-offscreen:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +9
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4870 -> IGTPW_2553
* Piglit: piglit_4509 -> None
CI_DRM_5702: 6e90cfc547f7145e1c3c057a8d5f117888e23d91 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2553: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2553/
IGT_4870: ed944b45563c694dc6373bc48dc83b8ba7edb19f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2553/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] Add a light version of gem_exec_create@forked
2019-03-05 1:16 [igt-dev] [PATCH] Add a light version of gem_exec_create@forked Swathi Dhanavanthri
2019-03-05 2:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-05 8:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-05 8:42 ` Chris Wilson
2019-03-06 4:32 ` Ashutosh Dixit
2019-03-05 8:45 ` Chris Wilson
3 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2019-03-05 8:42 UTC (permalink / raw)
To: Swathi Dhanavanthri, igt-dev
Quoting Swathi Dhanavanthri (2019-03-05 01:16:55)
> igt@gem-exec-create@forked runs a single uniterrupted loop for as long
> as the timeout specified ie 150s. Reducing this to 15s.
There is a light version already. The real question is this heavy
enough? What more can we do to induce fault handling along these paths
in the kernel? Run a pagecache hog in the background? Use
faultinjection?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] Add a light version of gem_exec_create@forked
2019-03-05 1:16 [igt-dev] [PATCH] Add a light version of gem_exec_create@forked Swathi Dhanavanthri
` (2 preceding siblings ...)
2019-03-05 8:42 ` [igt-dev] [PATCH] " Chris Wilson
@ 2019-03-05 8:45 ` Chris Wilson
3 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-03-05 8:45 UTC (permalink / raw)
To: Swathi Dhanavanthri, igt-dev
Quoting Swathi Dhanavanthri (2019-03-05 01:16:55)
> igt@gem-exec-create@forked runs a single uniterrupted loop for as long
> as the timeout specified ie 150s. Reducing this to 15s.
Fwiw, a "light" version would have to run until some criteria was
reached to be sure we exercised enough code paths; that would be
something like mem exhaustion in this case. Certainly needs to be sure
that at least a few RCU grace periods have elapsed after that point,
i.e. that we have started our handling the deferred frees.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] Add a light version of gem_exec_create@forked
2019-03-05 8:42 ` [igt-dev] [PATCH] " Chris Wilson
@ 2019-03-06 4:32 ` Ashutosh Dixit
2019-03-06 9:01 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Ashutosh Dixit @ 2019-03-06 4:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Tue, 05 Mar 2019 00:42:07 -0800,
Chris Wilson wrote:
>
> Quoting Swathi Dhanavanthri (2019-03-05 01:16:55)
> > igt@gem-exec-create@forked runs a single uniterrupted loop for as long
> > as the timeout specified ie 150s. Reducing this to 15s.
>
> There is a light version already. The real question is this heavy
> enough? What more can we do to induce fault handling along these paths
> in the kernel? Run a pagecache hog in the background? Use
> faultinjection?
From these comments (and also from a limited understanding of the source
code for the test due to the deferred free's) it appeared that this test is
being run for so long so that it can exhaust system memory. But we just ran
the test with 'top' on and we don't see the system memory go down at
all. If that is indeed the case then what is the point of running this test
for so long? Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] Add a light version of gem_exec_create@forked
2019-03-06 4:32 ` Ashutosh Dixit
@ 2019-03-06 9:01 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-03-06 9:01 UTC (permalink / raw)
To: Ashutosh Dixit; +Cc: igt-dev
Quoting Ashutosh Dixit (2019-03-06 04:32:58)
> On Tue, 05 Mar 2019 00:42:07 -0800,
> Chris Wilson wrote:
> >
> > Quoting Swathi Dhanavanthri (2019-03-05 01:16:55)
> > > igt@gem-exec-create@forked runs a single uniterrupted loop for as long
> > > as the timeout specified ie 150s. Reducing this to 15s.
> >
> > There is a light version already. The real question is this heavy
> > enough? What more can we do to induce fault handling along these paths
> > in the kernel? Run a pagecache hog in the background? Use
> > faultinjection?
>
> From these comments (and also from a limited understanding of the source
> code for the test due to the deferred free's) it appeared that this test is
> being run for so long so that it can exhaust system memory. But we just ran
> the test with 'top' on and we don't see the system memory go down at
> all. If that is indeed the case then what is the point of running this test
> for so long? Thanks!
Yes, at one point it did exhaust memory. And so we imposed some back
pressure on the object creation to avoid that. But it should still be
possible to generate high enough system utilisation that prevents the
freelist from being reaped and so see artifacts during this test.
The first step would be to reduce the memory on the system,
locked = intel_get_pinnable_memory();
munmap(locked + *locked - 128<<20, 128<<20);
and run a one or more memory hogs in the background (see
background_fs()).
The second challenge is detecting when we hit a certain threshold to
be interesting. That's more or less a cycle or two after kswapd kicks
in, but for the purposes of this test can be just an indication that we
hit i915_gem_shrink. For that adding a metric to
debugfs/i915_shrinker_info would seem to be useful.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-06 9:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 1:16 [igt-dev] [PATCH] Add a light version of gem_exec_create@forked Swathi Dhanavanthri
2019-03-05 2:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-05 8:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-05 8:42 ` [igt-dev] [PATCH] " Chris Wilson
2019-03-06 4:32 ` Ashutosh Dixit
2019-03-06 9:01 ` Chris Wilson
2019-03-05 8:45 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox