Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens

[Imre Deak <imre.deak@intel.com>]

On Thu, Mar 07, 2019 at 11:40:20AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2019-03-07 11:35:50)
> > On Mon, Mar 04, 2019 at 03:17:35PM +0000, Chris Wilson wrote:
> > > To have a clearer picture at what may still be holding a wakeref when
> > > all is disabled, show the wakerefs just before we start our wait
> > > believing that no wakerefs remain.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Yep, this would show for instance what's going on in
> > https://bugs.freedesktop.org/show_bug.cgi?id=108800
> 
> Pushed to still how the picture changes.
> 
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
> > 
> > > ---
> > >  tests/i915/i915_pm_rpm.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > > index be296f525..759c76eaf 100644
> > > --- a/tests/i915/i915_pm_rpm.c
> > > +++ b/tests/i915/i915_pm_rpm.c
> > > @@ -756,8 +756,6 @@ static bool setup_environment(void)
> > >       has_runtime_pm = igt_setup_runtime_pm();
> > >       setup_pc8();
> > >  
> > > -     dump_file(debugfs, "i915_runtime_pm_status");
> > > -
> > >       igt_info("Runtime PM support: %d\n", has_runtime_pm);
> > >       igt_info("PC8 residency support: %d\n", has_pc8);
> > >       igt_require(has_runtime_pm);
> > > @@ -765,6 +763,8 @@ static bool setup_environment(void)
> > >  
> > >  out:
> > >       disable_all_screens(&ms_data);
> > > +     dump_file(debugfs, "i915_runtime_pm_status");
> > > +
> > >       return wait_for_suspended();
> 
> I suspect we may want to dump after the wait (as well? not sure).

Was thinking about it too. The actual references should be dropped
already after disabling things, even before any autosuspend_delay_ms
would expire. But that's only the i915 side, not sure about audio.

> But
> one step at a time, as first I want to see what is awake when we start
> our wait.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev