public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens
Date: Thu, 7 Mar 2019 13:35:50 +0200	[thread overview]
Message-ID: <20190307113550.GA23614@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20190304151735.10158-1-chris@chris-wilson.co.uk>

On Mon, Mar 04, 2019 at 03:17:35PM +0000, Chris Wilson wrote:
> To have a clearer picture at what may still be holding a wakeref when
> all is disabled, show the wakerefs just before we start our wait
> believing that no wakerefs remain.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Yep, this would show for instance what's going on in
https://bugs.freedesktop.org/show_bug.cgi?id=108800

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  tests/i915/i915_pm_rpm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index be296f525..759c76eaf 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -756,8 +756,6 @@ static bool setup_environment(void)
>  	has_runtime_pm = igt_setup_runtime_pm();
>  	setup_pc8();
>  
> -	dump_file(debugfs, "i915_runtime_pm_status");
> -
>  	igt_info("Runtime PM support: %d\n", has_runtime_pm);
>  	igt_info("PC8 residency support: %d\n", has_pc8);
>  	igt_require(has_runtime_pm);
> @@ -765,6 +763,8 @@ static bool setup_environment(void)
>  
>  out:
>  	disable_all_screens(&ms_data);
> +	dump_file(debugfs, "i915_runtime_pm_status");
> +
>  	return wait_for_suspended();
>  }
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-07 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 15:17 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens Chris Wilson
2019-03-04 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-04 19:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-07 11:35 ` Imre Deak [this message]
2019-03-07 11:40   ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-03-07 11:46     ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307113550.GA23614@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox