* [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens
@ 2019-03-04 15:17 Chris Wilson
2019-03-04 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2019-03-04 15:17 UTC (permalink / raw)
To: igt-dev
To have a clearer picture at what may still be holding a wakeref when
all is disabled, show the wakerefs just before we start our wait
believing that no wakerefs remain.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/i915_pm_rpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index be296f525..759c76eaf 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -756,8 +756,6 @@ static bool setup_environment(void)
has_runtime_pm = igt_setup_runtime_pm();
setup_pc8();
- dump_file(debugfs, "i915_runtime_pm_status");
-
igt_info("Runtime PM support: %d\n", has_runtime_pm);
igt_info("PC8 residency support: %d\n", has_pc8);
igt_require(has_runtime_pm);
@@ -765,6 +763,8 @@ static bool setup_environment(void)
out:
disable_all_screens(&ms_data);
+ dump_file(debugfs, "i915_runtime_pm_status");
+
return wait_for_suspended();
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for i915/pm_rpm: Show the rpm status after disabling screens
2019-03-04 15:17 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens Chris Wilson
@ 2019-03-04 15:59 ` Patchwork
2019-03-04 19:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-07 11:35 ` [igt-dev] [PATCH i-g-t] " Imre Deak
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-04 15:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/pm_rpm: Show the rpm status after disabling screens
URL : https://patchwork.freedesktop.org/series/57526/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5695 -> IGTPW_2549
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57526/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2549 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720] / [fdo#109799]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-kbl-7560u: INCOMPLETE [fdo#108044] / [fdo#108744] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: SKIP [fdo#109271] -> PASS +33
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109799]: https://bugs.freedesktop.org/show_bug.cgi?id=109799
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4869 -> IGTPW_2549
CI_DRM_5695: b4c3b6ed16419b3d56dbed047fe1d5edd645d65c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2549: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2549/
IGT_4869: a958d3f60b7718151fd0bafcdd1e4874262f51b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2549/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for i915/pm_rpm: Show the rpm status after disabling screens
2019-03-04 15:17 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens Chris Wilson
2019-03-04 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-04 19:34 ` Patchwork
2019-03-07 11:35 ` [igt-dev] [PATCH i-g-t] " Imre Deak
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-04 19:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/pm_rpm: Show the rpm status after disabling screens
URL : https://patchwork.freedesktop.org/series/57526/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5695_full -> IGTPW_2549_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57526/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2549_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parse@basic-allocation:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +20
* igt@gem_exec_schedule@preempt-self-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +36
* igt@i915_suspend@forcewake:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: PASS -> FAIL [fdo#109660]
- shard-kbl: PASS -> FAIL [fdo#109660]
* igt@kms_atomic_transition@plane-all-transition-nonblocking:
- shard-snb: PASS -> SKIP [fdo#109271] +1
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#107956]
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-e:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +8
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +24
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_universal_plane@cursor-fb-leak-pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-apl: PASS -> FAIL [fdo#104894]
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@perf_pmu@rc6:
- shard-kbl: PASS -> SKIP [fdo#109271]
#### Possible fixes ####
* igt@i915_pm_rpm@fences:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +25
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
- shard-snb: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-glk: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-kbl: DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +10
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: FAIL [fdo#103355] -> PASS
* igt@kms_flip@dpms-vs-vblank-race:
- shard-kbl: FAIL [fdo#103060] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-snb: DMESG-WARN [fdo#102365] -> PASS
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: FAIL [fdo#103167] / [fdo#105682] -> PASS
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +4
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
- shard-apl: FAIL [fdo#108145] -> PASS +1
- shard-kbl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS +2
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
- shard-hsw: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: FAIL [fdo#104894] -> PASS +1
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#103167]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4869 -> IGTPW_2549
* Piglit: piglit_4509 -> None
CI_DRM_5695: b4c3b6ed16419b3d56dbed047fe1d5edd645d65c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2549: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2549/
IGT_4869: a958d3f60b7718151fd0bafcdd1e4874262f51b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2549/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens
2019-03-04 15:17 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens Chris Wilson
2019-03-04 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-04 19:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-07 11:35 ` Imre Deak
2019-03-07 11:40 ` Chris Wilson
2 siblings, 1 reply; 6+ messages in thread
From: Imre Deak @ 2019-03-07 11:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Mon, Mar 04, 2019 at 03:17:35PM +0000, Chris Wilson wrote:
> To have a clearer picture at what may still be holding a wakeref when
> all is disabled, show the wakerefs just before we start our wait
> believing that no wakerefs remain.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Yep, this would show for instance what's going on in
https://bugs.freedesktop.org/show_bug.cgi?id=108800
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/i915/i915_pm_rpm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index be296f525..759c76eaf 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -756,8 +756,6 @@ static bool setup_environment(void)
> has_runtime_pm = igt_setup_runtime_pm();
> setup_pc8();
>
> - dump_file(debugfs, "i915_runtime_pm_status");
> -
> igt_info("Runtime PM support: %d\n", has_runtime_pm);
> igt_info("PC8 residency support: %d\n", has_pc8);
> igt_require(has_runtime_pm);
> @@ -765,6 +763,8 @@ static bool setup_environment(void)
>
> out:
> disable_all_screens(&ms_data);
> + dump_file(debugfs, "i915_runtime_pm_status");
> +
> return wait_for_suspended();
> }
>
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens
2019-03-07 11:35 ` [igt-dev] [PATCH i-g-t] " Imre Deak
@ 2019-03-07 11:40 ` Chris Wilson
2019-03-07 11:46 ` Imre Deak
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-03-07 11:40 UTC (permalink / raw)
To: Imre Deak; +Cc: igt-dev
Quoting Imre Deak (2019-03-07 11:35:50)
> On Mon, Mar 04, 2019 at 03:17:35PM +0000, Chris Wilson wrote:
> > To have a clearer picture at what may still be holding a wakeref when
> > all is disabled, show the wakerefs just before we start our wait
> > believing that no wakerefs remain.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Yep, this would show for instance what's going on in
> https://bugs.freedesktop.org/show_bug.cgi?id=108800
Pushed to still how the picture changes.
> Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> > ---
> > tests/i915/i915_pm_rpm.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > index be296f525..759c76eaf 100644
> > --- a/tests/i915/i915_pm_rpm.c
> > +++ b/tests/i915/i915_pm_rpm.c
> > @@ -756,8 +756,6 @@ static bool setup_environment(void)
> > has_runtime_pm = igt_setup_runtime_pm();
> > setup_pc8();
> >
> > - dump_file(debugfs, "i915_runtime_pm_status");
> > -
> > igt_info("Runtime PM support: %d\n", has_runtime_pm);
> > igt_info("PC8 residency support: %d\n", has_pc8);
> > igt_require(has_runtime_pm);
> > @@ -765,6 +763,8 @@ static bool setup_environment(void)
> >
> > out:
> > disable_all_screens(&ms_data);
> > + dump_file(debugfs, "i915_runtime_pm_status");
> > +
> > return wait_for_suspended();
I suspect we may want to dump after the wait (as well? not sure). But
one step at a time, as first I want to see what is awake when we start
our wait.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens
2019-03-07 11:40 ` Chris Wilson
@ 2019-03-07 11:46 ` Imre Deak
0 siblings, 0 replies; 6+ messages in thread
From: Imre Deak @ 2019-03-07 11:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Thu, Mar 07, 2019 at 11:40:20AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2019-03-07 11:35:50)
> > On Mon, Mar 04, 2019 at 03:17:35PM +0000, Chris Wilson wrote:
> > > To have a clearer picture at what may still be holding a wakeref when
> > > all is disabled, show the wakerefs just before we start our wait
> > > believing that no wakerefs remain.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Yep, this would show for instance what's going on in
> > https://bugs.freedesktop.org/show_bug.cgi?id=108800
>
> Pushed to still how the picture changes.
>
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > > ---
> > > tests/i915/i915_pm_rpm.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > > index be296f525..759c76eaf 100644
> > > --- a/tests/i915/i915_pm_rpm.c
> > > +++ b/tests/i915/i915_pm_rpm.c
> > > @@ -756,8 +756,6 @@ static bool setup_environment(void)
> > > has_runtime_pm = igt_setup_runtime_pm();
> > > setup_pc8();
> > >
> > > - dump_file(debugfs, "i915_runtime_pm_status");
> > > -
> > > igt_info("Runtime PM support: %d\n", has_runtime_pm);
> > > igt_info("PC8 residency support: %d\n", has_pc8);
> > > igt_require(has_runtime_pm);
> > > @@ -765,6 +763,8 @@ static bool setup_environment(void)
> > >
> > > out:
> > > disable_all_screens(&ms_data);
> > > + dump_file(debugfs, "i915_runtime_pm_status");
> > > +
> > > return wait_for_suspended();
>
> I suspect we may want to dump after the wait (as well? not sure).
Was thinking about it too. The actual references should be dropped
already after disabling things, even before any autosuspend_delay_ms
would expire. But that's only the i915 side, not sure about audio.
> But
> one step at a time, as first I want to see what is awake when we start
> our wait.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-07 11:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 15:17 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Show the rpm status after disabling screens Chris Wilson
2019-03-04 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-04 19:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-07 11:35 ` [igt-dev] [PATCH i-g-t] " Imre Deak
2019-03-07 11:40 ` Chris Wilson
2019-03-07 11:46 ` Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox