public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Daniel Vetter <daniel@ffwll.ch>
Subject: [igt-dev] [PATCH i-g-t 2/2] Revert "tests: kms_plane: Disable XBGR8888"
Date: Mon, 11 Mar 2019 15:32:22 +0200	[thread overview]
Message-ID: <20190311133222.10030-2-arkadiusz.hiler@intel.com> (raw)
In-Reply-To: <20190311133222.10030-1-arkadiusz.hiler@intel.com>

This reverts commit 067a68969b2d41e101ac778b06f2743fa69b27ab.

With the kms_plane pixel format tests now exhaustively testing all the
formats even with early CRC mismatches, it's better to not hide such
issues in IGT. There are other systems in place to do such things.

Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/kms_plane.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 4cd0b565..bb92f078 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -534,16 +534,6 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 		if (!igt_fb_supported_format(format))
 			continue;
 
-		/*
-		 * There seems to be some issue there with the CRC not
-		 * matching. Both CRCs are stable, but don't match,
-		 * which seems to indicate some issue with the CRC
-		 * computation logic, but I haven't been able to find
-		 * what.
-		 */
-		if (format == DRM_FORMAT_XBGR8888)
-			continue;
-
 		igt_info("Testing format " IGT_FORMAT_FMT " on %s.%u\n",
 			 IGT_FORMAT_ARGS(format),
 			 kmstest_pipe_name(pipe), plane->index);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-03-11 13:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 13:32 [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Keep testing pixel formats even if one fails Arkadiusz Hiler
2019-03-11 13:32 ` Arkadiusz Hiler [this message]
2019-03-11 14:13   ` [igt-dev] [PATCH i-g-t 2/2] Revert "tests: kms_plane: Disable XBGR8888" Daniel Vetter
2019-03-11 14:55 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane: Keep testing pixel formats even if one fails Patchwork
2019-03-11 16:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-03-12 11:26 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane: Keep testing pixel formats even if one fails (rev2) Patchwork
2019-03-12 13:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311133222.10030-2-arkadiusz.hiler@intel.com \
    --to=arkadiusz.hiler@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox