Re: [igt-dev] [PATCH i-g-t 2/2] Revert "tests: kms_plane: Disable XBGR8888"

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Mar 11, 2019 at 03:32:22PM +0200, Arkadiusz Hiler wrote:
> This reverts commit 067a68969b2d41e101ac778b06f2743fa69b27ab.
> 
> With the kms_plane pixel format tests now exhaustively testing all the
> formats even with early CRC mismatches, it's better to not hide such
> issues in IGT. There are other systems in place to do such things.
> 
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

On both patches:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  tests/kms_plane.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 4cd0b565..bb92f078 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -534,16 +534,6 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>  		if (!igt_fb_supported_format(format))
>  			continue;
>  
> -		/*
> -		 * There seems to be some issue there with the CRC not
> -		 * matching. Both CRCs are stable, but don't match,
> -		 * which seems to indicate some issue with the CRC
> -		 * computation logic, but I haven't been able to find
> -		 * what.
> -		 */
> -		if (format == DRM_FORMAT_XBGR8888)
> -			continue;
> -
>  		igt_info("Testing format " IGT_FORMAT_FMT " on %s.%u\n",
>  			 IGT_FORMAT_ARGS(format),
>  			 kmstest_pipe_name(pipe), plane->index);
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev