* [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing
@ 2019-03-11 16:47 Daniel Vetter
2019-03-11 17:03 ` Ville Syrjälä
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-03-11 16:47 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
Steal if from kms_plane.c and put it into igt_fb.h
Also tiny bikeshed to remove the space, so it fits more tidily into
the usual name1=value1, name2=value2 style printing.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_fb.c | 6 ++++--
lib/igt_fb.h | 4 ++++
tests/kms_plane.c | 3 ---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f49becbd52f0..bafb0d085af7 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1115,8 +1115,10 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
fb->size = bo_size;
- igt_debug("%s(width=%d, height=%d, format=0x%x, tiling=0x%"PRIx64", size=%"PRIu64")\n",
- __func__, width, height, format, tiling, bo_size);
+ igt_debug("%s(width=%d, height=%d, format=" IGT_FORMAT_FMT
+ ", tiling=0x%"PRIx64", size=%"PRIu64")\n",
+ __func__, width, height, IGT_FORMAT_ARGS(format), tiling,
+ bo_size);
create_bo_for_fb(fb);
igt_assert(fb->gem_handle > 0);
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index e1d885e2c5bc..d53b68e56318 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -44,6 +44,10 @@
*/
#define IGT_FORMAT_FLOAT fourcc_code('I', 'G', 'F', 'x')
+#define IGT_FORMAT_FMT "%c%c%c%c(0x%08x)"
+#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
+ ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
+
/**
* igt_fb_t:
* @fb_id: KMS ID of the framebuffer
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 91de46948a3a..68db63ca893a 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -401,9 +401,6 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
free(lut);
}
-#define IGT_FORMAT_FMT "%c%c%c%c (0x%08x)"
-#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
- ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
static void test_format_plane_color(data_t *data, enum pipe pipe,
igt_plane_t *plane,
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
@ 2019-03-11 17:03 ` Ville Syrjälä
2019-03-12 9:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2019-03-11 17:03 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Daniel Vetter
On Mon, Mar 11, 2019 at 05:47:43PM +0100, Daniel Vetter wrote:
> Steal if from kms_plane.c and put it into igt_fb.h
>
> Also tiny bikeshed to remove the space, so it fits more tidily into
> the usual name1=value1, name2=value2 style printing.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_fb.c | 6 ++++--
> lib/igt_fb.h | 4 ++++
> tests/kms_plane.c | 3 ---
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index f49becbd52f0..bafb0d085af7 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1115,8 +1115,10 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
>
> fb->size = bo_size;
>
> - igt_debug("%s(width=%d, height=%d, format=0x%x, tiling=0x%"PRIx64", size=%"PRIu64")\n",
> - __func__, width, height, format, tiling, bo_size);
> + igt_debug("%s(width=%d, height=%d, format=" IGT_FORMAT_FMT
> + ", tiling=0x%"PRIx64", size=%"PRIu64")\n",
> + __func__, width, height, IGT_FORMAT_ARGS(format), tiling,
> + bo_size);
>
> create_bo_for_fb(fb);
> igt_assert(fb->gem_handle > 0);
> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
> index e1d885e2c5bc..d53b68e56318 100644
> --- a/lib/igt_fb.h
> +++ b/lib/igt_fb.h
> @@ -44,6 +44,10 @@
> */
> #define IGT_FORMAT_FLOAT fourcc_code('I', 'G', 'F', 'x')
>
> +#define IGT_FORMAT_FMT "%c%c%c%c(0x%08x)"
> +#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
> + ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
> +
> /**
> * igt_fb_t:
> * @fb_id: KMS ID of the framebuffer
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 91de46948a3a..68db63ca893a 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -401,9 +401,6 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
> free(lut);
> }
>
> -#define IGT_FORMAT_FMT "%c%c%c%c (0x%08x)"
> -#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
> - ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
>
> static void test_format_plane_color(data_t *data, enum pipe pipe,
> igt_plane_t *plane,
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: better format printing
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
2019-03-11 17:03 ` Ville Syrjälä
@ 2019-03-12 9:50 ` Patchwork
2019-03-12 13:51 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-03-12 9:50 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: lib/igt_fb: better format printing
URL : https://patchwork.freedesktop.org/series/57845/
State : failure
== Summary ==
Applying: lib/igt_fb: better format printing
Using index info to reconstruct a base tree...
M lib/igt_fb.c
M lib/igt_fb.h
Falling back to patching base and 3-way merge...
Auto-merging lib/igt_fb.h
Auto-merging lib/igt_fb.c
CONFLICT (content): Merge conflict in lib/igt_fb.c
Patch failed at 0001 lib/igt_fb: better format printing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
2019-03-11 17:03 ` Ville Syrjälä
2019-03-12 9:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-03-12 13:51 ` Daniel Vetter
2019-03-12 13:53 ` Daniel Vetter
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-03-12 13:51 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
Steal if from kms_plane.c and put it into igt_fb.h
Also tiny bikeshed to remove the space, so it fits more tidily into
the usual name1=value1, name2=value2 style printing.
v2: Rebase
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_fb.c | 6 ++++--
lib/igt_fb.h | 4 ++++
tests/kms_plane.c | 3 ---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index e696c863ea70..9f9f7aac0935 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1146,8 +1146,10 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
fb->size = bo_size;
- igt_debug("%s(width=%d, height=%d, format=0x%x, modifier=0x%"PRIx64", size=%"PRIu64")\n",
- __func__, width, height, format, modifier, bo_size);
+ igt_debug("%s(width=%d, height=%d, format=" IGT_FORMAT_FM
+ "", modifier=0x%"PRIx64", size=%"PRIu64")\n",
+ __func__, width, height, IGT_FORMAT_ARGS(format), modifier,
+ bo_size);
create_bo_for_fb(fb);
igt_assert(fb->gem_handle > 0);
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 7667579b3d98..ba22bd664510 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -44,6 +44,10 @@
*/
#define IGT_FORMAT_FLOAT fourcc_code('I', 'G', 'F', 'x')
+#define IGT_FORMAT_FMT "%c%c%c%c(0x%08x)"
+#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
+ ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
+
/**
* igt_fb_t:
* @fb_id: KMS ID of the framebuffer
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index d8098bef891a..69069f6b1356 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -401,9 +401,6 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
free(lut);
}
-#define IGT_FORMAT_FMT "%c%c%c%c (0x%08x)"
-#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
- ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
static void test_format_plane_color(data_t *data, enum pipe pipe,
igt_plane_t *plane,
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
` (2 preceding siblings ...)
2019-03-12 13:51 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
@ 2019-03-12 13:53 ` Daniel Vetter
2019-03-13 16:27 ` Daniel Vetter
2019-03-13 11:22 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: better format printing (rev3) Patchwork
2019-03-13 14:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-03-12 13:53 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
Steal if from kms_plane.c and put it into igt_fb.h
Also tiny bikeshed to remove the space, so it fits more tidily into
the usual name1=value1, name2=value2 style printing.
v2: Rebase
v3: It better compile :-/
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_fb.c | 6 ++++--
lib/igt_fb.h | 4 ++++
tests/kms_plane.c | 3 ---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index e696c863ea70..6a9a93417230 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1146,8 +1146,10 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
fb->size = bo_size;
- igt_debug("%s(width=%d, height=%d, format=0x%x, modifier=0x%"PRIx64", size=%"PRIu64")\n",
- __func__, width, height, format, modifier, bo_size);
+ igt_debug("%s(width=%d, height=%d, format=" IGT_FORMAT_FMT
+ ", modifier=0x%"PRIx64", size=%"PRIu64")\n",
+ __func__, width, height, IGT_FORMAT_ARGS(format), modifier,
+ bo_size);
create_bo_for_fb(fb);
igt_assert(fb->gem_handle > 0);
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 7667579b3d98..ba22bd664510 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -44,6 +44,10 @@
*/
#define IGT_FORMAT_FLOAT fourcc_code('I', 'G', 'F', 'x')
+#define IGT_FORMAT_FMT "%c%c%c%c(0x%08x)"
+#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
+ ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
+
/**
* igt_fb_t:
* @fb_id: KMS ID of the framebuffer
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index d8098bef891a..69069f6b1356 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -401,9 +401,6 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
free(lut);
}
-#define IGT_FORMAT_FMT "%c%c%c%c (0x%08x)"
-#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
- ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
static void test_format_plane_color(data_t *data, enum pipe pipe,
igt_plane_t *plane,
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: better format printing (rev3)
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
` (3 preceding siblings ...)
2019-03-12 13:53 ` Daniel Vetter
@ 2019-03-13 11:22 ` Patchwork
2019-03-13 14:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-03-13 11:22 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: lib/igt_fb: better format printing (rev3)
URL : https://patchwork.freedesktop.org/series/57845/
State : success
== Summary ==
CI Bug Log - changes from IGT_4883 -> IGTPW_2596
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57845/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2596 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_suspend@basic-s3:
- fi-icl-u3: PASS -> FAIL [fdo#103375]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-n2820: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@basic-rte:
- fi-byt-n2820: PASS -> FAIL [fdo#108800]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +52
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: PASS -> FAIL [fdo#100368]
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> SKIP [fdo#109271] +49
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> DMESG-FAIL [fdo#103182]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (46 -> 42)
------------------------------
Additional (3): fi-byt-j1900 fi-skl-guc fi-bxt-j4205
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y
Build changes
-------------
* IGT: IGT_4883 -> IGTPW_2596
CI_DRM_5736: d0b266074ff4ac02e49b3a0af1781551f36bead3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2596: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2596/
IGT_4883: b25e06d6ddf2e42044cd9c93b613cbc7339a8c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2596/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_fb: better format printing (rev3)
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
` (4 preceding siblings ...)
2019-03-13 11:22 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: better format printing (rev3) Patchwork
@ 2019-03-13 14:32 ` Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-03-13 14:32 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: lib/igt_fb: better format printing (rev3)
URL : https://patchwork.freedesktop.org/series/57845/
State : success
== Summary ==
CI Bug Log - changes from IGT_4883_full -> IGTPW_2596_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57845/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2596_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-apl: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2596_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] / [fdo#107807]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
- shard-snb: PASS -> DMESG-WARN [fdo#107956]
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-bad-pixel-format:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +40
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] +1
* igt@kms_color@pipe-a-degamma:
- shard-glk: NOTRUN -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_color@pipe-c-degamma:
- shard-kbl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> DMESG-FAIL [fdo#103558] / [fdo#105602]
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
- shard-apl: NOTRUN -> SKIP [fdo#105602] / [fdo#109271]
* igt@kms_flip@2x-flip-vs-fences:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> DMESG-FAIL [fdo#103167] / [fdo#103558] / [fdo#105602] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +12
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +33
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +11
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> DMESG-FAIL [fdo#103166] / [fdo#103558] / [fdo#105602]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@perf@oa-exponents:
- shard-glk: PASS -> FAIL [fdo#105483]
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +1
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +6
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-apl: FAIL [fdo#110033] -> PASS
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +2
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110033]: https://bugs.freedesktop.org/show_bug.cgi?id=110033
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4883 -> IGTPW_2596
CI_DRM_5736: d0b266074ff4ac02e49b3a0af1781551f36bead3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2596: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2596/
IGT_4883: b25e06d6ddf2e42044cd9c93b613cbc7339a8c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2596/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing
2019-03-12 13:53 ` Daniel Vetter
@ 2019-03-13 16:27 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-03-13 16:27 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
On Tue, Mar 12, 2019 at 02:53:32PM +0100, Daniel Vetter wrote:
> Steal if from kms_plane.c and put it into igt_fb.h
>
> Also tiny bikeshed to remove the space, so it fits more tidily into
> the usual name1=value1, name2=value2 style printing.
>
> v2: Rebase
>
> v3: It better compile :-/
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v1)
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
... and pushed.
-Daniel
> ---
> lib/igt_fb.c | 6 ++++--
> lib/igt_fb.h | 4 ++++
> tests/kms_plane.c | 3 ---
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index e696c863ea70..6a9a93417230 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1146,8 +1146,10 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
>
> fb->size = bo_size;
>
> - igt_debug("%s(width=%d, height=%d, format=0x%x, modifier=0x%"PRIx64", size=%"PRIu64")\n",
> - __func__, width, height, format, modifier, bo_size);
> + igt_debug("%s(width=%d, height=%d, format=" IGT_FORMAT_FMT
> + ", modifier=0x%"PRIx64", size=%"PRIu64")\n",
> + __func__, width, height, IGT_FORMAT_ARGS(format), modifier,
> + bo_size);
>
> create_bo_for_fb(fb);
> igt_assert(fb->gem_handle > 0);
> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
> index 7667579b3d98..ba22bd664510 100644
> --- a/lib/igt_fb.h
> +++ b/lib/igt_fb.h
> @@ -44,6 +44,10 @@
> */
> #define IGT_FORMAT_FLOAT fourcc_code('I', 'G', 'F', 'x')
>
> +#define IGT_FORMAT_FMT "%c%c%c%c(0x%08x)"
> +#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
> + ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
> +
> /**
> * igt_fb_t:
> * @fb_id: KMS ID of the framebuffer
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index d8098bef891a..69069f6b1356 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -401,9 +401,6 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
> free(lut);
> }
>
> -#define IGT_FORMAT_FMT "%c%c%c%c (0x%08x)"
> -#define IGT_FORMAT_ARGS(f) ((f) >> 0) & 0xff, ((f) >> 8) & 0xff, \
> - ((f) >> 16) & 0xff, ((f) >> 24) & 0xff, (f)
>
> static void test_format_plane_color(data_t *data, enum pipe pipe,
> igt_plane_t *plane,
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-13 16:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-11 16:47 [igt-dev] [PATCH i-g-t] lib/igt_fb: better format printing Daniel Vetter
2019-03-11 17:03 ` Ville Syrjälä
2019-03-12 9:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-03-12 13:51 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-03-12 13:53 ` Daniel Vetter
2019-03-13 16:27 ` Daniel Vetter
2019-03-13 11:22 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: better format printing (rev3) Patchwork
2019-03-13 14:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox