* [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value
@ 2019-03-19 13:46 Stanislav Lisovskiy
2019-03-19 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stanislav Lisovskiy @ 2019-03-19 13:46 UTC (permalink / raw)
To: igt-dev; +Cc: stanislav.lisovskiy, martin.peres
Lot of tests fail, when assertion checking
how many vblanks should have passed during
suspend/resume is compared to magic value 150.
At the same time even for failed cases, sometimes
it is clearly visible that there were no issue -
simply suspend took longer on that machine.
If suspend took around 10 s and we get roughly
60 vblanks per second the value then should be
around 600 and not 150.
This change removes 150 magic value and starts
to use calculation of what it is expected to
be instead of being hardcoded.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104894
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
tests/kms_vblank.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index dafadb58..80b2a23a 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -338,8 +338,13 @@ static void vblank_ts_cont(data_t *data, int fd, int nchildren)
igt_output_t *output = data->output;
int seq1, seq2;
union drm_wait_vblank vbl;
+ struct timespec start, end;
+ int estimated_vblanks = 0;
+ int vrefresh = igt_output_get_mode(output)->vrefresh;
+ double time_elapsed;
seq1 = get_vblank(fd, data->pipe, 0);
+ clock_gettime(CLOCK_MONOTONIC, &start);
if (data->flags & DPMS) {
igt_output_set_prop_value(output, IGT_CONNECTOR_DPMS, DRM_MODE_DPMS_OFF);
@@ -377,11 +382,17 @@ static void vblank_ts_cont(data_t *data, int fd, int nchildren)
}
seq2 = get_vblank(fd, data->pipe, 0);
+ clock_gettime(CLOCK_MONOTONIC, &end);
+
+ time_elapsed = igt_time_elapsed(&start, &end);
+ estimated_vblanks = (int)(time_elapsed * vrefresh) + 1;
igt_debug("testing ts continuity: Current frame %u, old frame %u\n", seq2, seq1);
- igt_assert_f(seq2 - seq1 >= 0, "unexpected vblank seq %u, should be >= %u\n", seq2, seq1);
- igt_assert_f(seq2 - seq1 <= 150, "unexpected vblank seq %u, should be < %u\n", seq2, seq1 + 150);
+ igt_assert_f(seq2 - seq1 >= 0, "elapsed %f(%d vblanks) unexpected vblank seq %u, should be >= %u\n", time_elapsed,
+ estimated_vblanks, seq2, seq1);
+ igt_assert_f(seq2 - seq1 <= estimated_vblanks, "elapsed %f(%d vblanks) unexpected vblank seq %u, should be < %u\n", time_elapsed,
+ estimated_vblanks, seq2, seq1 + estimated_vblanks);
}
static void run_subtests_for_pipe(data_t *data)
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt: tests: kms_vblank: Stop using magic value
2019-03-19 13:46 [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value Stanislav Lisovskiy
@ 2019-03-19 14:48 ` Patchwork
2019-03-19 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-02 13:00 ` [igt-dev] [PATCH i-g-t] " Lisovskiy, Stanislav
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-19 14:48 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: igt-dev
== Series Details ==
Series: igt: tests: kms_vblank: Stop using magic value
URL : https://patchwork.freedesktop.org/series/58189/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5772 -> IGTPW_2660
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58189/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2660 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +55
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@dp-hpd-fast:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +41
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- {fi-icl-y}: DMESG-WARN [fdo#109638] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638
Participating hosts (41 -> 41)
------------------------------
Additional (5): fi-bsw-n3050 fi-hsw-peppy fi-pnv-d510 fi-bsw-kefka fi-skl-6700k2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4889 -> IGTPW_2660
CI_DRM_5772: 16930b29faa6d6fe08f44affe7753c85db95258f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2660: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2660/
IGT_4889: e3faf0fd49b7e3a763bf89e11fb4fdce81839da2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2660/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt: tests: kms_vblank: Stop using magic value
2019-03-19 13:46 [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value Stanislav Lisovskiy
2019-03-19 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-19 21:21 ` Patchwork
2019-04-02 13:00 ` [igt-dev] [PATCH i-g-t] " Lisovskiy, Stanislav
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-19 21:21 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: igt-dev
== Series Details ==
Series: igt: tests: kms_vblank: Stop using magic value
URL : https://patchwork.freedesktop.org/series/58189/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5772_full -> IGTPW_2660_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58189/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2660_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane@pixel-format-pipe-a-planes}:
- shard-apl: PASS -> FAIL
* {igt@kms_plane@pixel-format-pipe-c-planes}:
- shard-kbl: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2660_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_store@pages-bsd2:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +5
* igt@i915_pm_rpm@gem-execbuf:
- shard-apl: PASS -> DMESG-WARN [fdo#103558]
* igt@i915_pm_rps@waitboost:
- shard-apl: PASS -> FAIL [fdo#102250]
- shard-glk: PASS -> FAIL [fdo#102250]
* igt@kms_atomic_transition@3x-modeset-transitions-fencing:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@basic-flip-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956] +1
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +2
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +6
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-onoff:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +5
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +2
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-e:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@perf_pmu@busy-start-vcs1:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +177
* igt@prime_busy@hang-bsd:
- shard-apl: PASS -> FAIL [fdo#108807]
* igt@testdisplay:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
- shard-snb: DMESG-WARN [fdo#107956] -> PASS +1
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* {igt@kms_plane@plane-position-covered-pipe-c-planes}:
- shard-apl: FAIL [fdo#110038] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
- shard-glk: FAIL [fdo#110037] -> PASS +3
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-y}:
- shard-apl: FAIL [fdo#110037] -> PASS +2
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-yf}:
- shard-kbl: FAIL [fdo#110037] -> PASS
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_rotation_crc@sprite-rotation-180:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4889 -> IGTPW_2660
* Piglit: piglit_4509 -> None
CI_DRM_5772: 16930b29faa6d6fe08f44affe7753c85db95258f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2660: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2660/
IGT_4889: e3faf0fd49b7e3a763bf89e11fb4fdce81839da2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2660/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value
2019-03-19 13:46 [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value Stanislav Lisovskiy
2019-03-19 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-19 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-04-02 13:00 ` Lisovskiy, Stanislav
2019-04-02 13:16 ` Martin Peres
2 siblings, 1 reply; 6+ messages in thread
From: Lisovskiy, Stanislav @ 2019-04-02 13:00 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org; +Cc: Peres, Martin
On Tue, 2019-03-19 at 15:46 +0200, Stanislav Lisovskiy wrote:
> Lot of tests fail, when assertion checking
> how many vblanks should have passed during
> suspend/resume is compared to magic value 150.
>
> At the same time even for failed cases, sometimes
> it is clearly visible that there were no issue -
> simply suspend took longer on that machine.
> If suspend took around 10 s and we get roughly
> 60 vblanks per second the value then should be
> around 600 and not 150.
>
> This change removes 150 magic value and starts
> to use calculation of what it is expected to
> be instead of being hardcoded.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104894
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> tests/kms_vblank.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
Martin, could you please comment, what was I supposed to fix
here, based on our offline discussion, as I seem to have forgotten
this already..
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index dafadb58..80b2a23a 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -338,8 +338,13 @@ static void vblank_ts_cont(data_t *data, int fd,
> int nchildren)
> igt_output_t *output = data->output;
> int seq1, seq2;
> union drm_wait_vblank vbl;
> + struct timespec start, end;
> + int estimated_vblanks = 0;
> + int vrefresh = igt_output_get_mode(output)->vrefresh;
> + double time_elapsed;
>
> seq1 = get_vblank(fd, data->pipe, 0);
> + clock_gettime(CLOCK_MONOTONIC, &start);
>
> if (data->flags & DPMS) {
> igt_output_set_prop_value(output, IGT_CONNECTOR_DPMS,
> DRM_MODE_DPMS_OFF);
> @@ -377,11 +382,17 @@ static void vblank_ts_cont(data_t *data, int
> fd, int nchildren)
> }
>
> seq2 = get_vblank(fd, data->pipe, 0);
> + clock_gettime(CLOCK_MONOTONIC, &end);
> +
> + time_elapsed = igt_time_elapsed(&start, &end);
> + estimated_vblanks = (int)(time_elapsed * vrefresh) + 1;
>
> igt_debug("testing ts continuity: Current frame %u, old frame
> %u\n", seq2, seq1);
>
> - igt_assert_f(seq2 - seq1 >= 0, "unexpected vblank seq %u,
> should be >= %u\n", seq2, seq1);
> - igt_assert_f(seq2 - seq1 <= 150, "unexpected vblank seq %u,
> should be < %u\n", seq2, seq1 + 150);
> + igt_assert_f(seq2 - seq1 >= 0, "elapsed %f(%d vblanks)
> unexpected vblank seq %u, should be >= %u\n", time_elapsed,
> + estimated_vblanks, seq2, seq1);
> + igt_assert_f(seq2 - seq1 <= estimated_vblanks, "elapsed %f(%d
> vblanks) unexpected vblank seq %u, should be < %u\n", time_elapsed,
> + estimated_vblanks, seq2, seq1 +
> estimated_vblanks);
> }
>
> static void run_subtests_for_pipe(data_t *data)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value
2019-04-02 13:00 ` [igt-dev] [PATCH i-g-t] " Lisovskiy, Stanislav
@ 2019-04-02 13:16 ` Martin Peres
2019-04-02 13:45 ` Lisovskiy, Stanislav
0 siblings, 1 reply; 6+ messages in thread
From: Martin Peres @ 2019-04-02 13:16 UTC (permalink / raw)
To: Lisovskiy, Stanislav, igt-dev@lists.freedesktop.org
On 02/04/2019 16:00, Lisovskiy, Stanislav wrote:
> On Tue, 2019-03-19 at 15:46 +0200, Stanislav Lisovskiy wrote:
>> Lot of tests fail, when assertion checking
>> how many vblanks should have passed during
>> suspend/resume is compared to magic value 150.
>>
>> At the same time even for failed cases, sometimes
>> it is clearly visible that there were no issue -
>> simply suspend took longer on that machine.
>> If suspend took around 10 s and we get roughly
>> 60 vblanks per second the value then should be
>> around 600 and not 150.
>>
>> This change removes 150 magic value and starts
>> to use calculation of what it is expected to
>> be instead of being hardcoded.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104894
>> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>> ---
>> tests/kms_vblank.c | 15 +++++++++++++--
>> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> Martin, could you please comment, what was I supposed to fix
> here, based on our offline discussion, as I seem to have forgotten
> this already..
Pretty sure what I was asking was to make a window of acceptable vblank
values, for example [expected-2, expected+2].
The reason why we can't be sure what value this will be is because we
don't know how early vblank gets disabled compared to when the monotonic
counter gets disabled. This is especially true in the presence of
multiple monitors (no idea if we first wait for vblank on all monitors
before suspend or not).
I hope this is what you wanted to hear!
>
>>
>> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
>> index dafadb58..80b2a23a 100644
>> --- a/tests/kms_vblank.c
>> +++ b/tests/kms_vblank.c
>> @@ -338,8 +338,13 @@ static void vblank_ts_cont(data_t *data, int fd,
>> int nchildren)
>> igt_output_t *output = data->output;
>> int seq1, seq2;
>> union drm_wait_vblank vbl;
>> + struct timespec start, end;
>> + int estimated_vblanks = 0;
>> + int vrefresh = igt_output_get_mode(output)->vrefresh;
>> + double time_elapsed;
>>
>> seq1 = get_vblank(fd, data->pipe, 0);
>> + clock_gettime(CLOCK_MONOTONIC, &start);
>>
>> if (data->flags & DPMS) {
>> igt_output_set_prop_value(output, IGT_CONNECTOR_DPMS,
>> DRM_MODE_DPMS_OFF);
>> @@ -377,11 +382,17 @@ static void vblank_ts_cont(data_t *data, int
>> fd, int nchildren)
>> }
>>
>> seq2 = get_vblank(fd, data->pipe, 0);
>> + clock_gettime(CLOCK_MONOTONIC, &end);
>> +
>> + time_elapsed = igt_time_elapsed(&start, &end);
>> + estimated_vblanks = (int)(time_elapsed * vrefresh) + 1;
>>
>> igt_debug("testing ts continuity: Current frame %u, old frame
>> %u\n", seq2, seq1);
>>
>> - igt_assert_f(seq2 - seq1 >= 0, "unexpected vblank seq %u,
>> should be >= %u\n", seq2, seq1);
>> - igt_assert_f(seq2 - seq1 <= 150, "unexpected vblank seq %u,
>> should be < %u\n", seq2, seq1 + 150);
>> + igt_assert_f(seq2 - seq1 >= 0, "elapsed %f(%d vblanks)
>> unexpected vblank seq %u, should be >= %u\n", time_elapsed,
>> + estimated_vblanks, seq2, seq1);
>> + igt_assert_f(seq2 - seq1 <= estimated_vblanks, "elapsed %f(%d
>> vblanks) unexpected vblank seq %u, should be < %u\n", time_elapsed,
>> + estimated_vblanks, seq2, seq1 +
>> estimated_vblanks);
>> }
>>
>> static void run_subtests_for_pipe(data_t *data)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value
2019-04-02 13:16 ` Martin Peres
@ 2019-04-02 13:45 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 6+ messages in thread
From: Lisovskiy, Stanislav @ 2019-04-02 13:45 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org, martin.peres@linux.intel.com
On Tue, 2019-04-02 at 16:16 +0300, Martin Peres wrote:
> On 02/04/2019 16:00, Lisovskiy, Stanislav wrote:
> > On Tue, 2019-03-19 at 15:46 +0200, Stanislav Lisovskiy wrote:
> > > Lot of tests fail, when assertion checking
> > > how many vblanks should have passed during
> > > suspend/resume is compared to magic value 150.
> > >
> > > At the same time even for failed cases, sometimes
> > > it is clearly visible that there were no issue -
> > > simply suspend took longer on that machine.
> > > If suspend took around 10 s and we get roughly
> > > 60 vblanks per second the value then should be
> > > around 600 and not 150.
> > >
> > > This change removes 150 magic value and starts
> > > to use calculation of what it is expected to
> > > be instead of being hardcoded.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104894
> > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com
> > > >
> > > ---
> > > tests/kms_vblank.c | 15 +++++++++++++--
> > > 1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > Martin, could you please comment, what was I supposed to fix
> > here, based on our offline discussion, as I seem to have forgotten
> > this already..
>
> Pretty sure what I was asking was to make a window of acceptable
> vblank
> values, for example [expected-2, expected+2].
>
> The reason why we can't be sure what value this will be is because we
> don't know how early vblank gets disabled compared to when the
> monotonic
> counter gets disabled. This is especially true in the presence of
> multiple monitors (no idea if we first wait for vblank on all
> monitors
> before suspend or not).
>
> I hope this is what you wanted to hear!
Yes, exactly. Thank you, I remember now :)
> >
> > >
> > > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > > index dafadb58..80b2a23a 100644
> > > --- a/tests/kms_vblank.c
> > > +++ b/tests/kms_vblank.c
> > > @@ -338,8 +338,13 @@ static void vblank_ts_cont(data_t *data, int
> > > fd,
> > > int nchildren)
> > > igt_output_t *output = data->output;
> > > int seq1, seq2;
> > > union drm_wait_vblank vbl;
> > > + struct timespec start, end;
> > > + int estimated_vblanks = 0;
> > > + int vrefresh = igt_output_get_mode(output)->vrefresh;
> > > + double time_elapsed;
> > >
> > > seq1 = get_vblank(fd, data->pipe, 0);
> > > + clock_gettime(CLOCK_MONOTONIC, &start);
> > >
> > > if (data->flags & DPMS) {
> > > igt_output_set_prop_value(output, IGT_CONNECTOR_DPMS,
> > > DRM_MODE_DPMS_OFF);
> > > @@ -377,11 +382,17 @@ static void vblank_ts_cont(data_t *data,
> > > int
> > > fd, int nchildren)
> > > }
> > >
> > > seq2 = get_vblank(fd, data->pipe, 0);
> > > + clock_gettime(CLOCK_MONOTONIC, &end);
> > > +
> > > + time_elapsed = igt_time_elapsed(&start, &end);
> > > + estimated_vblanks = (int)(time_elapsed * vrefresh) + 1;
> > >
> > > igt_debug("testing ts continuity: Current frame %u, old frame
> > > %u\n", seq2, seq1);
> > >
> > > - igt_assert_f(seq2 - seq1 >= 0, "unexpected vblank seq %u,
> > > should be >= %u\n", seq2, seq1);
> > > - igt_assert_f(seq2 - seq1 <= 150, "unexpected vblank seq %u,
> > > should be < %u\n", seq2, seq1 + 150);
> > > + igt_assert_f(seq2 - seq1 >= 0, "elapsed %f(%d vblanks)
> > > unexpected vblank seq %u, should be >= %u\n", time_elapsed,
> > > + estimated_vblanks, seq2, seq1);
> > > + igt_assert_f(seq2 - seq1 <= estimated_vblanks, "elapsed %f(%d
> > > vblanks) unexpected vblank seq %u, should be < %u\n",
> > > time_elapsed,
> > > + estimated_vblanks, seq2, seq1 +
> > > estimated_vblanks);
> > > }
> > >
> > > static void run_subtests_for_pipe(data_t *data)
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-02 13:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-19 13:46 [igt-dev] [PATCH i-g-t] igt: tests: kms_vblank: Stop using magic value Stanislav Lisovskiy
2019-03-19 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-19 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-02 13:00 ` [igt-dev] [PATCH i-g-t] " Lisovskiy, Stanislav
2019-04-02 13:16 ` Martin Peres
2019-04-02 13:45 ` Lisovskiy, Stanislav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox