From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v13 6/9] lib/i915: add gem_engine_topology library
Date: Wed, 20 Mar 2019 13:35:05 +0200 [thread overview]
Message-ID: <20190320113505.GD1276@intel.intel> (raw)
In-Reply-To: <155308072730.8718.4999774872884857449@skylake-alporthouse-com>
On Wed, Mar 20, 2019 at 11:18:47AM +0000, Chris Wilson wrote:
> Quoting Andi Shyti (2019-03-20 11:13:16)
> > On Wed, Mar 20, 2019 at 10:59:05AM +0000, Chris Wilson wrote:
> > Another solution would be having the engine_data structure as a
> > global structure that contains all informations and it's
> > allocated outside the for_each. We can have functions inside it
> > like init, get_next, and so on, instead of using it just as a
> > mere leaking iterator.
>
> You can't use a single global, as I need nested iterators.
Sorry, I didn't mean a single global structure, but a "global" in
the sense used by everyone "data structure". tests would
use/allocate/iterate/create/destroy engine_data instead of
intel_execution_engine2.
Anyway, I'll keep it easy for now :)
Cheers,
Andi
> Don't worry about interrupted loops leaking, it's par for the course for
> igt_assert() as we don't have full setup/cleanup (igt_try {} igt_catch
> {} igt_finally {} anyone?).
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-20 11:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 23:44 [igt-dev] [PATCH v13 0/9] new engine discovery interface Andi Shyti
2019-03-19 23:44 ` [igt-dev] [PATCH v13 1/9] lib/igt_gt: remove unnecessary argument Andi Shyti
2019-03-19 23:44 ` [igt-dev] [PATCH v13 2/9] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-03-20 9:14 ` Chris Wilson
2019-03-19 23:44 ` [igt-dev] [PATCH v13 3/9] lib: move gem_context_has_engine from ioctl_wrappers to gem_context Andi Shyti
2019-03-19 23:44 ` [igt-dev] [PATCH v13 4/9] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-03-19 23:44 ` [igt-dev] [PATCH v13 5/9] lib: igt_gt: use flags in intel_execution_engines2 Andi Shyti
2019-03-20 9:48 ` Tvrtko Ursulin
2019-03-19 23:44 ` [igt-dev] [PATCH v13 6/9] lib/i915: add gem_engine_topology library Andi Shyti
2019-03-20 9:47 ` Tvrtko Ursulin
2019-03-20 10:49 ` Andi Shyti
2019-03-20 11:10 ` Tvrtko Ursulin
2019-03-20 11:21 ` Andi Shyti
2019-03-20 9:56 ` Chris Wilson
2019-03-20 10:49 ` Andi Shyti
2019-03-20 10:59 ` Chris Wilson
2019-03-20 11:13 ` Andi Shyti
2019-03-20 11:18 ` Chris Wilson
2019-03-20 11:35 ` Andi Shyti [this message]
2019-03-19 23:44 ` [igt-dev] [PATCH v13 7/9] lib/igt_gt: use for_each_engine_class_instance to loop through active engines Andi Shyti
2019-03-20 10:04 ` Tvrtko Ursulin
2019-03-20 10:09 ` Chris Wilson
2019-03-20 10:33 ` Tvrtko Ursulin
2019-03-20 10:40 ` Chris Wilson
2019-03-19 23:44 ` [igt-dev] [PATCH v13 8/9] tests: perf_pmu: use the flag value embedded in intel_execution_engines2 Andi Shyti
2019-03-19 23:44 ` [igt-dev] [PATCH v13 9/9] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti
2019-03-20 0:13 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-03-20 9:35 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320113505.GD1276@intel.intel \
--to=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox