public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_vrr: fix compilation with Clang
Date: Thu, 21 Mar 2019 09:37:45 +0200	[thread overview]
Message-ID: <20190321073745.14466-1-simon.ser@intel.com> (raw)

Clang fails to compile this file with this error:

    ../tests/kms_vrr.c:203:20: error: suggest braces around
initialization of subobject [-Werror,-Wmissing-braces]
            drmVBlank vbl = { 0 };
                              ^
                              {}

As discussed in [1], using an empty initializer list is the preferred
way to fix this.

[1]: https://lists.freedesktop.org/archives/igt-dev/2019-March/010841.html

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 tests/kms_vrr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index e4703f5f..9801b40a 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -200,7 +200,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 static uint64_t
 wait_for_vblank(data_t *data, enum pipe pipe)
 {
-	drmVBlank vbl = { 0 };
+	drmVBlank vbl = {};
 
 	vbl.request.type = kmstest_get_vbl_flag(pipe);
 	vbl.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT;
-- 
2.21.0

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-21  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  7:37 Simon Ser [this message]
2019-03-21  8:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: fix compilation with Clang Patchwork
2019-03-21 16:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-16 10:27 ` [igt-dev] [PATCH i-g-t] " Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321073745.14466-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox