public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Simon Ser <simon.ser@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_vrr: fix compilation with Clang
Date: Tue, 16 Apr 2019 13:27:51 +0300	[thread overview]
Message-ID: <20190416102751.GL22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190321073745.14466-1-simon.ser@intel.com>

On Thu, Mar 21, 2019 at 09:37:45AM +0200, Simon Ser wrote:
> Clang fails to compile this file with this error:
> 
>     ../tests/kms_vrr.c:203:20: error: suggest braces around
> initialization of subobject [-Werror,-Wmissing-braces]
>             drmVBlank vbl = { 0 };
>                               ^
>                               {}
> 
> As discussed in [1], using an empty initializer list is the preferred
> way to fix this.
> 
> [1]: https://lists.freedesktop.org/archives/igt-dev/2019-March/010841.html
> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>


Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2019-04-16 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  7:37 [igt-dev] [PATCH i-g-t] tests/kms_vrr: fix compilation with Clang Simon Ser
2019-03-21  8:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 16:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-16 10:27 ` Petri Latvala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416102751.GL22949@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=simon.ser@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox