* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
@ 2019-03-21 13:57 Mika Kahola
2019-03-21 15:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mika Kahola @ 2019-03-21 13:57 UTC (permalink / raw)
To: igt-dev
Use minimum of 16x16 size for i915 devices only as other HW's may have different limitations.
The default is 8x8.
Suggested-by: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_plane_scaling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 01f5f7c9..10c852d5 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -149,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
/* create buffer in the range of min and max source side limit.*/
width = height = 8;
- if (is_planar_yuv_format(pixel_format))
+ if (is_i915_device(d->drm_fd) && is_planar_yuv_format(pixel_format))
width = height = 16;
igt_create_color_fb(display->drm_fd, width, height,
pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
2019-03-21 13:57 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices Mika Kahola
@ 2019-03-21 15:04 ` Patchwork
2019-03-21 18:26 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-03-22 6:02 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-03-21 15:04 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
URL : https://patchwork.freedesktop.org/series/58359/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5788 -> IGTPW_2682
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58359/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2682 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +55
* igt@amdgpu/amd_basic@userptr:
- fi-whl-u: NOTRUN -> SKIP [fdo#109271] +17
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: NOTRUN -> DMESG-WARN [fdo#107709]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> DMESG-FAIL [fdo#103182]
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-whl-u: DMESG-WARN [fdo#109513] -> PASS
- fi-skl-6770hq: FAIL [fdo#108511] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513
Participating hosts (41 -> 38)
------------------------------
Additional (3): fi-bsw-kefka fi-byt-clapper fi-snb-2520m
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-ctg-p8600 fi-byt-n2820 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4896 -> IGTPW_2682
CI_DRM_5788: befbe4e0469e0dc93889f470e816eb31498db6ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2682/
IGT_4896: 0f9c061247fb7aba21c9459f19f437927a28f32c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2682/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
2019-03-21 13:57 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices Mika Kahola
2019-03-21 15:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-21 18:26 ` Ville Syrjälä
2019-03-22 7:12 ` Kahola, Mika
2019-03-22 6:02 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2019-03-21 18:26 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
On Thu, Mar 21, 2019 at 03:57:14PM +0200, Mika Kahola wrote:
> Use minimum of 16x16 size for i915 devices only as other HW's may have different limitations.
> The default is 8x8.
I guess the 8x8 is equally arbitrary for other devices. But maybe it's
a good enough default?
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Suggested-by: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_scaling.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 01f5f7c9..10c852d5 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -149,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>
> /* create buffer in the range of min and max source side limit.*/
> width = height = 8;
> - if (is_planar_yuv_format(pixel_format))
> + if (is_i915_device(d->drm_fd) && is_planar_yuv_format(pixel_format))
> width = height = 16;
> igt_create_color_fb(display->drm_fd, width, height,
> pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
2019-03-21 18:26 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
@ 2019-03-22 7:12 ` Kahola, Mika
0 siblings, 0 replies; 5+ messages in thread
From: Kahola, Mika @ 2019-03-22 7:12 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com; +Cc: igt-dev@lists.freedesktop.org
Pushed!
Thanks for the review!
Cheers,
Mika
On Thu, 2019-03-21 at 20:26 +0200, Ville Syrjälä wrote:
> On Thu, Mar 21, 2019 at 03:57:14PM +0200, Mika Kahola wrote:
> > Use minimum of 16x16 size for i915 devices only as other HW's may
> > have different limitations.
> > The default is 8x8.
>
> I guess the 8x8 is equally arbitrary for other devices. But maybe
> it's
> a good enough default?
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> >
> > Suggested-by: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_plane_scaling.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 01f5f7c9..10c852d5 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -149,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> >
> > /* create buffer in the range of min and max source side
> > limit.*/
> > width = height = 8;
> > - if (is_planar_yuv_format(pixel_format))
> > + if (is_i915_device(d->drm_fd) &&
> > is_planar_yuv_format(pixel_format))
> > width = height = 16;
> > igt_create_color_fb(display->drm_fd, width, height,
> > pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> > --
> > 2.17.1
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
2019-03-21 13:57 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices Mika Kahola
2019-03-21 15:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 18:26 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
@ 2019-03-22 6:02 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-03-22 6:02 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices
URL : https://patchwork.freedesktop.org/series/58359/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5788_full -> IGTPW_2682_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58359/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2682_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-snb: PASS -> FAIL [fdo#109661]
* igt@gem_exec_basic@basic-bsd1:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +19
* igt@gem_exec_schedule@fifo-blt:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@gem_softpin@noreloc-s3:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: PASS -> FAIL [fdo#108686]
* igt@kms_busy@basic-flip-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956] +2
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-f:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +11
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-msflip-blt:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +31
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +33
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-e:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +1
- shard-kbl: PASS -> FAIL [fdo#104894] +1
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
- shard-apl: FAIL [fdo#108145] -> PASS
- shard-kbl: FAIL [fdo#108145] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS +1
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: FAIL [fdo#105010] -> PASS
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4896 -> IGTPW_2682
* Piglit: piglit_4509 -> None
CI_DRM_5788: befbe4e0469e0dc93889f470e816eb31498db6ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2682/
IGT_4896: 0f9c061247fb7aba21c9459f19f437927a28f32c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2682/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-22 7:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 13:57 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices Mika Kahola
2019-03-21 15:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 18:26 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-03-22 7:12 ` Kahola, Mika
2019-03-22 6:02 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox