* [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors
@ 2019-03-27 20:08 Ville Syrjala
2019-03-27 21:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ville Syrjala @ 2019-03-27 20:08 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We may not be able to turn on all the planes (eg. due to memory
bandwidth limitations). Let's accept that fact and simply turn
on as many planes as we can.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_rmfb.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
index b1c81cb80b54..a7fcab87233a 100644
--- a/tests/kms_rmfb.c
+++ b/tests/kms_rmfb.c
@@ -58,6 +58,7 @@ test_rmfb(struct rmfb_data *data, igt_output_t *output, enum pipe pipe, bool reo
igt_plane_t *plane;
drmModeCrtc *crtc;
uint64_t cursor_width, cursor_height;
+ int num_active_planes = 0;
igt_output_set_pipe(output, pipe);
@@ -85,8 +86,25 @@ test_rmfb(struct rmfb_data *data, igt_output_t *output, enum pipe pipe, bool reo
} else {
igt_plane_set_fb(plane, &fb);
}
+
+ if (igt_display_try_commit2(&data->display, data->display.is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY)) {
+ /*
+ * Disable any plane that fails (presumably
+ * due to exceeding some hardware limit).
+ */
+ igt_plane_set_fb(plane, NULL);
+ } else {
+ num_active_planes++;
+ }
}
+ /*
+ * Make sure we were able to enable at least one
+ * plane so that we actually test something.
+ */
+ igt_assert_lt(0, num_active_planes);
+
igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
crtc = drmModeGetCrtc(data->drm_fd, output->config.crtc->crtc_id);
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rmfb: Ignore plane configuration errors
2019-03-27 20:08 [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors Ville Syrjala
@ 2019-03-27 21:03 ` Patchwork
2019-03-28 17:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-29 8:53 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-27 21:03 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_rmfb: Ignore plane configuration errors
URL : https://patchwork.freedesktop.org/series/58653/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5829 -> IGTPW_2721
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58653/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2721 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +18
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_uncore:
- fi-skl-gvtdvm: DMESG-FAIL [fdo#110210] -> PASS
- fi-ivb-3770: DMESG-FAIL [fdo#110210] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* IGT: IGT_4909 -> IGTPW_2721
CI_DRM_5829: 32a1e283d330638d2e5de8f89a9ff7c8512b75e8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2721: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2721/
IGT_4909: 7df3eeb4f3360cd2b511c31acc1c52bd7ce6587f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2721/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_rmfb: Ignore plane configuration errors
2019-03-27 20:08 [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors Ville Syrjala
2019-03-27 21:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-28 17:49 ` Patchwork
2019-03-29 8:53 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-28 17:49 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_rmfb: Ignore plane configuration errors
URL : https://patchwork.freedesktop.org/series/58653/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5829_full -> IGTPW_2721_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58653/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2721_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@fifo-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +64
* igt@gem_pwrite@stolen-normal:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +20
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: PASS -> DMESG-WARN [fdo#108686]
* igt@kms_atomic_interruptible@legacy-setmode:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#110222]
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-pageflip-hang-newfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167]
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +4
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: PASS -> DMESG-WARN [fdo#108566]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-glk: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894]
- shard-apl: PASS -> FAIL [fdo#104894] +1
* igt@prime_nv_test@nv_i915_sharing:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +15
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS
- shard-kbl: FAIL [fdo#103167] -> PASS
- shard-apl: FAIL [fdo#103167] -> PASS
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@runner@aborted:
- shard-glk: ( 2 FAIL ) [fdo#109373] / [k.org#202321] -> FAIL [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4909 -> IGTPW_2721
* Piglit: piglit_4509 -> None
CI_DRM_5829: 32a1e283d330638d2e5de8f89a9ff7c8512b75e8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2721: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2721/
IGT_4909: 7df3eeb4f3360cd2b511c31acc1c52bd7ce6587f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2721/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors
2019-03-27 20:08 [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors Ville Syrjala
2019-03-27 21:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-28 17:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-29 8:53 ` Daniel Vetter
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2019-03-29 8:53 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
On Wed, Mar 27, 2019 at 10:08:39PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We may not be able to turn on all the planes (eg. due to memory
> bandwidth limitations). Let's accept that fact and simply turn
> on as many planes as we can.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_rmfb.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
> index b1c81cb80b54..a7fcab87233a 100644
> --- a/tests/kms_rmfb.c
> +++ b/tests/kms_rmfb.c
> @@ -58,6 +58,7 @@ test_rmfb(struct rmfb_data *data, igt_output_t *output, enum pipe pipe, bool reo
> igt_plane_t *plane;
> drmModeCrtc *crtc;
> uint64_t cursor_width, cursor_height;
> + int num_active_planes = 0;
>
> igt_output_set_pipe(output, pipe);
>
> @@ -85,8 +86,25 @@ test_rmfb(struct rmfb_data *data, igt_output_t *output, enum pipe pipe, bool reo
> } else {
> igt_plane_set_fb(plane, &fb);
> }
> +
> + if (igt_display_try_commit2(&data->display, data->display.is_atomic ?
> + COMMIT_ATOMIC : COMMIT_LEGACY)) {
> + /*
> + * Disable any plane that fails (presumably
> + * due to exceeding some hardware limit).
> + */
> + igt_plane_set_fb(plane, NULL);
> + } else {
> + num_active_planes++;
> + }
> }
I guess if we're really unlucky we might not test all that much anymore,
but primary plane should be first so hopefully we're good.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> + /*
> + * Make sure we were able to enable at least one
> + * plane so that we actually test something.
> + */
> + igt_assert_lt(0, num_active_planes);
> +
> igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>
> crtc = drmModeGetCrtc(data->drm_fd, output->config.crtc->crtc_id);
> --
> 2.19.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-29 8:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-27 20:08 [igt-dev] [PATCH i-g-t] tests/kms_rmfb: Ignore plane configuration errors Ville Syrjala
2019-03-27 21:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-28 17:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-29 8:53 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox