public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Only warn for the first sign of a pagefault
@ 2019-03-28 11:49 Chris Wilson
  2019-03-28 12:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2019-03-28 11:49 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

We only need the warning once, not for the several thousand relocations
we try. The current execbuf implementation will set all presumed_offset
to -1 so this loop should quit on the first entry if we hit the
pagefault, but for the sake of completeness check all.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110269
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_exec_big.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index 440136ee8..9da90ead6 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -169,8 +169,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
 	igt_permute_array(gem_reloc, nreloc, xchg_reloc);
 
 	gem_execbuf(fd, &execbuf);
-	for (n = 0; n < nreloc; n++)
-		igt_warn_on(gem_reloc[n].presumed_offset == -1);
+	for (n = 0; n < nreloc; n++) {
+		if (igt_warn_on(gem_reloc[n].presumed_offset == -1))
+			break;
+	}
 
 	if (use_64bit_relocs) {
 		for (n = 0; n < nreloc; n++) {
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-04 11:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-28 11:49 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Only warn for the first sign of a pagefault Chris Wilson
2019-03-28 12:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-03-29 16:33 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-03-29 19:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-04 11:14 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox