[igt-dev] [PATCH i-g-t v2 1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[igt-dev] [PATCH i-g-t v2 1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[José Roberto de Souza]

When the stridechange subtest was introduced f23ea58f1fbb
("kms_frontbuffer_tracking: expand badstride and stridechange")
atomic was not around and change the stride using drmModePageFlip()
was not allowed so it was expected that it would return -EINVAL and
kernel would keep the old framebuffer with the smaller plane that is
know to fit on CFB(if it don't fit the test will skip on the first
full-modeset because "not enough stolen memory" is set).

But after the introduction of atomic the subtest was updated by
f63e070b469d ("kms_frontbuffer_tracking: Fix tests with the new
atomic reality.") to accept a no error return from drmModePageFlip()
but the do_assertions() that follows it was not updated.
As the subtest function comment states, kernel will do fastsets in
this scenario and the allocated CFB could not be enough to keep FBC
enabled over the new framebuffer, so here adding the missing
DONT_ASSERT_FEATURE_STATUS to ignore the FBC state and just test if
CRC match and if kernel do not misbehave.

Other way to solve this issue would be make the kernel do a
full-modeset when CFB is not enough for the new plane so FBC is
disabled with the CRC freeing the actual CFB and then after enable
CRTC again it will try to enable FBC again if it can allocate the
required CFB but by the subtest comment this is not intended.

v2: Assert features when drmModePageFlip() fails aka non-atomic driver(Dhinakaran)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105683
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 89586326..caef6755 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2932,7 +2932,7 @@ static void stridechange_subtest(const struct test_mode *t)
 	 */
 	rc = drmModePageFlip(drm.fd, drm.display.pipes[params->pipe].crtc_id, new_fb->fb_id, 0, NULL);
 	igt_assert(rc == -EINVAL || rc == 0);
-	do_assertions(0);
+	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);
 }
 
 /**
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2 2/2] tests/frontbuffer_tracking: Assert the status of other features on stridechange subtest

[José Roberto de Souza]

As explained in c1edee186d18 ("tests/frontbuffer_tracking: Do not
assert FBC state after a page flip changing stride") after changing
the plane stride there is the possibility that CFB will not be big
enough to keep FBC enabled, that is why do_assertions() is called
with DONT_ASSERT_FEATURE_STATUS but DONT_ASSERT_FEATURE_STATUS is
overkill and will not check the status of the other features like PSR
and DRRS when running combined feature tests and possibly hiding
bugs.

So lets add a new flag that will only not assert FBC.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index caef6755..ee13b138 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1509,6 +1509,7 @@ static void do_flush(const struct test_mode *t)
 
 #define DONT_ASSERT_CRC			(1 << 0)
 #define DONT_ASSERT_FEATURE_STATUS	(1 << 1)
+#define DONT_ASSERT_FBC_STATUS		(1 << 12)
 
 #define FBC_ASSERT_FLAGS		(0xF << 2)
 #define ASSERT_FBC_ENABLED		(1 << 2)
@@ -1539,7 +1540,7 @@ static int adjust_assertion_flags(const struct test_mode *t, int flags)
 			flags |= ASSERT_DRRS_HIGH;
 	}
 
-	if ((t->feature & FEATURE_FBC) == 0)
+	if ((t->feature & FEATURE_FBC) == 0 || (flags & DONT_ASSERT_FBC_STATUS))
 		flags &= ~FBC_ASSERT_FLAGS;
 	if ((t->feature & FEATURE_PSR) == 0)
 		flags &= ~PSR_ASSERT_FLAGS;
@@ -2910,7 +2911,7 @@ static void stridechange_subtest(const struct test_mode *t)
 	fill_fb_region(&params->primary, COLOR_PRIM_BG);
 
 	set_mode_for_params(params);
-	do_assertions(DONT_ASSERT_FEATURE_STATUS);
+	do_assertions(DONT_ASSERT_FBC_STATUS);
 
 	/* Go back to the fb that can have FBC. */
 	params->primary.fb = old_fb;
@@ -2920,7 +2921,7 @@ static void stridechange_subtest(const struct test_mode *t)
 	/* This operation is the same as above, but with the planes API. */
 	params->primary.fb = new_fb;
 	set_prim_plane_for_params(params);
-	do_assertions(DONT_ASSERT_FEATURE_STATUS);
+	do_assertions(DONT_ASSERT_FBC_STATUS);
 
 	params->primary.fb = old_fb;
 	set_prim_plane_for_params(params);
@@ -2932,7 +2933,7 @@ static void stridechange_subtest(const struct test_mode *t)
 	 */
 	rc = drmModePageFlip(drm.fd, drm.display.pipes[params->pipe].crtc_id, new_fb->fb_id, 0, NULL);
 	igt_assert(rc == -EINVAL || rc == 0);
-	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);
+	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
 }
 
 /**
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[Dhinakaran Pandiyan]

On Tue, 2019-04-02 at 13:59 -0700, José Roberto de Souza wrote:
> When the stridechange subtest was introduced f23ea58f1fbb
> ("kms_frontbuffer_tracking: expand badstride and stridechange")
> atomic was not around and change the stride using drmModePageFlip()
> was not allowed so it was expected that it would return -EINVAL and
> kernel would keep the old framebuffer with the smaller plane that is
> know to fit on CFB(if it don't fit the test will skip on the first
> full-modeset because "not enough stolen memory" is set).
> 
> But after the introduction of atomic the subtest was updated by
> f63e070b469d ("kms_frontbuffer_tracking: Fix tests with the new
> atomic reality.") to accept a no error return from drmModePageFlip()
> but the do_assertions() that follows it was not updated.
> As the subtest function comment states, kernel will do fastsets in
> this scenario and the allocated CFB could not be enough to keep FBC
> enabled over the new framebuffer, so here adding the missing
> DONT_ASSERT_FEATURE_STATUS to ignore the FBC state and just test if
> CRC match and if kernel do not misbehave.
> 
> Other way to solve this issue would be make the kernel do a
> full-modeset when CFB is not enough for the new plane so FBC is
> disabled with the CRC freeing the actual CFB and then after enable
> CRTC again it will try to enable FBC again if it can allocate the
> required CFB but by the subtest comment this is not intended.
> 
> v2: Assert features when drmModePageFlip() fails aka non-atomic
> driver(Dhinakaran)
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105683
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index 89586326..caef6755 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2932,7 +2932,7 @@ static void stridechange_subtest(const struct test_mode
> *t)
>  	 */
>  	rc = drmModePageFlip(drm.fd, drm.display.pipes[params->pipe].crtc_id,
> new_fb->fb_id, 0, NULL);
>  	igt_assert(rc == -EINVAL || rc == 0);
> -	do_assertions(0);
> +	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>


>  }
>  
>  /**

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/frontbuffer_tracking: Assert the status of other features on stridechange subtest

[Dhinakaran Pandiyan]

On Tue, 2019-04-02 at 13:59 -0700, José Roberto de Souza wrote:
> As explained in c1edee186d18 ("tests/frontbuffer_tracking: Do not
> assert FBC state after a page flip changing stride") after changing
> the plane stride there is the possibility that CFB will not be big
> enough to keep FBC enabled, that is why do_assertions() is called
> with DONT_ASSERT_FEATURE_STATUS but DONT_ASSERT_FEATURE_STATUS is
> overkill and will not check the status of the other features like PSR
> and DRRS when running combined feature tests and possibly hiding
> bugs.
> 
> So lets add a new flag that will only not assert FBC.

You are adding this flag to be only used in stridechange_subtest(). But, is
stride change even relevant for PSR and DRRS? I didn't think so. While harmless,
I don't see any much value in asserting PSR and DRRS stay enabled.


> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index caef6755..ee13b138 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -1509,6 +1509,7 @@ static void do_flush(const struct test_mode *t)
>  
>  #define DONT_ASSERT_CRC			(1 << 0)
>  #define DONT_ASSERT_FEATURE_STATUS	(1 << 1)
> +#define DONT_ASSERT_FBC_STATUS		(1 << 12)
>  
>  #define FBC_ASSERT_FLAGS		(0xF << 2)
>  #define ASSERT_FBC_ENABLED		(1 << 2)
> @@ -1539,7 +1540,7 @@ static int adjust_assertion_flags(const struct test_mode
> *t, int flags)
>  			flags |= ASSERT_DRRS_HIGH;
>  	}
>  
> -	if ((t->feature & FEATURE_FBC) == 0)
> +	if ((t->feature & FEATURE_FBC) == 0 || (flags & DONT_ASSERT_FBC_STATUS))
>  		flags &= ~FBC_ASSERT_FLAGS;
>  	if ((t->feature & FEATURE_PSR) == 0)
>  		flags &= ~PSR_ASSERT_FLAGS;
> @@ -2910,7 +2911,7 @@ static void stridechange_subtest(const struct test_mode
> *t)
>  	fill_fb_region(&params->primary, COLOR_PRIM_BG);
>  
>  	set_mode_for_params(params);
> -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> +	do_assertions(DONT_ASSERT_FBC_STATUS);
>  
>  	/* Go back to the fb that can have FBC. */
>  	params->primary.fb = old_fb;
> @@ -2920,7 +2921,7 @@ static void stridechange_subtest(const struct test_mode
> *t)
>  	/* This operation is the same as above, but with the planes API. */
>  	params->primary.fb = new_fb;
>  	set_prim_plane_for_params(params);
> -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> +	do_assertions(DONT_ASSERT_FBC_STATUS);
>  
>  	params->primary.fb = old_fb;
>  	set_prim_plane_for_params(params);
> @@ -2932,7 +2933,7 @@ static void stridechange_subtest(const struct test_mode
> *t)
>  	 */
>  	rc = drmModePageFlip(drm.fd, drm.display.pipes[params->pipe].crtc_id,
> new_fb->fb_id, 0, NULL);
>  	igt_assert(rc == -EINVAL || rc == 0);
> -	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);
> +	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
>  }
>  
>  /**

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/frontbuffer_tracking: Assert the status of other features on stridechange subtest

[Souza, Jose]

[-- Attachment #1.1: Type: text/plain, Size: 3824 bytes --]

On Tue, 2019-04-02 at 14:24 -0700, Dhinakaran Pandiyan wrote:
> On Tue, 2019-04-02 at 13:59 -0700, José Roberto de Souza wrote:
> > As explained in c1edee186d18 ("tests/frontbuffer_tracking: Do not
> > assert FBC state after a page flip changing stride") after changing
> > the plane stride there is the possibility that CFB will not be big
> > enough to keep FBC enabled, that is why do_assertions() is called
> > with DONT_ASSERT_FEATURE_STATUS but DONT_ASSERT_FEATURE_STATUS is
> > overkill and will not check the status of the other features like
> > PSR
> > and DRRS when running combined feature tests and possibly hiding
> > bugs.
> > 
> > So lets add a new flag that will only not assert FBC.
> 
> You are adding this flag to be only used in stridechange_subtest().
> But, is
> stride change even relevant for PSR and DRRS? I didn't think so.
> While harmless,
> I don't see any much value in asserting PSR and DRRS stay enabled.

I'm also not aware of any case that would prevent PSR or DRRS to be
enabled but that is why we have the tests, to catch missing details
from spec, regressions and bugs.

Without this change we are not testing the other features states in
this tests:

fbcpsr-stridechange
fbcdrrs-stridechange
fbcpsrdrrs-stridechange

> 
> 
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  tests/kms_frontbuffer_tracking.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index caef6755..ee13b138 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -1509,6 +1509,7 @@ static void do_flush(const struct test_mode
> > *t)
> >  
> >  #define DONT_ASSERT_CRC			(1 << 0)
> >  #define DONT_ASSERT_FEATURE_STATUS	(1 << 1)
> > +#define DONT_ASSERT_FBC_STATUS		(1 << 12)
> >  
> >  #define FBC_ASSERT_FLAGS		(0xF << 2)
> >  #define ASSERT_FBC_ENABLED		(1 << 2)
> > @@ -1539,7 +1540,7 @@ static int adjust_assertion_flags(const
> > struct test_mode
> > *t, int flags)
> >  			flags |= ASSERT_DRRS_HIGH;
> >  	}
> >  
> > -	if ((t->feature & FEATURE_FBC) == 0)
> > +	if ((t->feature & FEATURE_FBC) == 0 || (flags &
> > DONT_ASSERT_FBC_STATUS))
> >  		flags &= ~FBC_ASSERT_FLAGS;
> >  	if ((t->feature & FEATURE_PSR) == 0)
> >  		flags &= ~PSR_ASSERT_FLAGS;
> > @@ -2910,7 +2911,7 @@ static void stridechange_subtest(const struct
> > test_mode
> > *t)
> >  	fill_fb_region(&params->primary, COLOR_PRIM_BG);
> >  
> >  	set_mode_for_params(params);
> > -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> > +	do_assertions(DONT_ASSERT_FBC_STATUS);
> >  
> >  	/* Go back to the fb that can have FBC. */
> >  	params->primary.fb = old_fb;
> > @@ -2920,7 +2921,7 @@ static void stridechange_subtest(const struct
> > test_mode
> > *t)
> >  	/* This operation is the same as above, but with the planes
> > API. */
> >  	params->primary.fb = new_fb;
> >  	set_prim_plane_for_params(params);
> > -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> > +	do_assertions(DONT_ASSERT_FBC_STATUS);
> >  
> >  	params->primary.fb = old_fb;
> >  	set_prim_plane_for_params(params);
> > @@ -2932,7 +2933,7 @@ static void stridechange_subtest(const struct
> > test_mode
> > *t)
> >  	 */
> >  	rc = drmModePageFlip(drm.fd, drm.display.pipes[params-
> > >pipe].crtc_id,
> > new_fb->fb_id, 0, NULL);
> >  	igt_assert(rc == -EINVAL || rc == 0);
> > -	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);
> > +	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
> >  }
> >  
> >  /**

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/frontbuffer_tracking: Assert the status of other features on stridechange subtest

[Dhinakaran Pandiyan]

On Tue, 2019-04-02 at 21:41 +0000, Souza, Jose wrote:
> On Tue, 2019-04-02 at 14:24 -0700, Dhinakaran Pandiyan wrote:
> > On Tue, 2019-04-02 at 13:59 -0700, José Roberto de Souza wrote:
> > > As explained in c1edee186d18 ("tests/frontbuffer_tracking: Do not
> > > assert FBC state after a page flip changing stride") after changing
> > > the plane stride there is the possibility that CFB will not be big
> > > enough to keep FBC enabled, that is why do_assertions() is called
> > > with DONT_ASSERT_FEATURE_STATUS but DONT_ASSERT_FEATURE_STATUS is
> > > overkill and will not check the status of the other features like
> > > PSR
> > > and DRRS when running combined feature tests and possibly hiding
> > > bugs.
> > > 
> > > So lets add a new flag that will only not assert FBC.
> > 
> > You are adding this flag to be only used in stridechange_subtest().
> > But, is
> > stride change even relevant for PSR and DRRS? I didn't think so.
> > While harmless,
> > I don't see any much value in asserting PSR and DRRS stay enabled.
> 
> I'm also not aware of any case that would prevent PSR or DRRS to be
> enabled but that is why we have the tests, to catch missing details
> from spec, regressions and bugs.
> 
It is impossible to test all possible configurations, we can only test the ones
that have potential to cause problems.

The patch does what it says, and I don't see any harm in making this change. So
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

> Without this change we are not testing the other features states in
> this tests:
That's okay IMO, testing PSR and DRRS states isn't the goal for this subtest.
> 
> fbcpsr-stridechange
> fbcdrrs-stridechange
> fbcpsrdrrs-stridechange
> 
> > 
> > 
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  tests/kms_frontbuffer_tracking.c | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/tests/kms_frontbuffer_tracking.c
> > > b/tests/kms_frontbuffer_tracking.c
> > > index caef6755..ee13b138 100644
> > > --- a/tests/kms_frontbuffer_tracking.c
> > > +++ b/tests/kms_frontbuffer_tracking.c
> > > @@ -1509,6 +1509,7 @@ static void do_flush(const struct test_mode
> > > *t)
> > >  
> > >  #define DONT_ASSERT_CRC			(1 << 0)
> > >  #define DONT_ASSERT_FEATURE_STATUS	(1 << 1)
> > > +#define DONT_ASSERT_FBC_STATUS		(1 << 12)
> > >  
> > >  #define FBC_ASSERT_FLAGS		(0xF << 2)
> > >  #define ASSERT_FBC_ENABLED		(1 << 2)
> > > @@ -1539,7 +1540,7 @@ static int adjust_assertion_flags(const
> > > struct test_mode
> > > *t, int flags)
> > >  			flags |= ASSERT_DRRS_HIGH;
> > >  	}
> > >  
> > > -	if ((t->feature & FEATURE_FBC) == 0)
> > > +	if ((t->feature & FEATURE_FBC) == 0 || (flags &
> > > DONT_ASSERT_FBC_STATUS))
> > >  		flags &= ~FBC_ASSERT_FLAGS;
> > >  	if ((t->feature & FEATURE_PSR) == 0)
> > >  		flags &= ~PSR_ASSERT_FLAGS;
> > > @@ -2910,7 +2911,7 @@ static void stridechange_subtest(const struct
> > > test_mode
> > > *t)
> > >  	fill_fb_region(&params->primary, COLOR_PRIM_BG);
> > >  
> > >  	set_mode_for_params(params);
> > > -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> > > +	do_assertions(DONT_ASSERT_FBC_STATUS);
> > >  
> > >  	/* Go back to the fb that can have FBC. */
> > >  	params->primary.fb = old_fb;
> > > @@ -2920,7 +2921,7 @@ static void stridechange_subtest(const struct
> > > test_mode
> > > *t)
> > >  	/* This operation is the same as above, but with the planes
> > > API. */
> > >  	params->primary.fb = new_fb;
> > >  	set_prim_plane_for_params(params);
> > > -	do_assertions(DONT_ASSERT_FEATURE_STATUS);
> > > +	do_assertions(DONT_ASSERT_FBC_STATUS);
> > >  
> > >  	params->primary.fb = old_fb;
> > >  	set_prim_plane_for_params(params);
> > > @@ -2932,7 +2933,7 @@ static void stridechange_subtest(const struct
> > > test_mode
> > > *t)
> > >  	 */
> > >  	rc = drmModePageFlip(drm.fd, drm.display.pipes[params-
> > > > pipe].crtc_id,
> > > 
> > > new_fb->fb_id, 0, NULL);
> > >  	igt_assert(rc == -EINVAL || rc == 0);
> > > -	do_assertions(rc ? 0 : DONT_ASSERT_FEATURE_STATUS);
> > > +	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
> > >  }
> > >  
> > >  /**
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride
URL   : https://patchwork.freedesktop.org/series/58892/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5857 -> IGTPW_2767
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58892/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2767 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-y:           PASS -> FAIL [fdo#103375]

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-icl-y:           PASS -> INCOMPLETE [fdo#107713]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          FAIL [fdo#103375] -> PASS

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     FAIL [fdo#103167] -> PASS

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS +2

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (48 -> 43)
------------------------------

  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4922 -> IGTPW_2767

  CI_DRM_5857: 650af99ea37e684646d7ed0804e10ea1c7d73228 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2767: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/
  IGT_4922: e941e4a29438c7130554492e4daf52afbc99ffdf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2,1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride
URL   : https://patchwork.freedesktop.org/series/58892/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5857_full -> IGTPW_2767_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58892/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2767_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-clear:
    - shard-snb:          PASS -> INCOMPLETE [fdo#105411]

  * igt@i915_suspend@debugfs-reader:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_busy@extended-modeset-hang-newfb-render-c:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#110222]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
    - shard-glk:          NOTRUN -> DMESG-WARN [fdo#110222]

  * igt@kms_cursor_crc@cursor-128x42-sliding:
    - shard-glk:          NOTRUN -> FAIL [fdo#103232] +1

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +1
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_legacy@pipe-b-torture-bo:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107122]

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - shard-hsw:          PASS -> INCOMPLETE [fdo#103540]

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          PASS -> DMESG-WARN [fdo#102365]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
    - shard-glk:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +53

  * igt@kms_frontbuffer_tracking@psr-farfromfence:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +7

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-e:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5

  * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
    - shard-glk:          PASS -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_psr@psr2_primary_render:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +2

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          PASS -> DMESG-FAIL [fdo#105763]

  * igt@kms_setmode@basic:
    - shard-kbl:          PASS -> FAIL [fdo#99912]

  * igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
    - shard-apl:          PASS -> FAIL [fdo#104894]

  
#### Possible fixes ####

  * igt@kms_atomic@plane_invalid_params:
    - shard-snb:          SKIP [fdo#109271] -> PASS +2

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-glk:          INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          DMESG-WARN [fdo#110222] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-kbl:          DMESG-WARN [fdo#110222] -> PASS +1
    - shard-snb:          DMESG-WARN [fdo#110222] -> PASS +3

  * igt@kms_chv_cursor_fail@pipe-b-128x128-left-edge:
    - shard-snb:          SKIP [fdo#109271] / [fdo#109278] -> PASS +1

  * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
    - shard-glk:          FAIL [fdo#103060] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-hsw:          FAIL [fdo#105682] -> PASS

  * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
    - shard-glk:          SKIP [fdo#109271] / [fdo#109278] -> PASS

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  
  [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

    * IGT: IGT_4922 -> IGTPW_2767
    * Piglit: piglit_4509 -> None

  CI_DRM_5857: 650af99ea37e684646d7ed0804e10ea1c7d73228 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2767: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/
  IGT_4922: e941e4a29438c7130554492e4daf52afbc99ffdf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2,1/2] tests/frontbuffer_tracking: Do not assert FBC state after a page flip changing stride

[Souza, Jose]

[-- Attachment #1.1: Type: text/plain, Size: 6372 bytes --]

On Wed, 2019-04-03 at 11:05 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [i-g-t,v2,1/2]
> tests/frontbuffer_tracking: Do not assert FBC state after a page flip
> changing stride
> URL   : https://patchwork.freedesktop.org/series/58892/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5857_full -> IGTPW_2767_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**

Pushed, thanks for the reviews Dhinakaran

> 
>   No regressions found.
> 
>   External URL: 
> https://patchwork.freedesktop.org/api/1.0/series/58892/revisions/1/mbox/
> 
> Known issues
> ------------
> 
>   Here are the changes found in IGTPW_2767_full that come from known
> issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_create@create-clear:
>     - shard-snb:          PASS -> INCOMPLETE [fdo#105411]
> 
>   * igt@i915_suspend@debugfs-reader:
>     - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-render-c:
>     - shard-hsw:          PASS -> DMESG-WARN [fdo#110222]
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>     - shard-glk:          NOTRUN -> DMESG-WARN [fdo#110222]
> 
>   * igt@kms_cursor_crc@cursor-128x42-sliding:
>     - shard-glk:          NOTRUN -> FAIL [fdo#103232] +1
> 
>   * igt@kms_cursor_crc@cursor-256x256-random:
>     - shard-apl:          PASS -> FAIL [fdo#103232] +1
>     - shard-kbl:          PASS -> FAIL [fdo#103232]
> 
>   * igt@kms_cursor_legacy@pipe-b-torture-bo:
>     - shard-kbl:          PASS -> DMESG-WARN [fdo#107122]
> 
>   * igt@kms_flip@basic-flip-vs-wf_vblank:
>     - shard-hsw:          PASS -> INCOMPLETE [fdo#103540]
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-snb:          PASS -> DMESG-WARN [fdo#102365]
> 
>   * igt@kms
> _frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
>     - shard-glk:          PASS -> FAIL [fdo#103167]
> 
>   * igt@kms
> _frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu:
>     - shard-glk:          NOTRUN -> SKIP [fdo#109271] +53
> 
>   * igt@kms_frontbuffer_tracking@psr-farfromfence:
>     - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +7
> 
>   * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-e:
>     - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +5
> 
>   * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
>     - shard-glk:          PASS -> SKIP [fdo#109271] / [fdo#109278]
> 
>   * igt@kms_psr@psr2_primary_render:
>     - shard-apl:          NOTRUN -> SKIP [fdo#109271] +2
> 
>   * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
>     - shard-kbl:          PASS -> DMESG-FAIL [fdo#105763]
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          PASS -> FAIL [fdo#99912]
> 
>   * igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
>     - shard-apl:          PASS -> FAIL [fdo#104894]
> 
>   
> #### Possible fixes ####
> 
>   * igt@kms_atomic@plane_invalid_params:
>     - shard-snb:          SKIP [fdo#109271] -> PASS +2
> 
>   * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
>     - shard-glk:          INCOMPLETE [fdo#103359] / [k.org#198133] ->
> PASS
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-render-b:
>     - shard-hsw:          DMESG-WARN [fdo#110222] -> PASS
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
>     - shard-kbl:          DMESG-WARN [fdo#110222] -> PASS +1
>     - shard-snb:          DMESG-WARN [fdo#110222] -> PASS +3
> 
>   * igt@kms_chv_cursor_fail@pipe-b-128x128-left-edge:
>     - shard-snb:          SKIP [fdo#109271] / [fdo#109278] -> PASS +1
> 
>   * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
>     - shard-glk:          FAIL [fdo#103060] -> PASS
> 
>   * igt@kms_frontbuffer_tracking@fbc-stridechange:
>     - shard-hsw:          FAIL [fdo#105682] -> PASS
> 
>   * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
>     - shard-glk:          SKIP [fdo#109271] / [fdo#109278] -> PASS
> 
>   * igt@kms_rotation_crc@multiplane-rotation:
>     - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          FAIL [fdo#99912] -> PASS
> 
>   
>   [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
>   [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
>   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (10 -> 5)
> ------------------------------
> 
>   Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb
> pig-skl-6260u 
> 
> 
> Build changes
> -------------
> 
>     * IGT: IGT_4922 -> IGTPW_2767
>     * Piglit: piglit_4509 -> None
> 
>   CI_DRM_5857: 650af99ea37e684646d7ed0804e10ea1c7d73228 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGTPW_2767: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/
>   IGT_4922: e941e4a29438c7130554492e4daf52afbc99ffdf @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2767/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev