* [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test
@ 2019-04-03 12:20 Uma Shankar
2019-04-03 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Uma Shankar @ 2019-04-03 12:20 UTC (permalink / raw)
To: igt-dev; +Cc: ville.syrjala, daniel, maarten.lankhorst
Due to Gamma/Degamma limitation wrt representation of intermediate
values between 0 and 1.0 causing rounding issues and inaccuracies,
applying linear gamma affects crc. This patch fixes the same by
making ctm max test independent of gamma/degamma.
v2: Disable degamma/gamma programming for ctm max test as it
leads to crc mimsmatch. Limiting it to this test case alone as
other tests need it to be enabled, hence not touching those
scenarios.
v3: Fixed a fumble with compilation.
v4: Disabling degamma and gamma for ctm max tests, after the logic
in kernel has been updated by Ville's series.
v5: Disabled gamma/degamma for all ctm tests as suggested by Ville.
v6: Restricting disabling of linear gamma luts for ctm max test.
Updated the commit message and comment as suggested by Daniel.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
tests/kms_color.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..3aac7fb 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -696,8 +696,20 @@ static bool test_pipe_ctm(data_t *data,
igt_assert(fb_modeset_id);
igt_plane_set_fb(primary, &fb_modeset);
- set_degamma(data, primary->pipe, degamma_linear);
- set_gamma(data, primary->pipe, gamma_linear);
+ /*
+ * Don't program LUT's for max CTM cases, as limitation of
+ * representing intermediate values between 0 and 1.0 causes
+ * rounding issues and inaccuracies leading to crc mismatch.
+ */
+ if (memcmp(before, after, sizeof(color_t))) {
+ set_degamma(data, primary->pipe, degamma_linear);
+ set_gamma(data, primary->pipe, gamma_linear);
+ } else {
+ /* Disable Degamma and Gamma for ctm max test */
+ disable_degamma(primary->pipe);
+ disable_gamma(primary->pipe);
+ }
+
disable_ctm(primary->pipe);
igt_display_commit(&data->display);
--
1.9.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9)
2019-04-03 12:20 [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
@ 2019-04-03 12:24 ` Patchwork
2019-04-03 13:44 ` [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Daniel Vetter
2019-04-04 3:11 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-03 12:24 UTC (permalink / raw)
To: Shankar, Uma; +Cc: igt-dev
== Series Details ==
Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev9)
URL : https://patchwork.freedesktop.org/series/58412/
State : success
== Summary ==
CI Bug Log - changes from IGT_4924 -> IGTPW_2772
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/9/mbox/
Known issues
------------
Here are the changes found in IGTPW_2772 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
* igt@i915_module_load@reload:
- fi-icl-y: PASS -> INCOMPLETE [fdo#107713]
* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-y: DMESG-WARN [fdo#109638] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (45 -> 42)
------------------------------
Additional (2): fi-icl-dsi fi-icl-u3
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4924 -> IGTPW_2772
CI_DRM_5862: c97de10a1caf7b856efe273c901fceea3fc78367 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2772/
IGT_4924: bcf2f21996b2ee5c6177f5412046690ff8017772 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2772/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test
2019-04-03 12:20 [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-04-03 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
@ 2019-04-03 13:44 ` Daniel Vetter
2019-04-04 3:11 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2019-04-03 13:44 UTC (permalink / raw)
To: Uma Shankar; +Cc: igt-dev, ville.syrjala, daniel, maarten.lankhorst
On Wed, Apr 03, 2019 at 05:50:10PM +0530, Uma Shankar wrote:
> Due to Gamma/Degamma limitation wrt representation of intermediate
> values between 0 and 1.0 causing rounding issues and inaccuracies,
> applying linear gamma affects crc. This patch fixes the same by
> making ctm max test independent of gamma/degamma.
>
> v2: Disable degamma/gamma programming for ctm max test as it
> leads to crc mimsmatch. Limiting it to this test case alone as
> other tests need it to be enabled, hence not touching those
> scenarios.
>
> v3: Fixed a fumble with compilation.
>
> v4: Disabling degamma and gamma for ctm max tests, after the logic
> in kernel has been updated by Ville's series.
>
> v5: Disabled gamma/degamma for all ctm tests as suggested by Ville.
>
> v6: Restricting disabling of linear gamma luts for ctm max test.
> Updated the commit message and comment as suggested by Daniel.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/kms_color.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index decf3c2..3aac7fb 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -696,8 +696,20 @@ static bool test_pipe_ctm(data_t *data,
> igt_assert(fb_modeset_id);
> igt_plane_set_fb(primary, &fb_modeset);
>
> - set_degamma(data, primary->pipe, degamma_linear);
> - set_gamma(data, primary->pipe, gamma_linear);
> + /*
> + * Don't program LUT's for max CTM cases, as limitation of
> + * representing intermediate values between 0 and 1.0 causes
> + * rounding issues and inaccuracies leading to crc mismatch.
> + */
> + if (memcmp(before, after, sizeof(color_t))) {
> + set_degamma(data, primary->pipe, degamma_linear);
> + set_gamma(data, primary->pipe, gamma_linear);
> + } else {
> + /* Disable Degamma and Gamma for ctm max test */
> + disable_degamma(primary->pipe);
> + disable_gamma(primary->pipe);
> + }
> +
> disable_ctm(primary->pipe);
> igt_display_commit(&data->display);
>
> --
> 1.9.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9)
2019-04-03 12:20 [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-04-03 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
2019-04-03 13:44 ` [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Daniel Vetter
@ 2019-04-04 3:11 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-04 3:11 UTC (permalink / raw)
To: Shankar, Uma; +Cc: igt-dev
== Series Details ==
Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev9)
URL : https://patchwork.freedesktop.org/series/58412/
State : success
== Summary ==
CI Bug Log - changes from IGT_4924_full -> IGTPW_2772_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/9/mbox/
Known issues
------------
Here are the changes found in IGTPW_2772_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_exec_schedule@wide-bsd:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +32
* igt@gem_wait@write-busy-bsd2:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +24
* igt@kms_atomic_transition@3x-modeset-transitions-fencing:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@basic-flip-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +7
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222] +1
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#110222]
- shard-apl: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#110222] +1
* igt@kms_busy@extended-pageflip-hang-newfb-render-b:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222] +1
* igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +2
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> SKIP [fdo#109271]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-glk: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@prime_nv_api@i915_nv_double_export:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +57
#### Possible fixes ####
* igt@gem_exec_flush@basic-wb-pro-default:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@i915_suspend@forcewake:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_color@pipe-c-ctm-max:
- shard-glk: FAIL [fdo#108147] -> PASS +2
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: FAIL [fdo#104894] -> PASS +1
- shard-apl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: DMESG-WARN [fdo#108686] -> INCOMPLETE [fdo#103540]
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4924 -> IGTPW_2772
CI_DRM_5862: c97de10a1caf7b856efe273c901fceea3fc78367 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2772/
IGT_4924: bcf2f21996b2ee5c6177f5412046690ff8017772 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2772/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-04 3:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03 12:20 [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-04-03 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
2019-04-03 13:44 ` [igt-dev] [v6] tests/kms_color: Fix CRC mismatch issues with ctm test Daniel Vetter
2019-04-04 3:11 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev9) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox