public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Check supported format for rotation
@ 2019-04-04 10:37 Mika Kahola
  2019-04-04 12:57 ` Daniel Vetter
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Mika Kahola @ 2019-04-04 10:37 UTC (permalink / raw)
  To: igt-dev

Let's align with kernel and add checks for formats that are
not allowed to do 90/270 rotation.

In dmesg we see for example, the following

"[drm:skl_plane_check [i915]] Unsupported pixel format Y210
little-endian (0x30313259) for 90/270!"

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_plane_scaling.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3364073c..2d47c14b 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -176,9 +176,25 @@ static const igt_rotation_t rotations[] = {
 
 static bool can_rotate(data_t *d, unsigned format)
 {
-	if (format == DRM_FORMAT_C8 ||
-	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
+	switch (format) {
+	case DRM_FORMAT_RGB565:
+		if (intel_gen(d->devid) >= 11)
+			break;
+	/* fall through */
+	case DRM_FORMAT_C8:
+	case DRM_FORMAT_XRGB16161616F:
+	case DRM_FORMAT_XBGR16161616F:
+	case DRM_FORMAT_ARGB16161616F:
+	case DRM_FORMAT_ABGR16161616F:
+	case DRM_FORMAT_Y210:
+	case DRM_FORMAT_Y212:
+	case DRM_FORMAT_Y216:
+	case DRM_FORMAT_XVYU12_16161616:
+	case DRM_FORMAT_XVYU16161616:
 		return false;
+	default:
+		break;
+	}
 
 	return true;
 }
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-04-06  5:37 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 10:37 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Check supported format for rotation Mika Kahola
2019-04-04 12:57 ` Daniel Vetter
2019-04-04 13:20   ` Kahola, Mika
2019-04-04 13:57     ` Ville Syrjälä
2019-04-04 13:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05  3:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-04-05 11:20 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Check supported format for rotation (rev2) Patchwork
2019-04-06  5:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox