public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Run only on the first valid output
@ 2019-04-09 13:48 Arkadiusz Hiler
  2019-04-09 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-04-09 13:48 UTC (permalink / raw)
  To: igt-dev

There is no real need for testing on each output, as they do not affect
CRC coming out from the pipe. Let's use first viable one.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/kms_plane_multiple.c | 26 +++++---------------------
 1 file changed, 5 insertions(+), 21 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index bfaeeded..d2d02a5f 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -302,41 +302,25 @@ static void
 test_plane_position(data_t *data, enum pipe pipe, uint64_t tiling)
 {
 	igt_output_t *output;
-	int connected_outs;
 	int n_planes = data->display.pipes[pipe].n_planes;
 
+	output = igt_get_single_output_for_pipe(&data->display, pipe);
+	igt_require(output);
+
 	if (!opt.user_seed)
 		opt.seed = time(NULL);
 
 	srand(opt.seed);
 
-	connected_outs = 0;
-	for_each_valid_output_on_pipe(&data->display, pipe, output) {
-		test_plane_position_with_output(data, pipe,
-						output,
-						n_planes,
-						tiling);
-		connected_outs++;
-	}
-
-	igt_skip_on(connected_outs == 0);
-
+	test_plane_position_with_output(data, pipe, output,
+					n_planes, tiling);
 }
 
 static void
 run_tests_for_pipe(data_t *data, enum pipe pipe)
 {
-	igt_output_t *output;
-
 	igt_fixture {
-		int valid_tests = 0;
-
 		igt_skip_on(pipe >= data->display.n_pipes);
-
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
-			valid_tests++;
-
-		igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
 		igt_require(data->display.pipes[pipe].n_planes > 0);
 	}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-10 12:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 13:48 [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Run only on the first valid output Arkadiusz Hiler
2019-04-09 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-09 15:08 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-04-09 23:48 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-04-10 12:37 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox