public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lyude <lyude@redhat.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: [igt-dev] [PATCH i-g-t v3 5/9] meson: Add .so versioning
Date: Wed, 24 Apr 2019 16:20:29 -0400	[thread overview]
Message-ID: <20190424202033.7601-6-lyude@redhat.com> (raw)
In-Reply-To: <20190424202033.7601-1-lyude@redhat.com>

From: Lyude Paul <lyude@redhat.com>

While I'm pretty confident that no one cares to use libigt.so or
lib_aubdump.so anywhere outside of igt, many distributions including
Fedora and Debian strongly suggest that packages have some sort of so
versioning, even if it's just '0'. So, let's fulfill that minimum
requirement to make this easier to package.

[note: still waiting on some more feedback regarding this change before
I push it, another respin may or may not be imminent]

Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 lib/meson.build   | 3 ++-
 tools/meson.build | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/meson.build b/lib/meson.build
index 97f701c7..11ad3b1f 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -134,7 +134,8 @@ lib_igt_build = shared_library('igt',
     ['dummy.c'],
     link_whole: lib_intermediates,
     dependencies: lib_deps,
-    install : true
+    install : true,
+    soversion : '0',
 )
 
 lib_igt = declare_dependency(link_with : lib_igt_build,
diff --git a/tools/meson.build b/tools/meson.build
index 5d00f2e3..dfaed82a 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -93,7 +93,8 @@ install_subdir('registers', install_dir : datadir,
 shared_library('intel_aubdump', 'aubdump.c',
 	       dependencies : [ lib_igt_chipset, dlsym ],
 	       name_prefix : '',
-	       install : true)
+	       install : true,
+	       soversion : '0')
 
 executable('intel_gpu_top', 'intel_gpu_top.c',
 	   install : true,
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-04-24 20:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 20:20 [igt-dev] [PATCH i-g-t v3 0/9] Fixes from updating igt packaging in Fedora Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/tests: Fix test failures with meson 0.50.0 Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 2/9] Use gettid() wrapper everywhere Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/aux: Typecast gettid() as pid_t Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 4/9] meson: Don't redefine gettid if the C library provides it Lyude
2019-04-24 20:20 ` Lyude [this message]
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 6/9] meson: Don't allow building with NDEBUG, ever Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 7/9] lib/igt_core: Just use igt_can_fail() in __igt_run_subtest() Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 8/9] Use pkgconfig() macros with dnf in Fedora Dockerfile Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 9/9] Update Dockerfile.fedora to Fedora 29 Lyude
2019-04-24 21:14 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes from updating igt packaging in Fedora (rev2) Patchwork
2019-04-25 10:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424202033.7601-6-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox