public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lyude <lyude@redhat.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: [igt-dev] [PATCH i-g-t v3 7/9] lib/igt_core: Just use igt_can_fail() in __igt_run_subtest()
Date: Wed, 24 Apr 2019 16:20:31 -0400	[thread overview]
Message-ID: <20190424202033.7601-8-lyude@redhat.com> (raw)
In-Reply-To: <20190424202033.7601-1-lyude@redhat.com>

From: Lyude Paul <lyude@redhat.com>

That's what it's there for.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 lib/igt_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 43fa197f..d5d4fce2 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -903,9 +903,7 @@ bool __igt_run_subtest(const char *subtest_name)
 {
 	int i;
 
-	assert(!in_subtest);
-	assert(!in_fixture);
-	assert(test_with_subtests);
+	assert(!igt_can_fail());
 
 	/* check the subtest name only contains a-z, A-Z, 0-9, '-' and '_' */
 	for (i = 0; subtest_name[i] != '\0'; i++)
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-04-24 20:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 20:20 [igt-dev] [PATCH i-g-t v3 0/9] Fixes from updating igt packaging in Fedora Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/tests: Fix test failures with meson 0.50.0 Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 2/9] Use gettid() wrapper everywhere Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/aux: Typecast gettid() as pid_t Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 4/9] meson: Don't redefine gettid if the C library provides it Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 5/9] meson: Add .so versioning Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 6/9] meson: Don't allow building with NDEBUG, ever Lyude
2019-04-24 20:20 ` Lyude [this message]
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 8/9] Use pkgconfig() macros with dnf in Fedora Dockerfile Lyude
2019-04-24 20:20 ` [igt-dev] [PATCH i-g-t v3 9/9] Update Dockerfile.fedora to Fedora 29 Lyude
2019-04-24 21:14 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes from updating igt packaging in Fedora (rev2) Patchwork
2019-04-25 10:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424202033.7601-8-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox