[igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown

[igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown

[Chris Wilson]

If we can't match the devid to a chipset, we do not have a reference for
the tiling strides. Instead of randomly failing, skip with a
semi-informative message.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110523
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_tiling_max_stride.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tests/i915/gem_tiling_max_stride.c b/tests/i915/gem_tiling_max_stride.c
index a6f97a915..0e99d979f 100644
--- a/tests/i915/gem_tiling_max_stride.c
+++ b/tests/i915/gem_tiling_max_stride.c
@@ -72,16 +72,18 @@ igt_simple_main
 
 	devid = intel_get_drm_devid(fd);
 
-	if (intel_gen(devid) >= 7)
+	if (intel_gen(devid) >= 7) {
 		stride = 256 * 1024;
-	else if (intel_gen(devid) >= 4)
+	} else if (intel_gen(devid) >= 4) {
 		stride = 128 * 1024;
-	else {
-		if (IS_GEN2(devid)) {
-			tile_width = 128;
-			tile_height = 16;
-		}
+	} else if (intel_gen(devid) >= 3) {
+		stride = 8 * 1024;
+	} else if (intel_gen(devid) >= 2) {
+		tile_width = 128;
+		tile_height = 16;
 		stride = 8 * 1024;
+	} else {
+		igt_skip("Unknown Intel chipset, devid=%04x\n", devid);
 	}
 
 	size = stride * tile_height;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_tiling_max_stride: Skip if chipset is unknown

[Patchwork]

== Series Details ==

Series: i915/gem_tiling_max_stride: Skip if chipset is unknown
URL   : https://patchwork.freedesktop.org/series/59978/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6002 -> IGTPW_2924
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59978/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2924 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  
#### Possible fixes ####

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       [SKIP][3] ([fdo#109271] / [fdo#109278]) -> [PASS][4] +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 


Participating hosts (36 -> 41)
------------------------------

  Additional (9): fi-bxt-dsi fi-icl-u2 fi-snb-2520m fi-byt-clapper fi-kbl-x1275 fi-icl-u3 fi-icl-y fi-bsw-kefka fi-skl-6700k2 
  Missing    (4): fi-kbl-soraka fi-ctg-p8600 fi-ilk-m540 fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2924

  CI_DRM_6002: 8e38b2c2f198640d840047e426ac009b59977633 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2924: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for i915/gem_tiling_max_stride: Skip if chipset is unknown

[Patchwork]

== Series Details ==

Series: i915/gem_tiling_max_stride: Skip if chipset is unknown
URL   : https://patchwork.freedesktop.org/series/59978/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6002_full -> IGTPW_2924_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59978/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2924_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [PASS][1] -> [DMESG-WARN][2] ([fdo#109982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb8/igt@i915_pm_rpm@i2c.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb2/igt@i915_pm_rpm@i2c.html

  * igt@i915_pm_rpm@legacy-planes:
    - shard-iclb:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108840] / [fdo#109960])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb7/igt@i915_pm_rpm@legacy-planes.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb4/igt@i915_pm_rpm@legacy-planes.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-kbl:          [PASS][5] -> [INCOMPLETE][6] ([fdo#103665] / [fdo#107807])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-kbl1/igt@i915_pm_rpm@system-suspend-modeset.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-kbl5/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl5/igt@i915_suspend@fence-restore-tiled2untiled.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_atomic_transition@2x-modeset-transitions-nonblocking:
    - shard-hsw:          [PASS][9] -> [SKIP][10] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-hsw8/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking.html

  * igt@kms_cursor_crc@cursor-64x21-sliding:
    - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl5/igt@kms_cursor_crc@cursor-64x21-sliding.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl5/igt@kms_cursor_crc@cursor-64x21-sliding.html
    - shard-kbl:          [PASS][13] -> [FAIL][14] ([fdo#103232])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-kbl7/igt@kms_cursor_crc@cursor-64x21-sliding.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-kbl6/igt@kms_cursor_crc@cursor-64x21-sliding.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103167])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
    - shard-glk:          [PASS][17] -> [SKIP][18] ([fdo#109271] / [fdo#109278])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-glk9/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-glk6/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#109441])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb2/igt@kms_psr@psr2_basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb6/igt@kms_psr@psr2_basic.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          [PASS][21] -> [DMESG-FAIL][22] ([fdo#105763])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-kbl6/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][23] -> [FAIL][24] ([fdo#99912])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl7/igt@kms_setmode@basic.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl7/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [INCOMPLETE][25] ([fdo#103665]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-kbl5/igt@gem_ctx_isolation@rcs0-s3.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl6/igt@gem_eio@in-flight-suspend.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl5/igt@gem_eio@in-flight-suspend.html

  * igt@gem_mmap_gtt@big-copy:
    - shard-glk:          [INCOMPLETE][29] ([fdo#103359] / [k.org#198133]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-glk8/igt@gem_mmap_gtt@big-copy.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-glk2/igt@gem_mmap_gtt@big-copy.html

  * igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
    - shard-apl:          [INCOMPLETE][31] ([fdo#103927]) -> [PASS][32] +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [FAIL][33] ([fdo#103167]) -> [PASS][34] +3 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
    - shard-apl:          [INCOMPLETE][37] ([fdo#103927]) -> [SKIP][38] ([fdo#109271])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6002/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/shard-apl2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960
  [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (9 -> 6)
------------------------------

  Missing    (3): shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2924
  * Piglit: piglit_4509 -> None

  CI_DRM_6002: 8e38b2c2f198640d840047e426ac009b59977633 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2924: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2924/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_tiling_max_stride: Skip if chipset is unknown

[Ville Syrjälä]

On Fri, Apr 26, 2019 at 08:56:45AM +0100, Chris Wilson wrote:
> If we can't match the devid to a chipset, we do not have a reference for
> the tiling strides. Instead of randomly failing, skip with a
> semi-informative message.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110523
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/i915/gem_tiling_max_stride.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_tiling_max_stride.c b/tests/i915/gem_tiling_max_stride.c
> index a6f97a915..0e99d979f 100644
> --- a/tests/i915/gem_tiling_max_stride.c
> +++ b/tests/i915/gem_tiling_max_stride.c
> @@ -72,16 +72,18 @@ igt_simple_main
>  
>  	devid = intel_get_drm_devid(fd);
>  
> -	if (intel_gen(devid) >= 7)
> +	if (intel_gen(devid) >= 7) {
>  		stride = 256 * 1024;
> -	else if (intel_gen(devid) >= 4)
> +	} else if (intel_gen(devid) >= 4) {
>  		stride = 128 * 1024;
> -	else {
> -		if (IS_GEN2(devid)) {
> -			tile_width = 128;
> -			tile_height = 16;
> -		}
> +	} else if (intel_gen(devid) >= 3) {
> +		stride = 8 * 1024;
> +	} else if (intel_gen(devid) >= 2) {
> +		tile_width = 128;
> +		tile_height = 16;
>  		stride = 8 * 1024;
> +	} else {
> +		igt_skip("Unknown Intel chipset, devid=%04x\n", devid);
>  	}
>  
>  	size = stride * tile_height;
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev