public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/audio: Fix compiler error with missing permsisions to O_CREAT.
@ 2019-04-29  9:24 Maarten Lankhorst
  2019-04-29  9:50 ` Ser, Simon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2019-04-29  9:24 UTC (permalink / raw)
  To: igt-dev

In file included from /usr/include/fcntl.h:290:0,
                 from ../../lib/igt_audio.c:30:
In function ‘open’,
    inlined from ‘audio_create_wav_file_s32_le’ at igt_audio.c:450:5:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to
	‘__open_missing_mode’ declared with attribute error: open with
	O_CREAT or O_TMPFILE in second argument needs 3 arguments
    __open_missing_mode ();
    ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Simon Ser <simon.ser@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
---
 lib/igt_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_audio.c b/lib/igt_audio.c
index 5b0860e6cc76..fd8cf07c0de3 100644
--- a/lib/igt_audio.c
+++ b/lib/igt_audio.c
@@ -447,7 +447,7 @@ int audio_create_wav_file_s32_le(const char *qualifier, uint32_t sample_rate,
 		*path = strdup(_path);
 
 	igt_debug("Dumping %s audio to %s\n", qualifier, _path);
-	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC);
+	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
 	if (fd < 0) {
 		igt_warn("open failed: %s\n", strerror(errno));
 		return -1;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-29 12:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-29  9:24 [igt-dev] [PATCH i-g-t] lib/audio: Fix compiler error with missing permsisions to O_CREAT Maarten Lankhorst
2019-04-29  9:50 ` Ser, Simon
2019-04-29 10:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-29 12:18 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox