public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/4] lib/igt_kms: Update cursor when fb width/height changes too.
Date: Mon, 29 Apr 2019 18:05:56 +0200	[thread overview]
Message-ID: <20190429160557.17889-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20190429160557.17889-1-maarten.lankhorst@linux.intel.com>

Call SetCursor on w/h size change as well, this fixes a test
failure when using kms calls to change cursor size.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 lib/igt_kms.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4eb432917307..1b3483439474 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2749,7 +2749,9 @@ static int igt_cursor_commit_legacy(igt_plane_t *cursor,
 	uint32_t crtc_id = pipe->crtc_id;
 	int ret;
 
-	if (igt_plane_is_prop_changed(cursor, IGT_PLANE_FB_ID)) {
+	if (igt_plane_is_prop_changed(cursor, IGT_PLANE_FB_ID) ||
+	    igt_plane_is_prop_changed(cursor, IGT_PLANE_CRTC_W) ||
+	    igt_plane_is_prop_changed(cursor, IGT_PLANE_CRTC_H)) {
 		if (cursor->gem_handle)
 			LOG(display,
 			    "SetCursor pipe %s, fb %u %dx%d\n",
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-04-29 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 16:05 [igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_cursor_crc: Run tests once per pipe Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_cursor_crc: Handle display cleanup in init Maarten Lankhorst
2019-04-29 16:05 ` Maarten Lankhorst [this message]
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_cursor_crc: Use igt_kms calls for everything Maarten Lankhorst
2019-04-29 16:57 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_cursor_crc test improvements and cleanups Patchwork
2019-04-29 22:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-11 15:17 ` [igt-dev] [PATCH i-g-t 0/4] " Juha-Pekka Heikkilä
2019-05-13 15:07   ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190429160557.17889-4-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox