From: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups.
Date: Sat, 11 May 2019 18:17:29 +0300 [thread overview]
Message-ID: <8f2230b4-c3b7-7ad5-dd05-fb7c3a9798e6@gmail.com> (raw)
In-Reply-To: <20190429160557.17889-1-maarten.lankhorst@linux.intel.com>
This set look all good to me, I didn't notice anything I'd comment about
other than:
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Maarten Lankhorst kirjoitti 29.4.2019 klo 19.05:
> The tests were running on each output on each pipe, and did some cleanup
> that should be done in igt_display_reset(). Fix the test to use igt_kms
> calls all the time, and remove all hand-rolled cleanup.
>
> As a bonus, we can now run the same test on an overlay plane with a
> s/CURSOR/OVERLAY/ as a sanity check that the test themselves are correct.
>
> Maarten Lankhorst (4):
> tests/kms_cursor_crc: Run tests once per pipe
> tests/kms_cursor_crc: Handle display cleanup in init
> lib/igt_kms: Update cursor when fb width/height changes too.
> tests/kms_cursor_crc: Use igt_kms calls for everything.
>
> lib/igt_kms.c | 4 +-
> tests/kms_cursor_crc.c | 238 +++++++++++++++++++----------------------
> 2 files changed, 114 insertions(+), 128 deletions(-)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-11 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 16:05 [igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_cursor_crc: Run tests once per pipe Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_cursor_crc: Handle display cleanup in init Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_kms: Update cursor when fb width/height changes too Maarten Lankhorst
2019-04-29 16:05 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_cursor_crc: Use igt_kms calls for everything Maarten Lankhorst
2019-04-29 16:57 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_cursor_crc test improvements and cleanups Patchwork
2019-04-29 22:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-11 15:17 ` Juha-Pekka Heikkilä [this message]
2019-05-13 15:07 ` [igt-dev] [PATCH i-g-t 0/4] " Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2230b4-c3b7-7ad5-dd05-fb7c3a9798e6@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox