public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: [igt-dev] [PATCH v23 13/14] test/i915: gem_wait: use the gem_engine_topology library
Date: Mon, 13 May 2019 03:45:07 +0300	[thread overview]
Message-ID: <20190513004508.8042-14-andi@etezian.org> (raw)
In-Reply-To: <20190513004508.8042-1-andi@etezian.org>

From: Andi Shyti <andi.shyti@intel.com>

Replace the legacy for_each_engine* defines with the ones
implemented in the gem_engine_topology library.

Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_wait.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
index ee2ecfa0d056..b5e32219d77b 100644
--- a/tests/i915/gem_wait.c
+++ b/tests/i915/gem_wait.c
@@ -134,7 +134,7 @@ static void basic(int fd, unsigned engine, unsigned flags)
 
 igt_main
 {
-	const struct intel_execution_engine *e;
+	const struct intel_execution_engine2 *e;
 	int fd = -1;
 
 	igt_skip_on_simulation();
@@ -177,27 +177,27 @@ igt_main
 			basic(fd, ALL_ENGINES, WRITE);
 		}
 
-		for (e = intel_execution_engines; e->name; e++) {
+		__for_each_physical_engine(fd, e) {
 			igt_subtest_group {
 				igt_subtest_f("busy-%s", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e->exec_id | e->flags, BUSY);
+					basic(fd, e->flags, BUSY);
 				}
 				igt_subtest_f("wait-%s", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e->exec_id | e->flags, 0);
+					basic(fd, e->flags, 0);
 				}
 				igt_subtest_f("await-%s", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e->exec_id | e->flags, AWAIT);
+					basic(fd, e->flags, AWAIT);
 				}
 				igt_subtest_f("write-busy-%s", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e->exec_id | e->flags, BUSY | WRITE);
+					basic(fd, e->flags, BUSY | WRITE);
 				}
 				igt_subtest_f("write-wait-%s", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e->exec_id | e->flags, WRITE);
+					basic(fd, e->flags, WRITE);
 				}
 			}
 		}
@@ -234,22 +234,22 @@ igt_main
 			basic(fd, ALL_ENGINES, WRITE | HANG);
 		}
 
-		for (e = intel_execution_engines; e->name; e++) {
+		__for_each_physical_engine(fd, e) {
 			igt_subtest_f("hang-busy-%s", e->name) {
 				gem_quiescent_gpu(fd);
-				basic(fd, e->exec_id | e->flags, HANG | BUSY);
+				basic(fd, e->flags, HANG | BUSY);
 			}
 			igt_subtest_f("hang-wait-%s", e->name) {
 				gem_quiescent_gpu(fd);
-				basic(fd, e->exec_id | e->flags, HANG);
+				basic(fd, e->flags, HANG);
 			}
 			igt_subtest_f("hang-busy-write-%s", e->name) {
 				gem_quiescent_gpu(fd);
-				basic(fd, e->exec_id | e->flags, HANG | WRITE | BUSY);
+				basic(fd, e->flags, HANG | WRITE | BUSY);
 			}
 			igt_subtest_f("hang-wait-write-%s", e->name) {
 				gem_quiescent_gpu(fd);
-				basic(fd, e->exec_id | e->flags, HANG | WRITE);
+				basic(fd, e->flags, HANG | WRITE);
 			}
 		}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-05-13  0:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13  0:44 [igt-dev] [PATCH v23 00/14] new engine discovery interface Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 01/14] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 02/14] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 03/14] lib: igt_gt: add execution buffer flags to class helper Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 05/14] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-05-13  0:45 ` [igt-dev] [PATCH v23 06/14] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-05-13  9:03   ` Tvrtko Ursulin
2019-05-13 11:57   ` Chris Wilson
2019-05-13 14:15     ` Andi Shyti
2019-05-13 14:17       ` Chris Wilson
2019-05-13  0:45 ` [igt-dev] [PATCH v23 07/14] test/i915: gem_busy: " Andi Shyti
2019-05-13 10:42   ` Tvrtko Ursulin
2019-05-13 10:58     ` Chris Wilson
2019-05-13  0:45 ` [igt-dev] [PATCH v23 08/14] test/i915: gem_cs_tlb: " Andi Shyti
2019-05-13 10:43   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 09/14] test/i915: gem_ctx_exec: " Andi Shyti
2019-05-13 10:46   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 10/14] test/i915: gem_exec_basic: " Andi Shyti
2019-05-13 10:50   ` Tvrtko Ursulin
2019-05-13 10:53     ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 11/14] test/i915: gem_exec_parallel: " Andi Shyti
2019-05-13 10:56   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 12/14] test/i915: gem_exec_store: " Andi Shyti
2019-05-13 11:44   ` Tvrtko Ursulin
2019-05-13 11:46   ` Tvrtko Ursulin
2019-05-13  0:45 ` Andi Shyti [this message]
2019-05-13 11:46   ` [igt-dev] [PATCH v23 13/14] test/i915: gem_wait: " Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 14/14] test/i915: i915_hangman: " Andi Shyti
2019-05-13 11:49   ` Tvrtko Ursulin
2019-05-13  2:23 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-05-13  3:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-13  9:04 ` [igt-dev] [PATCH v23 00/14] " Tvrtko Ursulin
2019-05-13  9:43   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513004508.8042-14-andi@etezian.org \
    --to=andi@etezian.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox