public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>,
	Andi Shyti <andi@etezian.org>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH v23 06/14] test: perf_pmu: use the gem_engine_topology library
Date: Mon, 13 May 2019 17:15:34 +0300	[thread overview]
Message-ID: <20190513141534.GA1112@intel.intel> (raw)
In-Reply-To: <155774862021.2165.10796679625371240823@skylake-alporthouse-com>

Hi Chris,

On Mon, May 13, 2019 at 12:57:00PM +0100, Chris Wilson wrote:
> Quoting Andi Shyti (2019-05-13 01:45:00)
> >  static void
> > -init(int gem_fd, const struct intel_execution_engine2 *e, uint8_t sample)
> > +init(int gem_fd, struct intel_execution_engine2 *e, uint8_t sample)
> 
> There's a lot of const dropping where const seems appropriate throughout
> this series? Did I misread and there's a reason throughout why we are
> rewriting the caller's struct?

'const' is not needed anymore... why keep variables const while
we are not declaring them const?

Ther reason in a first place for having 'const' all around was
because we were looping through the "const struct
intel_execution_engine2 intel_execution_engines2[]" array, which
we are not doing anymore.

I see 'const' as somehow "type-incoherent".

Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-05-13 14:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13  0:44 [igt-dev] [PATCH v23 00/14] new engine discovery interface Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 01/14] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 02/14] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 03/14] lib: igt_gt: add execution buffer flags to class helper Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-05-13  0:44 ` [igt-dev] [PATCH v23 05/14] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-05-13  0:45 ` [igt-dev] [PATCH v23 06/14] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-05-13  9:03   ` Tvrtko Ursulin
2019-05-13 11:57   ` Chris Wilson
2019-05-13 14:15     ` Andi Shyti [this message]
2019-05-13 14:17       ` Chris Wilson
2019-05-13  0:45 ` [igt-dev] [PATCH v23 07/14] test/i915: gem_busy: " Andi Shyti
2019-05-13 10:42   ` Tvrtko Ursulin
2019-05-13 10:58     ` Chris Wilson
2019-05-13  0:45 ` [igt-dev] [PATCH v23 08/14] test/i915: gem_cs_tlb: " Andi Shyti
2019-05-13 10:43   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 09/14] test/i915: gem_ctx_exec: " Andi Shyti
2019-05-13 10:46   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 10/14] test/i915: gem_exec_basic: " Andi Shyti
2019-05-13 10:50   ` Tvrtko Ursulin
2019-05-13 10:53     ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 11/14] test/i915: gem_exec_parallel: " Andi Shyti
2019-05-13 10:56   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 12/14] test/i915: gem_exec_store: " Andi Shyti
2019-05-13 11:44   ` Tvrtko Ursulin
2019-05-13 11:46   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 13/14] test/i915: gem_wait: " Andi Shyti
2019-05-13 11:46   ` Tvrtko Ursulin
2019-05-13  0:45 ` [igt-dev] [PATCH v23 14/14] test/i915: i915_hangman: " Andi Shyti
2019-05-13 11:49   ` Tvrtko Ursulin
2019-05-13  2:23 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-05-13  3:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-13  9:04 ` [igt-dev] [PATCH v23 00/14] " Tvrtko Ursulin
2019-05-13  9:43   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513141534.GA1112@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=andi@etezian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox