* [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
@ 2019-05-17 20:21 Michal Wajdeczko
2019-05-17 20:44 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Michal Wajdeczko @ 2019-05-17 20:21 UTC (permalink / raw)
To: igt-dev; +Cc: Tony Ye
Add simple test to check that HuC firmware is available.
Use existing I915_GETPARAM and debugfs entry.
v2: make it even simpler
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tony Ye <tony.ye@intel.com>
---
tests/Makefile.sources | 3 +++
tests/i915/i915_huc.c | 59 ++++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
3 files changed, 63 insertions(+)
create mode 100644 tests/i915/i915_huc.c
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 7f921f6c..dfa3fcd3 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES = i915/i915_getparams_basic.c
TESTS_progs += i915_hangman
i915_hangman_SOURCES = i915/i915_hangman.c
+TESTS_progs += i915_huc
+i915_huc_SOURCES = i915/i915_huc.c
+
TESTS_progs += i915_module_load
i915_module_load_SOURCES = i915/i915_module_load.c
diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
new file mode 100644
index 00000000..e4e6c532
--- /dev/null
+++ b/tests/i915/i915_huc.c
@@ -0,0 +1,59 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright (c) 2019 Intel Corporation
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <i915_drm.h>
+#include <sys/ioctl.h>
+
+IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
+
+static bool has_guc(int fd)
+{
+ uint32_t devid = intel_get_drm_devid(fd);
+
+ return IS_SKYLAKE(devid) || IS_BROXTON(devid) ||
+ IS_KABYLAKE(devid) || IS_COFFEELAKE(devid) ||
+ IS_GEMINILAKE(devid) || IS_ICELAKE(devid);
+}
+
+static bool has_huc(int fd)
+{
+ return has_guc(fd);
+}
+
+static int huc_status(int fd)
+{
+ int loaded = 0;
+ drm_i915_getparam_t gp = {
+ .param = I915_PARAM_HUC_STATUS,
+ .value = &loaded,
+ };
+
+ if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+ return -errno;
+
+ return loaded;
+}
+
+igt_main
+{
+ int fd;
+
+ igt_fixture {
+ fd = drm_open_driver(DRIVER_INTEL);
+ igt_require_intel(fd);
+ igt_require(has_huc(fd));
+ igt_debugfs_dump(fd, "i915_huc_load_status");
+ igt_require(huc_status(fd) > 0);
+ }
+
+ igt_subtest("basic")
+ igt_success();
+
+ igt_fixture {
+ close(fd);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 351594fa..22ed165c 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -220,6 +220,7 @@ i915_progs = [
'i915_fb_tiling',
'i915_getparams_basic',
'i915_hangman',
+ 'i915_huc',
'i915_module_load',
'i915_pm_backlight',
'i915_pm_lpsp',
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 20:21 [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC Michal Wajdeczko
@ 2019-05-17 20:44 ` Chris Wilson
2019-05-17 20:53 ` Michal Wajdeczko
2019-05-17 21:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Add simple test for HuC (rev2) Patchwork
2019-05-18 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-05-17 20:44 UTC (permalink / raw)
To: Michal Wajdeczko, igt-dev; +Cc: Tony Ye
Quoting Michal Wajdeczko (2019-05-17 21:21:54)
> Add simple test to check that HuC firmware is available.
> Use existing I915_GETPARAM and debugfs entry.
>
> v2: make it even simpler
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tony Ye <tony.ye@intel.com>
> ---
> tests/Makefile.sources | 3 +++
> tests/i915/i915_huc.c | 59 ++++++++++++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 3 files changed, 63 insertions(+)
> create mode 100644 tests/i915/i915_huc.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 7f921f6c..dfa3fcd3 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES = i915/i915_getparams_basic.c
> TESTS_progs += i915_hangman
> i915_hangman_SOURCES = i915/i915_hangman.c
>
> +TESTS_progs += i915_huc
> +i915_huc_SOURCES = i915/i915_huc.c
> +
> TESTS_progs += i915_module_load
> i915_module_load_SOURCES = i915/i915_module_load.c
>
> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
> new file mode 100644
> index 00000000..e4e6c532
> --- /dev/null
> +++ b/tests/i915/i915_huc.c
> @@ -0,0 +1,59 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright (c) 2019 Intel Corporation
> + */
> +
> +#include "igt.h"
> +#include <fcntl.h>
> +#include <i915_drm.h>
> +#include <sys/ioctl.h>
> +
> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
> +
> +static int huc_status(int fd)
> +{
> + int loaded = 0;
> + drm_i915_getparam_t gp = {
> + .param = I915_PARAM_HUC_STATUS,
> + .value = &loaded,
> + };
> +
> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> + return -errno;
(mutters about errno upsetting igt_assert and making a mess)
> +
> + return loaded;
> +}
> +
> +igt_main
> +{
> + int fd;
> +
> + igt_fixture {
> + fd = drm_open_driver(DRIVER_INTEL);
> + igt_require_intel(fd);
> + igt_require(has_huc(fd));
This is now redundant...
> + igt_debugfs_dump(fd, "i915_huc_load_status");
> + igt_require(huc_status(fd) > 0);
As we get the debugfs and HUC_STATUS.
> + }
> +
> + igt_subtest("basic")
> + igt_success();
> +
> + igt_fixture {
> + close(fd);
Worksforme as a starting point,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(preferably without the extra igt_require(has_huc))
I trust that anyone who contemplates demanding that HuC be enabled by
default follows up with an actual test to prove the HuC is functional
and we don't accidentally break it.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 20:44 ` Chris Wilson
@ 2019-05-17 20:53 ` Michal Wajdeczko
2019-05-17 21:03 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Michal Wajdeczko @ 2019-05-17 20:53 UTC (permalink / raw)
To: igt-dev, Chris Wilson; +Cc: Tony Ye
On Fri, 17 May 2019 22:44:53 +0200, Chris Wilson
<chris@chris-wilson.co.uk> wrote:
> Quoting Michal Wajdeczko (2019-05-17 21:21:54)
>> Add simple test to check that HuC firmware is available.
>> Use existing I915_GETPARAM and debugfs entry.
>>
>> v2: make it even simpler
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>> tests/Makefile.sources | 3 +++
>> tests/i915/i915_huc.c | 59 ++++++++++++++++++++++++++++++++++++++++++
>> tests/meson.build | 1 +
>> 3 files changed, 63 insertions(+)
>> create mode 100644 tests/i915/i915_huc.c
>>
>> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
>> index 7f921f6c..dfa3fcd3 100644
>> --- a/tests/Makefile.sources
>> +++ b/tests/Makefile.sources
>> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES =
>> i915/i915_getparams_basic.c
>> TESTS_progs += i915_hangman
>> i915_hangman_SOURCES = i915/i915_hangman.c
>>
>> +TESTS_progs += i915_huc
>> +i915_huc_SOURCES = i915/i915_huc.c
>> +
>> TESTS_progs += i915_module_load
>> i915_module_load_SOURCES = i915/i915_module_load.c
>>
>> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
>> new file mode 100644
>> index 00000000..e4e6c532
>> --- /dev/null
>> +++ b/tests/i915/i915_huc.c
>> @@ -0,0 +1,59 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright (c) 2019 Intel Corporation
>> + */
>> +
>> +#include "igt.h"
>> +#include <fcntl.h>
>> +#include <i915_drm.h>
>> +#include <sys/ioctl.h>
>> +
>> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
>> +
>> +static int huc_status(int fd)
>> +{
>> + int loaded = 0;
>> + drm_i915_getparam_t gp = {
>> + .param = I915_PARAM_HUC_STATUS,
>> + .value = &loaded,
>> + };
>> +
>> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
>> + return -errno;
>
> (mutters about errno upsetting igt_assert and making a mess)
maybe better to return -1 ?
>
>> +
>> + return loaded;
>> +}
>> +
>> +igt_main
>> +{
>> + int fd;
>> +
>> + igt_fixture {
>> + fd = drm_open_driver(DRIVER_INTEL);
>> + igt_require_intel(fd);
>> + igt_require(has_huc(fd));
>
> This is now redundant...
not quite, as diagnostic message will be different, compare:
Test requirement not met
Test requirement: has_huc(fd)
means lack of HuC hardware, vs
Test requirement not met
Test requirement: huc_status(fd) > 0
means HuC firmware was not loaded
>
>> + igt_debugfs_dump(fd, "i915_huc_load_status");
>> + igt_require(huc_status(fd) > 0);
>
> As we get the debugfs and HUC_STATUS.
debugfs is mainly for fw version which may be changing,
above requirements are likely easier to add as filters to CI
>
>> + }
>> +
>> + igt_subtest("basic")
>> + igt_success();
>> +
>> + igt_fixture {
>> + close(fd);
>
> Worksforme as a starting point,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> (preferably without the extra igt_require(has_huc))
please keep
>
> I trust that anyone who contemplates demanding that HuC be enabled by
> default follows up with an actual test to prove the HuC is functional
> and we don't accidentally break it.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 20:53 ` Michal Wajdeczko
@ 2019-05-17 21:03 ` Chris Wilson
2019-05-17 21:56 ` Michal Wajdeczko
0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-05-17 21:03 UTC (permalink / raw)
To: Michal Wajdeczko, igt-dev; +Cc: Tony Ye
Quoting Michal Wajdeczko (2019-05-17 21:53:33)
> On Fri, 17 May 2019 22:44:53 +0200, Chris Wilson
> <chris@chris-wilson.co.uk> wrote:
>
> > Quoting Michal Wajdeczko (2019-05-17 21:21:54)
> >> Add simple test to check that HuC firmware is available.
> >> Use existing I915_GETPARAM and debugfs entry.
> >>
> >> v2: make it even simpler
> >>
> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> Cc: Martin Peres <martin.peres@linux.intel.com>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Tony Ye <tony.ye@intel.com>
> >> ---
> >> tests/Makefile.sources | 3 +++
> >> tests/i915/i915_huc.c | 59 ++++++++++++++++++++++++++++++++++++++++++
> >> tests/meson.build | 1 +
> >> 3 files changed, 63 insertions(+)
> >> create mode 100644 tests/i915/i915_huc.c
> >>
> >> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> >> index 7f921f6c..dfa3fcd3 100644
> >> --- a/tests/Makefile.sources
> >> +++ b/tests/Makefile.sources
> >> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES =
> >> i915/i915_getparams_basic.c
> >> TESTS_progs += i915_hangman
> >> i915_hangman_SOURCES = i915/i915_hangman.c
> >>
> >> +TESTS_progs += i915_huc
> >> +i915_huc_SOURCES = i915/i915_huc.c
> >> +
> >> TESTS_progs += i915_module_load
> >> i915_module_load_SOURCES = i915/i915_module_load.c
> >>
> >> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
> >> new file mode 100644
> >> index 00000000..e4e6c532
> >> --- /dev/null
> >> +++ b/tests/i915/i915_huc.c
> >> @@ -0,0 +1,59 @@
> >> +/* SPDX-License-Identifier: MIT */
> >> +/*
> >> + * Copyright (c) 2019 Intel Corporation
> >> + */
> >> +
> >> +#include "igt.h"
> >> +#include <fcntl.h>
> >> +#include <i915_drm.h>
> >> +#include <sys/ioctl.h>
> >> +
> >> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
> >> +
> >> +static int huc_status(int fd)
> >> +{
> >> + int loaded = 0;
> >> + drm_i915_getparam_t gp = {
> >> + .param = I915_PARAM_HUC_STATUS,
> >> + .value = &loaded,
> >> + };
> >> +
> >> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> >> + return -errno;
> >
> > (mutters about errno upsetting igt_assert and making a mess)
>
> maybe better to return -1 ?
>
> >
> >> +
> >> + return loaded;
> >> +}
> >> +
> >> +igt_main
> >> +{
> >> + int fd;
> >> +
> >> + igt_fixture {
> >> + fd = drm_open_driver(DRIVER_INTEL);
> >> + igt_require_intel(fd);
> >> + igt_require(has_huc(fd));
> >
> > This is now redundant...
>
> not quite, as diagnostic message will be different, compare:
>
> Test requirement not met
> Test requirement: has_huc(fd)
>
> means lack of HuC hardware, vs
But why does this test dictate on what HW we expect HuC? Did not cnl
ship a similar uc, just no fw released?
I do not accept this igt as being the better source of truth than the
kernel.
> Test requirement not met
> Test requirement: huc_status(fd) > 0
>
> means HuC firmware was not loaded
Without us guessing why, as the explanation should be in the debugfs.
> >> + igt_debugfs_dump(fd, "i915_huc_load_status");
> >> + igt_require(huc_status(fd) > 0);
> >
> > As we get the debugfs and HUC_STATUS.
>
> debugfs is mainly for fw version which may be changing,
> above requirements are likely easier to add as filters to CI
Fwiw, make that __igt_debugfs_dump(..., IGT_INFO).
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 21:03 ` Chris Wilson
@ 2019-05-17 21:56 ` Michal Wajdeczko
2019-05-17 22:09 ` Chris Wilson
2019-05-17 22:25 ` Chris Wilson
0 siblings, 2 replies; 9+ messages in thread
From: Michal Wajdeczko @ 2019-05-17 21:56 UTC (permalink / raw)
To: igt-dev, Chris Wilson; +Cc: Tony Ye
On Fri, 17 May 2019 23:03:56 +0200, Chris Wilson
<chris@chris-wilson.co.uk> wrote:
> Quoting Michal Wajdeczko (2019-05-17 21:53:33)
>> On Fri, 17 May 2019 22:44:53 +0200, Chris Wilson
>> <chris@chris-wilson.co.uk> wrote:
>>
>> > Quoting Michal Wajdeczko (2019-05-17 21:21:54)
>> >> Add simple test to check that HuC firmware is available.
>> >> Use existing I915_GETPARAM and debugfs entry.
>> >>
>> >> v2: make it even simpler
>> >>
>> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> >> Cc: Martin Peres <martin.peres@linux.intel.com>
>> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> >> Cc: Tony Ye <tony.ye@intel.com>
>> >> ---
>> >> tests/Makefile.sources | 3 +++
>> >> tests/i915/i915_huc.c | 59
>> ++++++++++++++++++++++++++++++++++++++++++
>> >> tests/meson.build | 1 +
>> >> 3 files changed, 63 insertions(+)
>> >> create mode 100644 tests/i915/i915_huc.c
>> >>
>> >> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
>> >> index 7f921f6c..dfa3fcd3 100644
>> >> --- a/tests/Makefile.sources
>> >> +++ b/tests/Makefile.sources
>> >> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES =
>> >> i915/i915_getparams_basic.c
>> >> TESTS_progs += i915_hangman
>> >> i915_hangman_SOURCES = i915/i915_hangman.c
>> >>
>> >> +TESTS_progs += i915_huc
>> >> +i915_huc_SOURCES = i915/i915_huc.c
>> >> +
>> >> TESTS_progs += i915_module_load
>> >> i915_module_load_SOURCES = i915/i915_module_load.c
>> >>
>> >> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
>> >> new file mode 100644
>> >> index 00000000..e4e6c532
>> >> --- /dev/null
>> >> +++ b/tests/i915/i915_huc.c
>> >> @@ -0,0 +1,59 @@
>> >> +/* SPDX-License-Identifier: MIT */
>> >> +/*
>> >> + * Copyright (c) 2019 Intel Corporation
>> >> + */
>> >> +
>> >> +#include "igt.h"
>> >> +#include <fcntl.h>
>> >> +#include <i915_drm.h>
>> >> +#include <sys/ioctl.h>
>> >> +
>> >> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
>> >> +
>> >> +static int huc_status(int fd)
>> >> +{
>> >> + int loaded = 0;
>> >> + drm_i915_getparam_t gp = {
>> >> + .param = I915_PARAM_HUC_STATUS,
>> >> + .value = &loaded,
>> >> + };
>> >> +
>> >> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
>> >> + return -errno;
>> >
>> > (mutters about errno upsetting igt_assert and making a mess)
>>
>> maybe better to return -1 ?
>>
>> >
>> >> +
>> >> + return loaded;
>> >> +}
>> >> +
>> >> +igt_main
>> >> +{
>> >> + int fd;
>> >> +
>> >> + igt_fixture {
>> >> + fd = drm_open_driver(DRIVER_INTEL);
>> >> + igt_require_intel(fd);
>> >> + igt_require(has_huc(fd));
>> >
>> > This is now redundant...
>>
>> not quite, as diagnostic message will be different, compare:
>>
>> Test requirement not met
>> Test requirement: has_huc(fd)
>>
>> means lack of HuC hardware, vs
>
> But why does this test dictate on what HW we expect HuC? Did not cnl
> ship a similar uc, just no fw released?
>
> I do not accept this igt as being the better source of truth than the
> kernel.
>
>> Test requirement not met
>> Test requirement: huc_status(fd) > 0
>>
>> means HuC firmware was not loaded
>
> Without us guessing why, as the explanation should be in the debugfs.
which, as you said earlier, may not exist
>
>> >> + igt_debugfs_dump(fd, "i915_huc_load_status");
>> >> + igt_require(huc_status(fd) > 0);
>> >
>> > As we get the debugfs and HUC_STATUS.
>>
>> debugfs is mainly for fw version which may be changing,
>> above requirements are likely easier to add as filters to CI
>
> Fwiw, make that __igt_debugfs_dump(..., IGT_INFO).
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 21:56 ` Michal Wajdeczko
@ 2019-05-17 22:09 ` Chris Wilson
2019-05-17 22:25 ` Chris Wilson
1 sibling, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2019-05-17 22:09 UTC (permalink / raw)
To: Michal Wajdeczko, igt-dev; +Cc: Tony Ye
Quoting Michal Wajdeczko (2019-05-17 22:56:36)
> On Fri, 17 May 2019 23:03:56 +0200, Chris Wilson
> <chris@chris-wilson.co.uk> wrote:
>
> > Quoting Michal Wajdeczko (2019-05-17 21:53:33)
> >> On Fri, 17 May 2019 22:44:53 +0200, Chris Wilson
> >> <chris@chris-wilson.co.uk> wrote:
> >>
> >> > Quoting Michal Wajdeczko (2019-05-17 21:21:54)
> >> >> Add simple test to check that HuC firmware is available.
> >> >> Use existing I915_GETPARAM and debugfs entry.
> >> >>
> >> >> v2: make it even simpler
> >> >>
> >> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> >> Cc: Martin Peres <martin.peres@linux.intel.com>
> >> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> >> Cc: Tony Ye <tony.ye@intel.com>
> >> >> ---
> >> >> tests/Makefile.sources | 3 +++
> >> >> tests/i915/i915_huc.c | 59
> >> ++++++++++++++++++++++++++++++++++++++++++
> >> >> tests/meson.build | 1 +
> >> >> 3 files changed, 63 insertions(+)
> >> >> create mode 100644 tests/i915/i915_huc.c
> >> >>
> >> >> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> >> >> index 7f921f6c..dfa3fcd3 100644
> >> >> --- a/tests/Makefile.sources
> >> >> +++ b/tests/Makefile.sources
> >> >> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES =
> >> >> i915/i915_getparams_basic.c
> >> >> TESTS_progs += i915_hangman
> >> >> i915_hangman_SOURCES = i915/i915_hangman.c
> >> >>
> >> >> +TESTS_progs += i915_huc
> >> >> +i915_huc_SOURCES = i915/i915_huc.c
> >> >> +
> >> >> TESTS_progs += i915_module_load
> >> >> i915_module_load_SOURCES = i915/i915_module_load.c
> >> >>
> >> >> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
> >> >> new file mode 100644
> >> >> index 00000000..e4e6c532
> >> >> --- /dev/null
> >> >> +++ b/tests/i915/i915_huc.c
> >> >> @@ -0,0 +1,59 @@
> >> >> +/* SPDX-License-Identifier: MIT */
> >> >> +/*
> >> >> + * Copyright (c) 2019 Intel Corporation
> >> >> + */
> >> >> +
> >> >> +#include "igt.h"
> >> >> +#include <fcntl.h>
> >> >> +#include <i915_drm.h>
> >> >> +#include <sys/ioctl.h>
> >> >> +
> >> >> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
> >> >> +
> >> >> +static int huc_status(int fd)
> >> >> +{
> >> >> + int loaded = 0;
> >> >> + drm_i915_getparam_t gp = {
> >> >> + .param = I915_PARAM_HUC_STATUS,
> >> >> + .value = &loaded,
> >> >> + };
> >> >> +
> >> >> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> >> >> + return -errno;
> >> >
> >> > (mutters about errno upsetting igt_assert and making a mess)
> >>
> >> maybe better to return -1 ?
> >>
> >> >
> >> >> +
> >> >> + return loaded;
> >> >> +}
> >> >> +
> >> >> +igt_main
> >> >> +{
> >> >> + int fd;
> >> >> +
> >> >> + igt_fixture {
> >> >> + fd = drm_open_driver(DRIVER_INTEL);
> >> >> + igt_require_intel(fd);
> >> >> + igt_require(has_huc(fd));
> >> >
> >> > This is now redundant...
> >>
> >> not quite, as diagnostic message will be different, compare:
> >>
> >> Test requirement not met
> >> Test requirement: has_huc(fd)
> >>
> >> means lack of HuC hardware, vs
> >
> > But why does this test dictate on what HW we expect HuC? Did not cnl
> > ship a similar uc, just no fw released?
> >
> > I do not accept this igt as being the better source of truth than the
> > kernel.
> >
> >> Test requirement not met
> >> Test requirement: huc_status(fd) > 0
> >>
> >> means HuC firmware was not loaded
> >
> > Without us guessing why, as the explanation should be in the debugfs.
>
> which, as you said earlier, may not exist
In which case the user is left to their devices to divine what happened,
presumably looking at dmesg. Still looking at why the kernel didn't do
something is much better than guessing.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC
2019-05-17 21:56 ` Michal Wajdeczko
2019-05-17 22:09 ` Chris Wilson
@ 2019-05-17 22:25 ` Chris Wilson
1 sibling, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2019-05-17 22:25 UTC (permalink / raw)
To: Michal Wajdeczko, igt-dev; +Cc: Tony Ye
Quoting Michal Wajdeczko (2019-05-17 22:56:36)
> On Fri, 17 May 2019 23:03:56 +0200, Chris Wilson
> <chris@chris-wilson.co.uk> wrote:
>
> > Quoting Michal Wajdeczko (2019-05-17 21:53:33)
> >> On Fri, 17 May 2019 22:44:53 +0200, Chris Wilson
> >> <chris@chris-wilson.co.uk> wrote:
> >>
> >> > Quoting Michal Wajdeczko (2019-05-17 21:21:54)
> >> >> Add simple test to check that HuC firmware is available.
> >> >> Use existing I915_GETPARAM and debugfs entry.
> >> >>
> >> >> v2: make it even simpler
> >> >>
> >> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> >> Cc: Martin Peres <martin.peres@linux.intel.com>
> >> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> >> Cc: Tony Ye <tony.ye@intel.com>
> >> >> ---
> >> >> tests/Makefile.sources | 3 +++
> >> >> tests/i915/i915_huc.c | 59
> >> ++++++++++++++++++++++++++++++++++++++++++
> >> >> tests/meson.build | 1 +
> >> >> 3 files changed, 63 insertions(+)
> >> >> create mode 100644 tests/i915/i915_huc.c
> >> >>
> >> >> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> >> >> index 7f921f6c..dfa3fcd3 100644
> >> >> --- a/tests/Makefile.sources
> >> >> +++ b/tests/Makefile.sources
> >> >> @@ -475,6 +475,9 @@ i915_getparams_basic_SOURCES =
> >> >> i915/i915_getparams_basic.c
> >> >> TESTS_progs += i915_hangman
> >> >> i915_hangman_SOURCES = i915/i915_hangman.c
> >> >>
> >> >> +TESTS_progs += i915_huc
> >> >> +i915_huc_SOURCES = i915/i915_huc.c
> >> >> +
> >> >> TESTS_progs += i915_module_load
> >> >> i915_module_load_SOURCES = i915/i915_module_load.c
> >> >>
> >> >> diff --git a/tests/i915/i915_huc.c b/tests/i915/i915_huc.c
> >> >> new file mode 100644
> >> >> index 00000000..e4e6c532
> >> >> --- /dev/null
> >> >> +++ b/tests/i915/i915_huc.c
> >> >> @@ -0,0 +1,59 @@
> >> >> +/* SPDX-License-Identifier: MIT */
> >> >> +/*
> >> >> + * Copyright (c) 2019 Intel Corporation
> >> >> + */
> >> >> +
> >> >> +#include "igt.h"
> >> >> +#include <fcntl.h>
> >> >> +#include <i915_drm.h>
> >> >> +#include <sys/ioctl.h>
> >> >> +
> >> >> +IGT_TEST_DESCRIPTION("Check that HuC firmware is available.");
> >> >> +
> >> >> +static int huc_status(int fd)
> >> >> +{
> >> >> + int loaded = 0;
> >> >> + drm_i915_getparam_t gp = {
> >> >> + .param = I915_PARAM_HUC_STATUS,
> >> >> + .value = &loaded,
> >> >> + };
> >> >> +
> >> >> + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> >> >> + return -errno;
> >> >
> >> > (mutters about errno upsetting igt_assert and making a mess)
> >>
> >> maybe better to return -1 ?
> >>
> >> >
> >> >> +
> >> >> + return loaded;
> >> >> +}
> >> >> +
> >> >> +igt_main
> >> >> +{
> >> >> + int fd;
> >> >> +
> >> >> + igt_fixture {
> >> >> + fd = drm_open_driver(DRIVER_INTEL);
> >> >> + igt_require_intel(fd);
> >> >> + igt_require(has_huc(fd));
> >> >
> >> > This is now redundant...
> >>
> >> not quite, as diagnostic message will be different, compare:
> >>
> >> Test requirement not met
> >> Test requirement: has_huc(fd)
> >>
> >> means lack of HuC hardware, vs
> >
> > But why does this test dictate on what HW we expect HuC? Did not cnl
> > ship a similar uc, just no fw released?
> >
> > I do not accept this igt as being the better source of truth than the
> > kernel.
> >
> >> Test requirement not met
> >> Test requirement: huc_status(fd) > 0
> >>
> >> means HuC firmware was not loaded
> >
> > Without us guessing why, as the explanation should be in the debugfs.
>
> which, as you said earlier, may not exist
Also note the kernel is already giving us the has_huc infomation in the
errno, so if you want to be informative, decode the error return.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Add simple test for HuC (rev2)
2019-05-17 20:21 [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC Michal Wajdeczko
2019-05-17 20:44 ` Chris Wilson
@ 2019-05-17 21:29 ` Patchwork
2019-05-18 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-05-17 21:29 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Add simple test for HuC (rev2)
URL : https://patchwork.freedesktop.org/series/60800/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6097 -> IGTPW_3001
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60800/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_3001 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_execlists:
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927] / [fdo#109720])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/fi-apl-guc/igt@i915_selftest@live_execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/fi-apl-guc/igt@i915_selftest@live_execlists.html
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: [DMESG-WARN][5] ([fdo#108965]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][7] ([fdo#108602] / [fdo#108744]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
- fi-apl-guc: [FAIL][9] ([fdo#110623]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110623]: https://bugs.freedesktop.org/show_bug.cgi?id=110623
Participating hosts (52 -> 46)
------------------------------
Additional (1): fi-pnv-d510
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_4996 -> IGTPW_3001
CI_DRM_6097: 3f2d6a47d9eec66594887b1e9718bc1a29aa6a77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3001: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/
IGT_4996: 6fe5d254ec1b9b47d61408e1b49a7339876bf1e7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@i915_huc@basic
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915: Add simple test for HuC (rev2)
2019-05-17 20:21 [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC Michal Wajdeczko
2019-05-17 20:44 ` Chris Wilson
2019-05-17 21:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Add simple test for HuC (rev2) Patchwork
@ 2019-05-18 12:30 ` Patchwork
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-05-18 12:30 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Add simple test for HuC (rev2)
URL : https://patchwork.freedesktop.org/series/60800/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6097_full -> IGTPW_3001_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3001_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3001_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60800/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3001_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-apl7/igt@kms_color@pipe-b-ctm-max.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-apl1/igt@kms_color@pipe-b-ctm-max.html
- shard-kbl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-kbl3/igt@kms_color@pipe-b-ctm-max.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-kbl7/igt@kms_color@pipe-b-ctm-max.html
New tests
---------
New tests have been introduced between CI_DRM_6097_full and IGTPW_3001_full:
### New IGT tests (1) ###
* igt@i915_huc@basic:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_3001_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@forked-big-copy:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#109100])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb3/igt@gem_mmap_gtt@forked-big-copy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb7/igt@gem_mmap_gtt@forked-big-copy.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-apl1/igt@i915_suspend@debugfs-reader.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-apl4/igt@i915_suspend@debugfs-reader.html
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([fdo#103540])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-hsw6/igt@kms_busy@extended-pageflip-hang-newfb-render-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-hsw4/igt@kms_busy@extended-pageflip-hang-newfb-render-c.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][11] -> [FAIL][12] ([fdo#105767])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt:
- shard-glk: [PASS][13] -> [FAIL][14] ([fdo#103167])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb2/igt@kms_psr@psr2_dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb1/igt@kms_psr@psr2_dpms.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-apl6/igt@kms_setmode@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-apl5/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_mmap_gtt@forked-medium-copy-odd:
- shard-iclb: [INCOMPLETE][21] ([fdo#107713]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb7/igt@gem_mmap_gtt@forked-medium-copy-odd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb5/igt@gem_mmap_gtt@forked-medium-copy-odd.html
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][23] ([fdo#108686]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-glk7/igt@gem_tiled_swapping@non-threaded.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-glk6/igt@gem_tiled_swapping@non-threaded.html
- shard-hsw: [FAIL][25] ([fdo#108686]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-hsw4/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_color@pipe-b-ctm-green-to-red:
- shard-kbl: [FAIL][27] ([fdo#107201]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-kbl7/igt@kms_color@pipe-b-ctm-green-to-red.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-kbl4/igt@kms_color@pipe-b-ctm-green-to-red.html
- shard-apl: [FAIL][29] ([fdo#107201]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-apl5/igt@kms_color@pipe-b-ctm-green-to-red.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-apl8/igt@kms_color@pipe-b-ctm-green-to-red.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][31] ([fdo#105767]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][33] ([fdo#102887]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][39] ([fdo#103166]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][41] ([fdo#99912]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6097/shard-hsw1/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/shard-hsw4/igt@kms_setmode@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4996 -> IGTPW_3001
* Piglit: piglit_4509 -> None
CI_DRM_6097: 3f2d6a47d9eec66594887b1e9718bc1a29aa6a77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3001: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/
IGT_4996: 6fe5d254ec1b9b47d61408e1b49a7339876bf1e7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3001/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-05-18 12:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-17 20:21 [igt-dev] [PATCH i-g-t v2] tests/i915: Add simple test for HuC Michal Wajdeczko
2019-05-17 20:44 ` Chris Wilson
2019-05-17 20:53 ` Michal Wajdeczko
2019-05-17 21:03 ` Chris Wilson
2019-05-17 21:56 ` Michal Wajdeczko
2019-05-17 22:09 ` Chris Wilson
2019-05-17 22:25 ` Chris Wilson
2019-05-17 21:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Add simple test for HuC (rev2) Patchwork
2019-05-18 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox