From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 05/27] trace.pl: Virtual engine preemption support
Date: Mon, 20 May 2019 15:47:17 +0100 [thread overview]
Message-ID: <20190520144739.13111-6-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190520144739.13111-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Use the 'completed?' tracepoint field to detect more robustly when a
request has been preempted and remove it from the engine database if so.
Otherwise the script can hit a scenario where the same global seqno will
be mentioned multiple times (on an engine seqno) which aborts processing.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
scripts/trace.pl | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 1f4953b02ef6..77587f24197a 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -488,16 +488,21 @@ while (<>) {
$ringmap{$rings{$ring}} = $ring;
$db{$key} = \%req;
} elsif ($tp_name eq 'i915:i915_request_out:') {
- my $nkey;
+ if ($tp{'completed?'}) {
+ my $nkey;
- die unless exists $db{$key};
- die unless exists $db{$key}->{'start'};
- die if exists $db{$key}->{'end'};
+ die unless exists $db{$key};
+ die unless exists $db{$key}->{'start'};
+ die if exists $db{$key}->{'end'};
- $nkey = notify_key($ctx, $seqno);
+ $nkey = notify_key($ctx, $seqno);
- $db{$key}->{'end'} = $time;
- $db{$key}->{'notify'} = $notify{$nkey} if exists $notify{$nkey};
+ $db{$key}->{'end'} = $time;
+ $db{$key}->{'notify'} = $notify{$nkey}
+ if exists $notify{$nkey};
+ } else {
+ delete $db{$key};
+ }
} elsif ($tp_name eq 'dma_fence:dma_fence_signaled:') {
my $nkey;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-20 14:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:47 [igt-dev] [PATCH i-g-t 00/27] Media scalability tooling Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 01/27] scripts/trace.pl: Fix after intel_engine_notify removal Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 02/27] trace.pl: Ignore signaling on non i915 fences Tvrtko Ursulin
2019-05-21 7:57 ` Chris Wilson
2019-05-21 13:22 ` Tvrtko Ursulin
2019-05-21 15:29 ` Chris Wilson
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 03/27] headers: bump Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 04/27] trace.pl: Virtual engine support Tvrtko Ursulin
2019-05-20 14:47 ` Tvrtko Ursulin [this message]
2019-05-20 14:47 ` [Intel-gfx] [PATCH i-g-t 06/27] wsim/media-bench: i915 balancing Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 07/27] gem_wsim: Use IGT uapi headers Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 08/27] gem_wsim: Factor out common error handling Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 09/27] gem_wsim: More wsim_err Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 10/27] gem_wsim: Submit fence support Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 11/27] gem_wsim: Extract str to engine lookup Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 12/27] gem_wsim: Engine map support Tvrtko Ursulin
2019-05-21 8:14 ` Chris Wilson
2019-05-21 8:29 ` Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 13/27] gem_wsim: Save some lines by changing to implicit NULL checking Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 14/27] gem_wsim: Compact int command parsing with a macro Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 15/27] gem_wsim: Engine map load balance command Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 16/27] gem_wsim: Engine bond command Tvrtko Ursulin
2019-05-20 14:47 ` [Intel-gfx] [PATCH i-g-t 17/27] gem_wsim: Some more example workloads Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 18/27] gem_wsim: Infinite batch support Tvrtko Ursulin
2019-05-20 14:47 ` [Intel-gfx] [PATCH i-g-t 19/27] gem_wsim: Command line switch for specifying low slice count workloads Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 20/27] gem_wsim: Per context SSEU control Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 21/27] gem_wsim: Allow RCS virtual engine with " Tvrtko Ursulin
2019-05-20 14:47 ` [Intel-gfx] [PATCH i-g-t 22/27] tests/i915_query: Engine discovery tests Tvrtko Ursulin
2019-05-22 8:23 ` [igt-dev] " Andi Shyti
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 23/27] gem_wsim: Consolidate engine assignments into helpers Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 24/27] gem_wsim: Discover engines Tvrtko Ursulin
2019-05-21 13:54 ` Andi Shyti
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 25/27] gem_wsim: Support Icelake parts Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 26/27] gem_wsim: Fix prng usage Tvrtko Ursulin
2019-05-20 14:47 ` [igt-dev] [PATCH i-g-t 27/27] gem_wsim: Allow random seed control Tvrtko Ursulin
2019-05-21 9:22 ` [igt-dev] ✓ Fi.CI.BAT: success for Media scalability tooling (rev6) Patchwork
2019-05-21 13:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520144739.13111-6-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox