public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [CI i-g-t 11/14] test/i915: gem_exec_parallel: use the gem_engine_topology library
Date: Wed, 22 May 2019 14:51:01 +0100	[thread overview]
Message-ID: <20190522135104.26930-12-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190522135104.26930-1-tvrtko.ursulin@linux.intel.com>

From: Andi Shyti <andi.shyti@intel.com>

Replace the legacy for_each_engine* defines with the ones
implemented in the gem_engine_topology library.

Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_exec_parallel.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
index 7597befb0b39..8a4482e52a6e 100644
--- a/tests/i915/gem_exec_parallel.c
+++ b/tests/i915/gem_exec_parallel.c
@@ -149,7 +149,7 @@ static void *thread(void *data)
 	return NULL;
 }
 
-static void all(int fd, unsigned engine, unsigned flags)
+static void all(int fd, struct intel_execution_engine2 *engine, unsigned flags)
 {
 	const int gen = intel_gen(intel_get_drm_devid(fd));
 	pthread_mutex_t mutex;
@@ -170,15 +170,15 @@ static void all(int fd, unsigned engine, unsigned flags)
 	}
 
 	nengine = 0;
-	if (engine == ALL_ENGINES) {
-		for_each_physical_engine(fd, engine) {
-			if (gem_can_store_dword(fd, engine))
-				engines[nengine++] = engine;
+	if (!engine) {
+		struct intel_execution_engine2 *e;
+		__for_each_physical_engine(fd, e) {
+			if (gem_class_can_store_dword(fd, e->class))
+				engines[nengine++] = e->flags;
 		}
 	} else {
-		igt_require(gem_has_ring(fd, engine));
-		igt_require(gem_can_store_dword(fd, engine));
-		engines[nengine++] = engine;
+		igt_require(gem_class_can_store_dword(fd, engine->class));
+		engines[nengine++] = engine->flags;
 	}
 	igt_require(nengine);
 
@@ -229,6 +229,8 @@ static void all(int fd, unsigned engine, unsigned flags)
 
 igt_main
 {
+	struct intel_execution_engine2 *e;
+
 	const struct mode {
 		const char *name;
 		unsigned flags;
@@ -249,16 +251,16 @@ igt_main
 
 	for (const struct mode *m = modes; m->name; m++)
 		igt_subtest_f("%s", *m->name ? m->name : "basic")
-			all(fd, ALL_ENGINES, m->flags);
+			/* NULL value means all engines */
+			all(fd, NULL, m->flags);
 
-	for (const struct intel_execution_engine *e = intel_execution_engines;
-	     e->name; e++) {
+	__for_each_physical_engine(fd, e) {
 		for (const struct mode *m = modes; m->name; m++)
 			igt_subtest_f("%s%s%s",
 				      e->name,
 				      *m->name ? "-" : "",
 				      m->name)
-				all(fd, e->exec_id | e->flags, m->flags);
+				all(fd, e, m->flags);
 	}
 
 	igt_fixture {
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-05-22 13:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 13:50 [igt-dev] [CI i-g-t 00/14] Andi's engine discovery for CI Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 01/14] drm-uapi: Import i915_drm.h upto c5d3e39caa456b1e061644b739131f2b54c84c08 Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 02/14] lib/i915: add gem_engine_topology library and for_each loop definition Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 03/14] lib: igt_gt: add execution buffer flags to class helper Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 05/14] lib: igt_dummyload: use for_each_context_engine() Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 06/14] test: perf_pmu: use the gem_engine_topology library Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 07/14] test/i915: gem_busy: " Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 08/14] test/i915: gem_cs_tlb: " Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 09/14] test/i915: gem_ctx_exec: " Tvrtko Ursulin
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 10/14] test/i915: gem_exec_basic: " Tvrtko Ursulin
2019-05-22 13:51 ` Tvrtko Ursulin [this message]
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 12/14] test/i915: gem_exec_store: " Tvrtko Ursulin
2019-05-22 13:51 ` [Intel-gfx] [CI i-g-t 13/14] test/i915: gem_wait: " Tvrtko Ursulin
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 14/14] test/i915: i915_hangman: " Tvrtko Ursulin
2019-05-22 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Andi's engine discovery for CI Patchwork
2019-05-23 10:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522135104.26930-12-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox