From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [CI i-g-t 13/14] test/i915: gem_wait: use the gem_engine_topology library
Date: Wed, 22 May 2019 14:51:03 +0100 [thread overview]
Message-ID: <20190522135104.26930-14-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190522135104.26930-1-tvrtko.ursulin@linux.intel.com>
From: Andi Shyti <andi.shyti@intel.com>
Replace the legacy for_each_engine* defines with the ones
implemented in the gem_engine_topology library.
Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/i915/gem_wait.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
index ee2ecfa0d056..b5e32219d77b 100644
--- a/tests/i915/gem_wait.c
+++ b/tests/i915/gem_wait.c
@@ -134,7 +134,7 @@ static void basic(int fd, unsigned engine, unsigned flags)
igt_main
{
- const struct intel_execution_engine *e;
+ const struct intel_execution_engine2 *e;
int fd = -1;
igt_skip_on_simulation();
@@ -177,27 +177,27 @@ igt_main
basic(fd, ALL_ENGINES, WRITE);
}
- for (e = intel_execution_engines; e->name; e++) {
+ __for_each_physical_engine(fd, e) {
igt_subtest_group {
igt_subtest_f("busy-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, BUSY);
+ basic(fd, e->flags, BUSY);
}
igt_subtest_f("wait-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, 0);
+ basic(fd, e->flags, 0);
}
igt_subtest_f("await-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, AWAIT);
+ basic(fd, e->flags, AWAIT);
}
igt_subtest_f("write-busy-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, BUSY | WRITE);
+ basic(fd, e->flags, BUSY | WRITE);
}
igt_subtest_f("write-wait-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, WRITE);
+ basic(fd, e->flags, WRITE);
}
}
}
@@ -234,22 +234,22 @@ igt_main
basic(fd, ALL_ENGINES, WRITE | HANG);
}
- for (e = intel_execution_engines; e->name; e++) {
+ __for_each_physical_engine(fd, e) {
igt_subtest_f("hang-busy-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, HANG | BUSY);
+ basic(fd, e->flags, HANG | BUSY);
}
igt_subtest_f("hang-wait-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, HANG);
+ basic(fd, e->flags, HANG);
}
igt_subtest_f("hang-busy-write-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, HANG | WRITE | BUSY);
+ basic(fd, e->flags, HANG | WRITE | BUSY);
}
igt_subtest_f("hang-wait-write-%s", e->name) {
gem_quiescent_gpu(fd);
- basic(fd, e->exec_id | e->flags, HANG | WRITE);
+ basic(fd, e->flags, HANG | WRITE);
}
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-22 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 13:50 [igt-dev] [CI i-g-t 00/14] Andi's engine discovery for CI Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 01/14] drm-uapi: Import i915_drm.h upto c5d3e39caa456b1e061644b739131f2b54c84c08 Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 02/14] lib/i915: add gem_engine_topology library and for_each loop definition Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 03/14] lib: igt_gt: add execution buffer flags to class helper Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 05/14] lib: igt_dummyload: use for_each_context_engine() Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 06/14] test: perf_pmu: use the gem_engine_topology library Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 07/14] test/i915: gem_busy: " Tvrtko Ursulin
2019-05-22 13:50 ` [Intel-gfx] [CI i-g-t 08/14] test/i915: gem_cs_tlb: " Tvrtko Ursulin
2019-05-22 13:50 ` [igt-dev] [CI i-g-t 09/14] test/i915: gem_ctx_exec: " Tvrtko Ursulin
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 10/14] test/i915: gem_exec_basic: " Tvrtko Ursulin
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 11/14] test/i915: gem_exec_parallel: " Tvrtko Ursulin
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 12/14] test/i915: gem_exec_store: " Tvrtko Ursulin
2019-05-22 13:51 ` Tvrtko Ursulin [this message]
2019-05-22 13:51 ` [igt-dev] [CI i-g-t 14/14] test/i915: i915_hangman: " Tvrtko Ursulin
2019-05-22 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Andi's engine discovery for CI Patchwork
2019-05-23 10:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522135104.26930-14-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox