From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] prime_vgem: Fix typo in checking for invalid engines
Date: Wed, 29 May 2019 11:12:44 +0300 [thread overview]
Message-ID: <20190529081244.GR22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190527083616.27372-1-chris@chris-wilson.co.uk>
On Mon, May 27, 2019 at 09:36:16AM +0100, Chris Wilson wrote:
> Move the stray ')' from
>
> gem_can_store_dword(exec_id) | exec_flags
>
> to
>
> gem_can_store_dword(exec_id | exec_flags)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110764
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/prime_vgem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
> index 09e3373be..69ae8c9b0 100644
> --- a/tests/prime_vgem.c
> +++ b/tests/prime_vgem.c
> @@ -845,7 +845,7 @@ igt_main
> e->exec_id == 0 ? "basic-" : "",
> e->name) {
> gem_require_ring(i915, e->exec_id | e->flags);
> - igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> + igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>
> gem_quiescent_gpu(i915);
> test_sync(i915, vgem, e->exec_id, e->flags);
> @@ -857,7 +857,7 @@ igt_main
> e->exec_id == 0 ? "basic-" : "",
> e->name) {
> gem_require_ring(i915, e->exec_id | e->flags);
> - igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> + igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>
> gem_quiescent_gpu(i915);
> test_busy(i915, vgem, e->exec_id, e->flags);
> @@ -869,7 +869,7 @@ igt_main
> e->exec_id == 0 ? "basic-" : "",
> e->name) {
> gem_require_ring(i915, e->exec_id | e->flags);
> - igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> + igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>
> gem_quiescent_gpu(i915);
> test_wait(i915, vgem, e->exec_id, e->flags);
> @@ -892,7 +892,7 @@ igt_main
> e->exec_id == 0 ? "basic-" : "",
> e->name) {
> gem_require_ring(i915, e->exec_id | e->flags);
> - igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> + igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>
> gem_quiescent_gpu(i915);
> test_fence_wait(i915, vgem, e->exec_id, e->flags);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-05-29 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 8:36 [igt-dev] [PATCH i-g-t] prime_vgem: Fix typo in checking for invalid engines Chris Wilson
2019-05-27 9:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-27 16:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-29 8:12 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529081244.GR22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox