public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
@ 2019-05-31  8:33 Janusz Krzysztofik
  2019-05-31  8:39 ` Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Janusz Krzysztofik @ 2019-05-31  8:33 UTC (permalink / raw)
  To: Arkadiusz Hiler, Petri Latvala; +Cc: igt-dev, intel-gfx, Janusz Krzysztofik

From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>

If a test calls a function which depends on availabiblity of a
supported mappable aperture, an error may be reported by the kernel on
unsupported hardware.  That may negatively affect results reported by a
test framework even if that test ignores the failure and succeedes.

This helper wraps an IOCTL call which returns a version number of a
mappable aperture.  It may be used by tests which need to adjust their
scope depending on availability of specific version of mappable
aperture.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
Changelog:
v2 (internal) -> v3:
- make the code less obsucre, more explicit (Antonio),
- reword the helper documentation and commit message.

v1 (internal) -> v2 (internal):
- minimize future potential conflicts with 
  https://patchwork.freedesktop.org/patch/294053/?series=58551&rev=1
  (no progress with than one so not waiting for it any longer):
  - convert the helper to a drop-in replacement of the one from the
    above mentioned patch, returning mappable aperture version, not
    only information on its availability,
  - drop any other wrappers,
- document the helper,
- reword commit message.

 lib/i915/gem_mman.c | 22 ++++++++++++++++++++++
 lib/i915/gem_mman.h |  1 +
 2 files changed, 23 insertions(+)

diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
index 3cf9a6bb..3a3f3e5c 100644
--- a/lib/i915/gem_mman.c
+++ b/lib/i915/gem_mman.c
@@ -40,6 +40,28 @@
 #define VG(x) do {} while (0)
 #endif
 
+/**
+ * gem_mmap__gtt_version:
+ * @fd: open i915 drm file descriptor
+ *
+ * This functions wraps up an IOCTL to obtain mappable aperture version.
+ *
+ * Returns: mappable aperture version, -1 on failure.
+ */
+int gem_mmap__gtt_version(int fd)
+{
+	int gtt_version, ret;
+	struct drm_i915_getparam gp = {
+		.param = I915_PARAM_MMAP_GTT_VERSION,
+		.value = &gtt_version,
+	};
+
+	ret = ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
+	if (ret == 0)
+		ret = gtt_version;
+	return ret;
+}
+
 /**
  * __gem_mmap__gtt:
  * @fd: open i915 drm file descriptor
diff --git a/lib/i915/gem_mman.h b/lib/i915/gem_mman.h
index f7242ed7..ab12e566 100644
--- a/lib/i915/gem_mman.h
+++ b/lib/i915/gem_mman.h
@@ -25,6 +25,7 @@
 #ifndef GEM_MMAN_H
 #define GEM_MMAN_H
 
+int gem_mmap__gtt_version(int fd);
 void *gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot);
 void *gem_mmap__cpu(int fd, uint32_t handle, uint64_t offset, uint64_t size, unsigned prot);
 
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:33 [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version Janusz Krzysztofik
@ 2019-05-31  8:39 ` Chris Wilson
  2019-05-31  8:53   ` Janusz Krzysztofik
  2019-05-31  8:41 ` Chris Wilson
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-05-31  8:39 UTC (permalink / raw)
  To: Arkadiusz Hiler, Janusz Krzysztofik, Petri Latvala
  Cc: igt-dev, intel-gfx, Janusz Krzysztofik

Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> 
> If a test calls a function which depends on availabiblity of a
> supported mappable aperture, an error may be reported by the kernel on
> unsupported hardware.  That may negatively affect results reported by a
> test framework even if that test ignores the failure and succeedes.
> 
> This helper wraps an IOCTL call which returns a version number of a
> mappable aperture.  It may be used by tests which need to adjust their
> scope depending on availability of specific version of mappable
> aperture.
> 
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> Changelog:
> v2 (internal) -> v3:
> - make the code less obsucre, more explicit (Antonio),
> - reword the helper documentation and commit message.
> 
> v1 (internal) -> v2 (internal):
> - minimize future potential conflicts with 
>   https://patchwork.freedesktop.org/patch/294053/?series=58551&rev=1
>   (no progress with than one so not waiting for it any longer):
>   - convert the helper to a drop-in replacement of the one from the
>     above mentioned patch, returning mappable aperture version, not
>     only information on its availability,
>   - drop any other wrappers,
> - document the helper,
> - reword commit message.
> 
>  lib/i915/gem_mman.c | 22 ++++++++++++++++++++++
>  lib/i915/gem_mman.h |  1 +
>  2 files changed, 23 insertions(+)
> 
> diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> index 3cf9a6bb..3a3f3e5c 100644
> --- a/lib/i915/gem_mman.c
> +++ b/lib/i915/gem_mman.c
> @@ -40,6 +40,28 @@
>  #define VG(x) do {} while (0)
>  #endif
>  
> +/**
> + * gem_mmap__gtt_version:
> + * @fd: open i915 drm file descriptor
> + *
> + * This functions wraps up an IOCTL to obtain mappable aperture version.
> + *
> + * Returns: mappable aperture version, -1 on failure.
> + */
> +int gem_mmap__gtt_version(int fd)
> +{
> +       int gtt_version, ret;
> +       struct drm_i915_getparam gp = {
> +               .param = I915_PARAM_MMAP_GTT_VERSION,
> +               .value = &gtt_version,
> +       };
> +
> +       ret = ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
> +       if (ret == 0)
> +               ret = gtt_version;
> +       return ret;

Maybe the actual error returned by the kernel and not glibc would be
interesting in the future?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:33 [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version Janusz Krzysztofik
  2019-05-31  8:39 ` Chris Wilson
@ 2019-05-31  8:41 ` Chris Wilson
  2019-05-31  8:54   ` Janusz Krzysztofik
  2019-05-31 14:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-06-01 10:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-05-31  8:41 UTC (permalink / raw)
  To: Arkadiusz Hiler, Janusz Krzysztofik, Petri Latvala
  Cc: igt-dev, intel-gfx, Janusz Krzysztofik

Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>

This is nothing to do with the mappable aperture version. This is the
nee MMAP_GTT interface version.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:39 ` Chris Wilson
@ 2019-05-31  8:53   ` Janusz Krzysztofik
  2019-05-31  8:55     ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Janusz Krzysztofik @ 2019-05-31  8:53 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx, Petri Latvala

Hi Chris,

On Friday, May 31, 2019 10:39:47 AM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> > From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > 
> > If a test calls a function which depends on availabiblity of a
> > supported mappable aperture, an error may be reported by the kernel on
> > unsupported hardware.  That may negatively affect results reported by a
> > test framework even if that test ignores the failure and succeedes.
> > 
> > This helper wraps an IOCTL call which returns a version number of a
> > mappable aperture.  It may be used by tests which need to adjust their
> > scope depending on availability of specific version of mappable
> > aperture.
> > 
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > ---
> > Changelog:
> > v2 (internal) -> v3:
> > - make the code less obsucre, more explicit (Antonio),
> > - reword the helper documentation and commit message.
> > 
> > v1 (internal) -> v2 (internal):
> > - minimize future potential conflicts with 
> >   https://patchwork.freedesktop.org/patch/294053/?series=58551&rev=1
> >   (no progress with than one so not waiting for it any longer):
> >   - convert the helper to a drop-in replacement of the one from the
> >     above mentioned patch, returning mappable aperture version, not
> >     only information on its availability,
> >   - drop any other wrappers,
> > - document the helper,
> > - reword commit message.
> > 
> >  lib/i915/gem_mman.c | 22 ++++++++++++++++++++++
> >  lib/i915/gem_mman.h |  1 +
> >  2 files changed, 23 insertions(+)
> > 
> > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > index 3cf9a6bb..3a3f3e5c 100644
> > --- a/lib/i915/gem_mman.c
> > +++ b/lib/i915/gem_mman.c
> > @@ -40,6 +40,28 @@
> >  #define VG(x) do {} while (0)
> >  #endif
> >  
> > +/**
> > + * gem_mmap__gtt_version:
> > + * @fd: open i915 drm file descriptor
> > + *
> > + * This functions wraps up an IOCTL to obtain mappable aperture version.
> > + *
> > + * Returns: mappable aperture version, -1 on failure.
> > + */
> > +int gem_mmap__gtt_version(int fd)
> > +{
> > +       int gtt_version, ret;
> > +       struct drm_i915_getparam gp = {
> > +               .param = I915_PARAM_MMAP_GTT_VERSION,
> > +               .value = &gtt_version,
> > +       };
> > +
> > +       ret = ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
> > +       if (ret == 0)
> > +               ret = gtt_version;
> > +       return ret;
> 
> Maybe the actual error returned by the kernel and not glibc would be
> interesting in the future?

errno is not overwritten by the helper so it is available to IGT after it is 
called and actually reported when a call to the helper is wrapped with 
igt_require().  Do we need more?

Thanks,
Janusz

> -Chris
> 




_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:41 ` Chris Wilson
@ 2019-05-31  8:54   ` Janusz Krzysztofik
  0 siblings, 0 replies; 9+ messages in thread
From: Janusz Krzysztofik @ 2019-05-31  8:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx, Petri Latvala

On Friday, May 31, 2019 10:41:36 AM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> > From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> 
> This is nothing to do with the mappable aperture version. This is the
> nee MMAP_GTT interface version.
> -Chris
> 
Sorry for my ignorance, I'll reword it.

Thanks,
Janusz



_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:53   ` Janusz Krzysztofik
@ 2019-05-31  8:55     ` Chris Wilson
  2019-05-31  9:03       ` Janusz Krzysztofik
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-05-31  8:55 UTC (permalink / raw)
  To: Janusz Krzysztofik; +Cc: igt-dev, intel-gfx, Petri Latvala

Quoting Janusz Krzysztofik (2019-05-31 09:53:41)
> Hi Chris,
> 
> On Friday, May 31, 2019 10:39:47 AM CEST Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> > > From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > > 
> > > If a test calls a function which depends on availabiblity of a
> > > supported mappable aperture, an error may be reported by the kernel on
> > > unsupported hardware.  That may negatively affect results reported by a
> > > test framework even if that test ignores the failure and succeedes.
> > > 
> > > This helper wraps an IOCTL call which returns a version number of a
> > > mappable aperture.  It may be used by tests which need to adjust their
> > > scope depending on availability of specific version of mappable
> > > aperture.
> > > 
> > > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > > Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> > > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > ---
> > > Changelog:
> > > v2 (internal) -> v3:
> > > - make the code less obsucre, more explicit (Antonio),
> > > - reword the helper documentation and commit message.
> > > 
> > > v1 (internal) -> v2 (internal):
> > > - minimize future potential conflicts with 
> > >   https://patchwork.freedesktop.org/patch/294053/?series=58551&rev=1
> > >   (no progress with than one so not waiting for it any longer):
> > >   - convert the helper to a drop-in replacement of the one from the
> > >     above mentioned patch, returning mappable aperture version, not
> > >     only information on its availability,
> > >   - drop any other wrappers,
> > > - document the helper,
> > > - reword commit message.
> > > 
> > >  lib/i915/gem_mman.c | 22 ++++++++++++++++++++++
> > >  lib/i915/gem_mman.h |  1 +
> > >  2 files changed, 23 insertions(+)
> > > 
> > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > index 3cf9a6bb..3a3f3e5c 100644
> > > --- a/lib/i915/gem_mman.c
> > > +++ b/lib/i915/gem_mman.c
> > > @@ -40,6 +40,28 @@
> > >  #define VG(x) do {} while (0)
> > >  #endif
> > >  
> > > +/**
> > > + * gem_mmap__gtt_version:
> > > + * @fd: open i915 drm file descriptor
> > > + *
> > > + * This functions wraps up an IOCTL to obtain mappable aperture version.
> > > + *
> > > + * Returns: mappable aperture version, -1 on failure.
> > > + */
> > > +int gem_mmap__gtt_version(int fd)
> > > +{
> > > +       int gtt_version, ret;
> > > +       struct drm_i915_getparam gp = {
> > > +               .param = I915_PARAM_MMAP_GTT_VERSION,
> > > +               .value = &gtt_version,
> > > +       };
> > > +
> > > +       ret = ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
> > > +       if (ret == 0)
> > > +               ret = gtt_version;
> > > +       return ret;
> > 
> > Maybe the actual error returned by the kernel and not glibc would be
> > interesting in the future?
> 
> errno is not overwritten by the helper so it is available to IGT after it is 
> called and actually reported when a call to the helper is wrapped with 
> igt_require().  Do we need more?

Yes, we typically return the error and do not use errno. Imagine if we
just replaced ioctl() with syscall() :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:55     ` Chris Wilson
@ 2019-05-31  9:03       ` Janusz Krzysztofik
  0 siblings, 0 replies; 9+ messages in thread
From: Janusz Krzysztofik @ 2019-05-31  9:03 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx, Petri Latvala

On Friday, May 31, 2019 10:55:46 AM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-05-31 09:53:41)
> > Hi Chris,
> > 
> > On Friday, May 31, 2019 10:39:47 AM CEST Chris Wilson wrote:
> > > Quoting Janusz Krzysztofik (2019-05-31 09:33:38)
> > > > From: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > > > 
> > > > If a test calls a function which depends on availabiblity of a
> > > > supported mappable aperture, an error may be reported by the kernel on
> > > > unsupported hardware.  That may negatively affect results reported by a
> > > > test framework even if that test ignores the failure and succeedes.
> > > > 
> > > > This helper wraps an IOCTL call which returns a version number of a
> > > > mappable aperture.  It may be used by tests which need to adjust their
> > > > scope depending on availability of specific version of mappable
> > > > aperture.
> > > > 
> > > > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
> > > > Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> > > > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > > ---
> > > > Changelog:
> > > > v2 (internal) -> v3:
> > > > - make the code less obsucre, more explicit (Antonio),
> > > > - reword the helper documentation and commit message.
> > > > 
> > > > v1 (internal) -> v2 (internal):
> > > > - minimize future potential conflicts with 
> > > >   https://patchwork.freedesktop.org/patch/294053/?series=58551&rev=1
> > > >   (no progress with than one so not waiting for it any longer):
> > > >   - convert the helper to a drop-in replacement of the one from the
> > > >     above mentioned patch, returning mappable aperture version, not
> > > >     only information on its availability,
> > > >   - drop any other wrappers,
> > > > - document the helper,
> > > > - reword commit message.
> > > > 
> > > >  lib/i915/gem_mman.c | 22 ++++++++++++++++++++++
> > > >  lib/i915/gem_mman.h |  1 +
> > > >  2 files changed, 23 insertions(+)
> > > > 
> > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > index 3cf9a6bb..3a3f3e5c 100644
> > > > --- a/lib/i915/gem_mman.c
> > > > +++ b/lib/i915/gem_mman.c
> > > > @@ -40,6 +40,28 @@
> > > >  #define VG(x) do {} while (0)
> > > >  #endif
> > > >  
> > > > +/**
> > > > + * gem_mmap__gtt_version:
> > > > + * @fd: open i915 drm file descriptor
> > > > + *
> > > > + * This functions wraps up an IOCTL to obtain mappable aperture version.
> > > > + *
> > > > + * Returns: mappable aperture version, -1 on failure.
> > > > + */
> > > > +int gem_mmap__gtt_version(int fd)
> > > > +{
> > > > +       int gtt_version, ret;
> > > > +       struct drm_i915_getparam gp = {
> > > > +               .param = I915_PARAM_MMAP_GTT_VERSION,
> > > > +               .value = &gtt_version,
> > > > +       };
> > > > +
> > > > +       ret = ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
> > > > +       if (ret == 0)
> > > > +               ret = gtt_version;
> > > > +       return ret;
> > > 
> > > Maybe the actual error returned by the kernel and not glibc would be
> > > interesting in the future?
> > 
> > errno is not overwritten by the helper so it is available to IGT after it is 
> > called and actually reported when a call to the helper is wrapped with 
> > igt_require().  Do we need more?
> 
> Yes, we typically return the error and do not use errno. Imagine if we
> just replaced ioctl() with syscall() :)

OK. I'll fix it.

Thanks,
Janusz

> -Chris
> 




_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:33 [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version Janusz Krzysztofik
  2019-05-31  8:39 ` Chris Wilson
  2019-05-31  8:41 ` Chris Wilson
@ 2019-05-31 14:35 ` Patchwork
  2019-06-01 10:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-05-31 14:35 UTC (permalink / raw)
  To: Janusz Krzysztofik; +Cc: igt-dev

== Series Details ==

Series: lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
URL   : https://patchwork.freedesktop.org/series/61416/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6173 -> IGTPW_3085
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61416/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3085 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@i915_selftest@live_evict:
    - fi-bsw-kefka:       [PASS][3] -> [DMESG-WARN][4] ([fdo#107709])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-bsw-kefka/igt@i915_selftest@live_evict.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-bsw-kefka/igt@i915_selftest@live_evict.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7567u:       [PASS][5] -> [WARN][6] ([fdo#109380])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-c:
    - fi-kbl-7567u:       [PASS][7] -> [SKIP][8] ([fdo#109271]) +23 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-icl-u3:          [PASS][9] -> [DMESG-WARN][10] ([fdo#107724]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-icl-u3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-icl-u3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html

  * {igt@i915_selftest@live_blt}:
    - fi-skl-iommu:       [INCOMPLETE][13] -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-skl-iommu/igt@i915_selftest@live_blt.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-skl-iommu/igt@i915_selftest@live_blt.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [FAIL][15] ([fdo#103167]) -> [DMESG-FAIL][16] ([fdo#103167] / [fdo#107724])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (48 -> 46)
------------------------------

  Additional (1): fi-icl-dsi 
  Missing    (3): fi-byt-squawks fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5026 -> IGTPW_3085

  CI_DRM_6173: f4b0adf2423ad1c24b655ad956f9463b70f96b89 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3085: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/
  IGT_5026: 4108c74c3b15460de25ab989f4e2031594559dfc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
  2019-05-31  8:33 [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version Janusz Krzysztofik
                   ` (2 preceding siblings ...)
  2019-05-31 14:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-06-01 10:22 ` Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-06-01 10:22 UTC (permalink / raw)
  To: Janusz Krzysztofik; +Cc: igt-dev

== Series Details ==

Series: lib/i915/gem_mman: Add a helper for obtaining mappable aperture version
URL   : https://patchwork.freedesktop.org/series/61416/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6173_full -> IGTPW_3085_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61416/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3085_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@forked-medium-copy:
    - shard-iclb:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107713]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb3/igt@gem_mmap_gtt@forked-medium-copy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb4/igt@gem_mmap_gtt@forked-medium-copy.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [PASS][3] -> [FAIL][4] ([fdo#108686])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb3/igt@gem_tiled_swapping@non-threaded.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb3/igt@gem_tiled_swapping@non-threaded.html
    - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108686])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-glk9/igt@gem_tiled_swapping@non-threaded.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-glk3/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-apl5/igt@i915_suspend@fence-restore-untiled.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-apl6/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][9] -> [FAIL][10] ([fdo#103167]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109642])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb2/igt@kms_psr2_su@page_flip.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb6/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][13] -> [FAIL][14] ([fdo#108341])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb5/igt@kms_psr@no_drrs.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][17] -> [FAIL][18] ([fdo#99912])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-apl1/igt@kms_setmode@basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-apl5/igt@kms_setmode@basic.html
    - shard-snb:          [PASS][19] -> [FAIL][20] ([fdo#99912])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-snb6/igt@kms_setmode@basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-snb4/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_exec_params@sol-reset-invalid:
    - shard-glk:          [INCOMPLETE][21] ([fdo#103359] / [k.org#198133]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-glk9/igt@gem_exec_params@sol-reset-invalid.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-glk8/igt@gem_exec_params@sol-reset-invalid.html

  * igt@gem_fence_thrash@bo-write-verify-threaded-y:
    - shard-iclb:         [INCOMPLETE][23] ([fdo#107713] / [fdo#109100]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb7/igt@gem_fence_thrash@bo-write-verify-threaded-y.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb8/igt@gem_fence_thrash@bo-write-verify-threaded-y.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [FAIL][25] ([fdo#108686]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-kbl1/igt@gem_tiled_swapping@non-threaded.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-kbl4/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-apl6/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [SKIP][29] ([fdo#109271]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
    - shard-apl:          [INCOMPLETE][31] ([fdo#103927]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-apl5/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-apl6/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html

  * igt@kms_flip@flip-vs-panning-interruptible:
    - shard-iclb:         [INCOMPLETE][33] ([fdo#107713]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb3/igt@kms_flip@flip-vs-panning-interruptible.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb4/igt@kms_flip@flip-vs-panning-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-iclb:         [FAIL][35] ([fdo#103167]) -> [PASS][36] +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [SKIP][37] ([fdo#109441]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_sequence@get-forked:
    - shard-snb:          [SKIP][39] ([fdo#109271]) -> [PASS][40] +4 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-snb6/igt@kms_sequence@get-forked.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-snb7/igt@kms_sequence@get-forked.html

  * igt@perf_pmu@rc6-runtime-pm-long:
    - shard-glk:          [FAIL][41] ([fdo#105010]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-glk7/igt@perf_pmu@rc6-runtime-pm-long.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-glk4/igt@perf_pmu@rc6-runtime-pm-long.html

  
#### Warnings ####

  * igt@gem_mmap_gtt@forked-big-copy-odd:
    - shard-iclb:         [TIMEOUT][43] ([fdo#109673]) -> [INCOMPLETE][44] ([fdo#107713] / [fdo#109100])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-iclb2/igt@gem_mmap_gtt@forked-big-copy-odd.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-iclb7/igt@gem_mmap_gtt@forked-big-copy-odd.html

  * igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
    - shard-snb:          [SKIP][45] ([fdo#109271]) -> [SKIP][46] ([fdo#109271] / [fdo#109278])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/shard-snb7/igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/shard-snb4/igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5026 -> IGTPW_3085
  * Piglit: piglit_4509 -> None

  CI_DRM_6173: f4b0adf2423ad1c24b655ad956f9463b70f96b89 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3085: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/
  IGT_5026: 4108c74c3b15460de25ab989f4e2031594559dfc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-06-01 10:22 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31  8:33 [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version Janusz Krzysztofik
2019-05-31  8:39 ` Chris Wilson
2019-05-31  8:53   ` Janusz Krzysztofik
2019-05-31  8:55     ` Chris Wilson
2019-05-31  9:03       ` Janusz Krzysztofik
2019-05-31  8:41 ` Chris Wilson
2019-05-31  8:54   ` Janusz Krzysztofik
2019-05-31 14:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-01 10:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox