From: Petri Latvala <petri.latvala@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator
Date: Mon, 3 Jun 2019 14:19:19 +0300 [thread overview]
Message-ID: <20190603111919.GA22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <2165d563-140f-1fb8-5234-c0099892fe96@linux.intel.com>
On Mon, Jun 03, 2019 at 11:39:25AM +0100, Tvrtko Ursulin wrote:
>
> On 03/06/2019 11:32, Petri Latvala wrote:
> > On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 29/05/2019 14:24, Chris Wilson wrote:
> > > > If we run out of engines, intel_get_current_physical_engine() degrades
> > > > into an infinite loop as although it advanced the iterator, it did not
> > > > update its local engine pointer.
> > >
> > > We had one infinite loop in there already.. AFAIR it was on one engine
> > > platforms. Does the new incarnation happen actually via the
> > > __for_each_physical_engine iterator or perhaps only when calling
> > > intel_get_current_physical_engine after loop end? Why it wasn't seen in
> > > testing?
> >
> >
> > The new incarnation happens with a wedged GPU. That's a case that's
> > hard to come by in testing.
>
> 1.
> Colour me confused. :) How does a wedged GPU affect this loop?
Wedging could be a red herring, but regardless the GPU was in a funky
state.
An easy reproduction method is just
# ./perf_pmu
(as normal user, not root!)
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-03 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 13:24 [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator Chris Wilson
2019-05-29 14:33 ` Andi Shyti
2019-05-29 14:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-29 21:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-03 10:19 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2019-06-03 10:32 ` Petri Latvala
2019-06-03 10:39 ` Tvrtko Ursulin
2019-06-03 11:19 ` Petri Latvala [this message]
2019-06-03 12:47 ` [Intel-gfx] " Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603111919.GA22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox