public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again
Date: Tue,  4 Jun 2019 11:46:12 +0300	[thread overview]
Message-ID: <20190604084612.13950-1-petri.latvala@intel.com> (raw)

In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
library") perf_pmu was converted to use gem_context_has_engine()
instead of gem_require_engine, but missing the crucial part of
igt_require().

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 tests/perf_pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 72b9166a..fdaf96da 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1714,7 +1714,7 @@ igt_main
 
 		igt_subtest_group {
 			igt_fixture {
-				gem_context_has_engine(fd, 0, e->flags);
+				igt_require(gem_context_has_engine(fd, 0, e->flags));
 			}
 
 			/**
@@ -1903,8 +1903,8 @@ igt_main
 		__for_each_physical_engine(render_fd, e) {
 			igt_subtest_group {
 				igt_fixture {
-					gem_context_has_engine(render_fd,
-							   0, e->flags);
+					igt_require(gem_context_has_engine(render_fd,
+									   0, e->flags));
 				}
 
 				igt_subtest_f("render-node-busy-%s", e->name)
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-06-04  8:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  8:46 Petri Latvala [this message]
2019-06-04  8:51 ` [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again Tvrtko Ursulin
2019-06-05  9:08   ` Petri Latvala
2019-06-05  9:49     ` Tvrtko Ursulin
2019-06-05 11:27       ` Andi Shyti
2019-06-05 12:03         ` Petri Latvala
2019-06-05 12:32           ` Petri Latvala
2019-06-05 12:06         ` Tvrtko Ursulin
2019-06-04 10:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-04 17:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604084612.13950-1-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox