public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again
Date: Wed, 5 Jun 2019 14:27:50 +0300	[thread overview]
Message-ID: <20190605112750.GA2690@intel.intel> (raw)
In-Reply-To: <bf72e9ea-4a16-bdc2-22c9-b2c582548277@linux.intel.com>

Hi,

> > > >    		igt_subtest_group {
> > > >    			igt_fixture {
> > > > -				gem_context_has_engine(fd, 0, e->flags);
> > > > +				igt_require(gem_context_has_engine(fd, 0, e->flags));
> > > 
> > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > engines.
> > 
> > 
> > Good question, looks like no.
> > 
> > Does the iterator only give available engines on ye olde kernels too?
> 
> There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> the legacy path so I think it filters them there as well.
> 
> Andi?

yes, indeed, what exactly is the issue?

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-06-05 11:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  8:46 [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again Petri Latvala
2019-06-04  8:51 ` Tvrtko Ursulin
2019-06-05  9:08   ` Petri Latvala
2019-06-05  9:49     ` Tvrtko Ursulin
2019-06-05 11:27       ` Andi Shyti [this message]
2019-06-05 12:03         ` Petri Latvala
2019-06-05 12:32           ` Petri Latvala
2019-06-05 12:06         ` Tvrtko Ursulin
2019-06-04 10:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-04 17:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605112750.GA2690@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox