public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: reduce flatline test amplitude
Date: Fri, 14 Jun 2019 11:42:56 +0300	[thread overview]
Message-ID: <20190614084256.25900-1-simon.ser@intel.com> (raw)

Set flatline test amplitude to 0.1 instead of 0.9. There have been concerns
about edge-cases where bad TV hardware is connected via HDMI/DP and breaks when
a DC offset is sent.

This is a first mitigation. A second mitigation to only send audio to the
Chamelium device instead of all HDMI/DP ports is planned, but requires changes
in ALSA and/or DRM.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 tests/kms_chamelium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 36e92e975d64..0bfb0838d013 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -775,7 +775,7 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 /* A streak of 3 gives confidence that the signal is good. */
 #define MIN_STREAK 3

-#define FLATLINE_AMPLITUDE 0.9 /* normalized, ie. in [0, 1] */
+#define FLATLINE_AMPLITUDE 0.1 /* normalized, ie. in [0, 1] */
 #define FLATLINE_AMPLITUDE_ACCURACY 0.001 /* ± 0.1 % of the full amplitude */
 #define FLATLINE_ALIGN_ACCURACY 0 /* number of samples */

--
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-06-14  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14  8:42 Simon Ser [this message]
2019-06-14 12:54 ` [igt-dev] [PATCH i-g-t] tests/kms_chamelium: reduce flatline test amplitude Peres, Martin
2019-06-14 21:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-15 15:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614084256.25900-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox