public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_chamelium: reduce flatline test amplitude
@ 2019-06-14  8:42 Simon Ser
  2019-06-14 12:54 ` Peres, Martin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Simon Ser @ 2019-06-14  8:42 UTC (permalink / raw)
  To: igt-dev; +Cc: martin.peres

Set flatline test amplitude to 0.1 instead of 0.9. There have been concerns
about edge-cases where bad TV hardware is connected via HDMI/DP and breaks when
a DC offset is sent.

This is a first mitigation. A second mitigation to only send audio to the
Chamelium device instead of all HDMI/DP ports is planned, but requires changes
in ALSA and/or DRM.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 tests/kms_chamelium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 36e92e975d64..0bfb0838d013 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -775,7 +775,7 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 /* A streak of 3 gives confidence that the signal is good. */
 #define MIN_STREAK 3

-#define FLATLINE_AMPLITUDE 0.9 /* normalized, ie. in [0, 1] */
+#define FLATLINE_AMPLITUDE 0.1 /* normalized, ie. in [0, 1] */
 #define FLATLINE_AMPLITUDE_ACCURACY 0.001 /* ± 0.1 % of the full amplitude */
 #define FLATLINE_ALIGN_ACCURACY 0 /* number of samples */

--
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-15 15:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14  8:42 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: reduce flatline test amplitude Simon Ser
2019-06-14 12:54 ` Peres, Martin
2019-06-14 21:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-15 15:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox