* [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out
@ 2019-06-17 12:57 Simon Ser
2019-06-17 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Simon Ser @ 2019-06-17 12:57 UTC (permalink / raw)
To: igt-dev; +Cc: martin.peres
Signed-off-by: Simon Ser <simon.ser@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
---
v2: clarify log message
tests/kms_flip.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 2a158d97bbec..6eadb71b3ed9 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -686,14 +686,17 @@ static unsigned int run_test_step(struct test_output *o)
!(o->pending_events & EVENT_VBLANK) && o->flip_state.count > 0) {
struct vblank_reply reply;
unsigned int exp_seq;
- unsigned long start;
+ unsigned long start, end;
exp_seq = o->flip_state.current_seq;
start = gettime_us();
do_or_die(__wait_for_vblank(TEST_VBLANK_ABSOLUTE |
TEST_VBLANK_BLOCK, o->pipe, exp_seq,
0, &reply));
- igt_assert(gettime_us() - start < 500);
+ end = gettime_us();
+ igt_assert_f(end - start < 500, "Vblank wait took longer than "
+ "expected: %luus >= %dus",
+ end - start, 500);
igt_assert_eq(reply.sequence, exp_seq);
igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
}
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2)
2019-06-17 12:57 [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Simon Ser
@ 2019-06-17 14:33 ` Patchwork
2019-06-17 14:49 ` Ser, Simon
2019-06-17 15:17 ` Patchwork
2019-06-19 14:44 ` [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Arkadiusz Hiler
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2019-06-17 14:33 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip: improve logging when timing out (rev2)
URL : https://patchwork.freedesktop.org/series/62100/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6285 -> IGTPW_3162
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3162 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3162, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62100/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3162:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_evict:
- fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-cfl-guc/igt@i915_selftest@live_evict.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-cfl-guc/igt@i915_selftest@live_evict.html
* igt@runner@aborted:
- fi-cfl-guc: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-cfl-guc/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_3162 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-skl-6700k2: [PASS][6] -> [INCOMPLETE][7] ([fdo#104108])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-skl-6700k2/igt@kms_chamelium@common-hpd-after-suspend.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-skl-6700k2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][8] -> [DMESG-WARN][9] ([fdo#102614])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
- fi-icl-u2: [PASS][10] -> [FAIL][11] ([fdo#103167])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- fi-icl-guc: [INCOMPLETE][12] ([fdo#107713] / [fdo#108569]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
* igt@gem_exec_reloc@basic-gtt:
- fi-icl-u3: [DMESG-WARN][14] ([fdo#107724]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: [DMESG-WARN][16] ([fdo#107709]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-bsw-kefka/igt@i915_selftest@live_evict.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-bsw-kefka/igt@i915_selftest@live_evict.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-dsi: [INCOMPLETE][18] ([fdo#107713] / [fdo#108569]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (50 -> 37)
------------------------------
Missing (13): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-whl-u fi-skl-iommu fi-icl-y fi-byt-clapper fi-bdw-samus fi-cml-u
Build changes
-------------
* IGT: IGT_5059 -> IGTPW_3162
CI_DRM_6285: f5c04040623ef8068dd881438d53e7b5834919fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3162: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2)
2019-06-17 12:57 [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Simon Ser
2019-06-17 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2) Patchwork
@ 2019-06-17 15:17 ` Patchwork
2019-06-19 14:44 ` [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-06-17 15:17 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip: improve logging when timing out (rev2)
URL : https://patchwork.freedesktop.org/series/62100/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6285 -> IGTPW_3162
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3162 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3162, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62100/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3162:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_evict:
- fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-cfl-guc/igt@i915_selftest@live_evict.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-cfl-guc/igt@i915_selftest@live_evict.html
* igt@runner@aborted:
- fi-cfl-guc: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-cfl-guc/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_3162 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-skl-6700k2: [PASS][6] -> [INCOMPLETE][7] ([fdo#104108])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-skl-6700k2/igt@kms_chamelium@common-hpd-after-suspend.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-skl-6700k2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][8] -> [DMESG-WARN][9] ([fdo#102614])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
- fi-icl-u2: [PASS][10] -> [FAIL][11] ([fdo#103167])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- fi-icl-guc: [INCOMPLETE][12] ([fdo#107713] / [fdo#108569]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
* igt@gem_exec_reloc@basic-gtt:
- fi-icl-u3: [DMESG-WARN][14] ([fdo#107724]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-u3/igt@gem_exec_reloc@basic-gtt.html
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: [DMESG-WARN][16] ([fdo#107709]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-bsw-kefka/igt@i915_selftest@live_evict.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-bsw-kefka/igt@i915_selftest@live_evict.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [INCOMPLETE][18] ([fdo#107713] / [fdo#108569]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-y/igt@i915_selftest@live_hangcheck.html
- fi-icl-dsi: [INCOMPLETE][20] ([fdo#107713] / [fdo#108569]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6285/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (50 -> 38)
------------------------------
Missing (12): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-whl-u fi-skl-iommu fi-byt-clapper fi-bdw-samus fi-cml-u
Build changes
-------------
* IGT: IGT_5059 -> IGTPW_3162
CI_DRM_6285: f5c04040623ef8068dd881438d53e7b5834919fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3162: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3162/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out
2019-06-17 12:57 [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Simon Ser
2019-06-17 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2) Patchwork
2019-06-17 15:17 ` Patchwork
@ 2019-06-19 14:44 ` Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-06-19 14:44 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev, martin.peres
On Mon, Jun 17, 2019 at 03:57:15PM +0300, Simon Ser wrote:
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
Since there is CI bug associated with this assert we would need to
adjust the filters before mergeing. Please make sure that this happens.
> ---
>
> v2: clarify log message
>
> tests/kms_flip.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 2a158d97bbec..6eadb71b3ed9 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -686,14 +686,17 @@ static unsigned int run_test_step(struct test_output *o)
> !(o->pending_events & EVENT_VBLANK) && o->flip_state.count > 0) {
> struct vblank_reply reply;
> unsigned int exp_seq;
> - unsigned long start;
> + unsigned long start, end;
>
> exp_seq = o->flip_state.current_seq;
> start = gettime_us();
> do_or_die(__wait_for_vblank(TEST_VBLANK_ABSOLUTE |
> TEST_VBLANK_BLOCK, o->pipe, exp_seq,
> 0, &reply));
> - igt_assert(gettime_us() - start < 500);
> + end = gettime_us();
> + igt_assert_f(end - start < 500, "Vblank wait took longer than "
> + "expected: %luus >= %dus",
> + end - start, 500);
What about adding an igt_debug() for the (end - start)? That would help
us to understand how long does it usually take, so we would have a
baseline for comparison.
> igt_assert_eq(reply.sequence, exp_seq);
> igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
> }
> --
> 2.22.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-19 14:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-17 12:57 [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Simon Ser
2019-06-17 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: improve logging when timing out (rev2) Patchwork
2019-06-17 14:49 ` Ser, Simon
2019-06-17 15:17 ` Patchwork
2019-06-19 14:44 ` [igt-dev] [PATCH i-g-t v2] tests/kms_flip: improve logging when timing out Arkadiusz Hiler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox