* [igt-dev] [PATCH i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message
@ 2019-07-04 13:30 Arkadiusz Hiler
2019-07-04 13:30 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_ccs: Clean up output selection Arkadiusz Hiler
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-07-04 13:30 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan
If CCS is not supported, i.e. we have executed no test for it, let's
skip with a message saying so instead of mysterious requirement on
test_output().
A lot of people get confused by current output thinking that there is
something wrong with output/modes.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110580
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_ccs.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 2f08a837..5a1f940e 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -297,7 +297,7 @@ static int test_ccs(data_t *data)
return valid_tests;
}
-static int test_output(data_t *data)
+static int __test_output(data_t *data)
{
igt_display_t *display = &data->display;
int i, valid_tests = 0;
@@ -322,6 +322,12 @@ static int test_output(data_t *data)
return valid_tests;
}
+static void test_output(data_t *data)
+{
+ int valid_tests = __test_output(data);
+ igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+}
+
static data_t data;
igt_main
@@ -345,19 +351,18 @@ igt_main
data.flags = TEST_BAD_PIXEL_FORMAT;
igt_subtest_f("pipe-%s-bad-pixel-format", pipe_name)
- igt_require(test_output(&data));
data.flags = TEST_BAD_ROTATION_90;
igt_subtest_f("pipe-%s-bad-rotation-90", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC;
igt_subtest_f("pipe-%s-crc-primary-basic", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC | TEST_ROTATE_180;
igt_subtest_f("pipe-%s-crc-primary-rotation-180", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC;
igt_subtest_f("pipe-%s-crc-sprite-planes-basic", pipe_name) {
@@ -368,25 +373,25 @@ igt_main
for_each_plane_on_pipe(&data.display, data.pipe, data.plane) {
if (data.plane->type == DRM_PLANE_TYPE_PRIMARY)
continue;
- valid_tests += test_output(&data);
+ valid_tests += __test_output(&data);
}
- igt_require(valid_tests);
+ igt_require_f(valid_tests > 0, "CCS not supported, skipping");
}
data.plane = NULL;
data.flags = TEST_NO_AUX_BUFFER;
igt_subtest_f("pipe-%s-missing-ccs-buffer", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_BAD_CCS_HANDLE;
igt_subtest_f("pipe-%s-ccs-on-another-bo", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_BAD_AUX_STRIDE;
igt_subtest_f("pipe-%s-bad-aux-stride", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
}
igt_fixture
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] [PATCH i-g-t 2/2] tests/kms_ccs: Clean up output selection
2019-07-04 13:30 [igt-dev] [PATCH i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message Arkadiusz Hiler
@ 2019-07-04 13:30 ` Arkadiusz Hiler
2019-07-04 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message Patchwork
2019-07-10 7:42 ` [igt-dev] [PATCH v2 i-g-t 1/2] " Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-07-04 13:30 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan
Use function that is meant to get the output instead of relying on a
magic for-loop.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_ccs.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 5a1f940e..a834b2f5 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -302,12 +302,8 @@ static int __test_output(data_t *data)
igt_display_t *display = &data->display;
int i, valid_tests = 0;
- igt_display_require_output_on_pipe(display, data->pipe);
-
- /* Sets data->output with a valid output. */
- for_each_valid_output_on_pipe(display, data->pipe, data->output) {
- break;
- }
+ data->output = igt_get_single_output_for_pipe(display, data->pipe);
+ igt_require(data->output);
igt_output_set_pipe(data->output, data->pipe);
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message
2019-07-04 13:30 [igt-dev] [PATCH i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message Arkadiusz Hiler
2019-07-04 13:30 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_ccs: Clean up output selection Arkadiusz Hiler
@ 2019-07-04 14:33 ` Patchwork
2019-07-05 6:26 ` Arkadiusz Hiler
2019-07-10 7:42 ` [igt-dev] [PATCH v2 i-g-t 1/2] " Arkadiusz Hiler
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2019-07-04 14:33 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message
URL : https://patchwork.freedesktop.org/series/63226/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6413 -> IGTPW_3242
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3242 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3242, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/63226/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3242:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_hangcheck:
- fi-kbl-guc: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6413/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
Known issues
------------
Here are the changes found in IGTPW_3242 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6413/fi-icl-u3/igt@kms_addfb_basic@addfb25-y-tiled-small.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/fi-icl-u3/igt@kms_addfb_basic@addfb25-y-tiled-small.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-write-gtt:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6413/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html
* igt@i915_selftest@live_contexts:
- fi-skl-iommu: [INCOMPLETE][7] ([fdo#111050]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6413/fi-skl-iommu/igt@i915_selftest@live_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/fi-skl-iommu/igt@i915_selftest@live_contexts.html
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050
Participating hosts (52 -> 47)
------------------------------
Additional (3): fi-icl-guc fi-bsw-n3050 fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5083 -> IGTPW_3242
CI_DRM_6413: e34db06fa7ab85da62d786e2803dcef578f93360 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/
IGT_5083: 4d710ea530aca69304df37191802476f406746ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message
2019-07-04 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message Patchwork
@ 2019-07-05 6:26 ` Arkadiusz Hiler
0 siblings, 0 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-07-05 6:26 UTC (permalink / raw)
To: igt-dev
On Thu, Jul 04, 2019 at 02:33:48PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message
> URL : https://patchwork.freedesktop.org/series/63226/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6413 -> IGTPW_3242
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_3242 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_3242, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/63226/revisions/1/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in IGTPW_3242:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live_hangcheck:
> - fi-kbl-guc: [PASS][1] -> [DMESG-WARN][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6413/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3242/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
There were expected new failures due to some logging changes but in
kms_ccs so definately not any of the selftests :-)
Martin, can you file this bug and re-report? Thanks in advance!
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH v2 i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message
2019-07-04 13:30 [igt-dev] [PATCH i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message Arkadiusz Hiler
2019-07-04 13:30 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_ccs: Clean up output selection Arkadiusz Hiler
2019-07-04 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message Patchwork
@ 2019-07-10 7:42 ` Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2019-07-10 7:42 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan
If CCS is not supported, i.e. we have executed no test for it, let's
skip with a message saying so instead of mysterious requirement on
test_output().
A lot of people get confused by current output thinking that there is
something wrong with output/modes.
v2: actually run tests for bad-pixel-format
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110580
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_ccs.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 2f08a837..3b98d626 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -297,7 +297,7 @@ static int test_ccs(data_t *data)
return valid_tests;
}
-static int test_output(data_t *data)
+static int __test_output(data_t *data)
{
igt_display_t *display = &data->display;
int i, valid_tests = 0;
@@ -322,6 +322,12 @@ static int test_output(data_t *data)
return valid_tests;
}
+static void test_output(data_t *data)
+{
+ int valid_tests = __test_output(data);
+ igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+}
+
static data_t data;
igt_main
@@ -345,19 +351,19 @@ igt_main
data.flags = TEST_BAD_PIXEL_FORMAT;
igt_subtest_f("pipe-%s-bad-pixel-format", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_BAD_ROTATION_90;
igt_subtest_f("pipe-%s-bad-rotation-90", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC;
igt_subtest_f("pipe-%s-crc-primary-basic", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC | TEST_ROTATE_180;
igt_subtest_f("pipe-%s-crc-primary-rotation-180", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_CRC;
igt_subtest_f("pipe-%s-crc-sprite-planes-basic", pipe_name) {
@@ -368,25 +374,25 @@ igt_main
for_each_plane_on_pipe(&data.display, data.pipe, data.plane) {
if (data.plane->type == DRM_PLANE_TYPE_PRIMARY)
continue;
- valid_tests += test_output(&data);
+ valid_tests += __test_output(&data);
}
- igt_require(valid_tests);
+ igt_require_f(valid_tests > 0, "CCS not supported, skipping");
}
data.plane = NULL;
data.flags = TEST_NO_AUX_BUFFER;
igt_subtest_f("pipe-%s-missing-ccs-buffer", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_BAD_CCS_HANDLE;
igt_subtest_f("pipe-%s-ccs-on-another-bo", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
data.flags = TEST_BAD_AUX_STRIDE;
igt_subtest_f("pipe-%s-bad-aux-stride", pipe_name)
- igt_require(test_output(&data));
+ test_output(&data);
}
igt_fixture
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-10 7:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-04 13:30 [igt-dev] [PATCH i-g-t 1/2] tests/kms_ccs: Skip with a more meaningful message Arkadiusz Hiler
2019-07-04 13:30 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_ccs: Clean up output selection Arkadiusz Hiler
2019-07-04 14:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_ccs: Skip with a more meaningful message Patchwork
2019-07-05 6:26 ` Arkadiusz Hiler
2019-07-10 7:42 ` [igt-dev] [PATCH v2 i-g-t 1/2] " Arkadiusz Hiler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox