From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11
Date: Thu, 25 Jul 2019 13:33:53 -0700 [thread overview]
Message-ID: <20190725203354.6757-4-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20190725203354.6757-1-lucas.demarchi@intel.com>
Gen 11 still has the per-context MOCS table. It's gen 12 and later that
only has a global MOCS table available so it doesn't make sense to test
dirtying it per context.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
tests/i915/gem_mocs_settings.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index e3da8515..9ec0b122 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -483,12 +483,13 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
uint32_t ctx_clean_id;
uint32_t ctx_dirty_id;
- /* As mocs is global for GEN11+, trying privileged write to dirty
+ /*
+ * As mocs is global for GEN12+, trying privileged write to dirty
* the mocs and testing context save and restore of mocs between
* contexts is bound to fail.
*/
if (flags & MOCS_DIRTY_VALUES)
- igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 11);
+ igt_skip_on(intel_gen(intel_get_drm_devid(fd)) >= 12);
gem_require_ring(fd, engine);
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-07-25 20:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
2019-07-26 20:49 ` Daniele Ceraolo Spurio
2019-07-26 20:57 ` Chris Wilson
2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
2019-07-27 0:16 ` Daniele Ceraolo Spurio
2019-07-25 20:33 ` Lucas De Marchi [this message]
2019-07-29 20:53 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Kumar Valsan, Prathap
2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
2019-07-27 0:23 ` Daniele Ceraolo Spurio
2019-07-25 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index Patchwork
2019-07-25 21:45 ` [igt-dev] [PATCH 1/5] " Lucas De Marchi
2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
2019-07-26 23:26 ` Daniele Ceraolo Spurio
2019-07-26 23:49 ` Lucas De Marchi
2019-07-26 23:54 ` Daniele Ceraolo Spurio
2019-07-27 0:04 ` Lucas De Marchi
2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
2019-07-26 23:35 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725203354.6757-4-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox