Re: [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> In the Ice Lake table we are setting all undefined entries to PTE.
> With Tiger Lake this won't be true anymore. Even if for test in IGT we
> add a new table for Tiger Lake, in kernel they can be shares since they
> are supposedly compatible (only unused entries were added or became
> unused).
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

And we shouldn't be guaranteeing that unused entries are set to 
something sensible as part of the ABI.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   tests/i915/gem_mocs_settings.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 7b1718f4..9f4e1b6d 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -101,7 +101,6 @@ static const struct mocs_entry icelake_mocs_table[GEN11_NUM_MOCS_ENTRIES] = {
>   	[21] = { 0x00000137, 0x0030, 0x1},
>   	[22] = { 0x000003b7, 0x0030, 0x1},
>   	[23] = { 0x000007b7, 0x0030, 0x1},
> -	[24 ... 61] = ICELAKE_MOCS_PTE,
>   	[62] = { 0x00000037, 0x0010, 0x1},
>   	[63] = { 0x00000037, 0x0010, 0x1},
>   };
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev